Fix build

Author: Iryna Vasylenko

README.md

@@ -116,14 +116,17 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [badge-needs-accessible-name](docs/rules/badge-needs-accessible-name.md)                                               |                                                                                                                                                                              | ✅  |    | 🔧 |
 | [breadcrumb-needs-labelling](docs/rules/breadcrumb-needs-labelling.md)                                                 | All interactive elements must have an accessible name                                                                                                                        | ✅  |    |    |
 | [checkbox-needs-labelling](docs/rules/checkbox-needs-labelling.md)                                                     | Accessibility: Checkbox without label must have an accessible and visual label: aria-labelledby                                                                              | ✅  |    |    |
+| [colorswatch-needs-labelling](docs/rules/colorswatch-needs-labelling.md)                                               | Accessibility: ColorSwatch must have an accessible name via aria-label, Tooltip, aria-labelledby, etc..                                                                      | ✅  |    |    |
 | [combobox-needs-labelling](docs/rules/combobox-needs-labelling.md)                                                     | All interactive elements must have an accessible name                                                                                                                        | ✅  |    |    |
 | [compound-button-needs-labelling](docs/rules/compound-button-needs-labelling.md)                                       | Accessibility: Compound buttons must have accessible labelling: title, aria-label, aria-labelledby, aria-describedby                                                         | ✅  |    |    |
 | [counter-badge-needs-count](docs/rules/counter-badge-needs-count.md)                                                   |                                                                                                                                                                              | ✅  |    | 🔧 |
 | [dialogbody-needs-title-content-and-actions](docs/rules/dialogbody-needs-title-content-and-actions.md)                 | A DialogBody should have a header(DialogTitle), content(DialogContent), and footer(DialogActions)                                                                            | ✅  |    |    |
 | [dialogsurface-needs-aria](docs/rules/dialogsurface-needs-aria.md)                                                     | DialogueSurface need accessible labelling: aria-describedby on DialogueSurface and aria-label or aria-labelledby(if DialogueTitle is missing)                                | ✅  |    |    |
 | [dropdown-needs-labelling](docs/rules/dropdown-needs-labelling.md)                                                     | Accessibility: Dropdown menu must have an id and it needs to be linked via htmlFor of a Label                                                                                | ✅  |    |    |
+| [emptyswatch-needs-labelling](docs/rules/emptyswatch-needs-labelling.md)                                               | Accessibility: EmptySwatch must have an accessible name via aria-label, Tooltip, aria-labelledby, etc..                                                                      | ✅  |    |    |
 | [field-needs-labelling](docs/rules/field-needs-labelling.md)                                                           | Accessibility: Field must have label                                                                                                                                         | ✅  |    |    |
 | [image-button-missing-aria](docs/rules/image-button-missing-aria.md)                                                   | Accessibility: Image buttons must have accessible labelling: title, aria-label, aria-labelledby, aria-describedby                                                            | ✅  |    |    |
+| [imageswatch-needs-labelling](docs/rules/imageswatch-needs-labelling.md)                                               | Accessibility: ImageSwatch must have an accessible name via aria-label, Tooltip, aria-labelledby, etc..                                                                      | ✅  |    |    |
 | [input-components-require-accessible-name](docs/rules/input-components-require-accessible-name.md)                     | Accessibility: Input fields must have accessible labelling: aria-label, aria-labelledby or an associated label                                                               | ✅  |    |    |
 | [link-missing-labelling](docs/rules/link-missing-labelling.md)                                                         | Accessibility: Image links must have an accessible name. Add either text content, labelling to the image or labelling to the link itself.                                    | ✅  |    | 🔧 |
 | [menu-item-needs-labelling](docs/rules/menu-item-needs-labelling.md)                                                   | Accessibility: MenuItem without label must have an accessible and visual label: aria-labelledby                                                                              | ✅  |    |    |
@@ -140,7 +143,7 @@ Any use of third-party trademarks or logos are subject to those third-party's po
 | [switch-needs-labelling](docs/rules/switch-needs-labelling.md)                                                         | Accessibility: Switch must have an accessible label                                                                                                                          | ✅  |    |    |
 | [tablist-and-tabs-need-labelling](docs/rules/tablist-and-tabs-need-labelling.md)                                       | This rule aims to ensure that Tabs with icons but no text labels have an accessible name and that Tablist is properly labeled.                                               | ✅  |    |    |
 | [tag-dismissible-needs-labelling](docs/rules/tag-dismissible-needs-labelling.md)                                       | This rule aims to ensure that dismissible Tag components have proper accessibility labelling: either aria-label on dismissIcon or aria-label on Tag with role on dismissIcon | ✅  |    |    |
-| [tag-needs-name](docs/rules/tag-needs-name.md)                                                                         | This rule aims to ensure that Tag component have an accessible name via text content, aria-label, or aria-labelledby.                                                        | ✅  |    |    |
+| [tag-needs-name](docs/rules/tag-needs-name.md)                                                                         | Accessibility: Tag must have an accessible name                                                                                                                              | ✅  |    |    |
 | [toolbar-missing-aria](docs/rules/toolbar-missing-aria.md)                                                             | Accessibility: Toolbars need accessible labelling: aria-label or aria-labelledby                                                                                             | ✅  |    |    |
 | [tooltip-not-recommended](docs/rules/tooltip-not-recommended.md)                                                       | Accessibility: Prefer text content or aria over a tooltip for these components MenuItem, SpinButton                                                                          | ✅  |    |    |
 | [visual-label-better-than-aria-suggestion](docs/rules/visual-label-better-than-aria-suggestion.md)                     | Visual label is better than an aria-label because sighted users can't read the aria-label text.                                                                              |    | ✅  |    |

docs/rules/tag-needs-name.md

@@ -1,4 +1,4 @@
-# This rule aims to ensure that Tag component have an accessible name via text content, aria-label, or aria-labelledby (`@microsoft/fluentui-jsx-a11y/tag-needs-name`)
+# Accessibility: Tag must have an accessible name (`@microsoft/fluentui-jsx-a11y/tag-needs-name`)
 
 💼 This rule is enabled in the ✅ `recommended` config.
 

lib/rules/index.ts

@@ -36,7 +36,7 @@ export { default as swatchpickerNeedsLabelling } from "./swatchpicker-needs-labe
 export { default as switchNeedsLabelling } from "./switch-needs-labelling";
 export { default as tablistAndTabsNeedLabelling } from "./tablist-and-tabs-need-labelling";
 export { default as tagDismissibleNeedsLabelling } from "./tag-dismissible-needs-labelling";
-export { default as tagNeedsName } from "./tag-needs-name";
+export { default as tagNeedsName } from "./tag-needs-labelling";
 export { default as toolbarMissingAria } from "./toolbar-missing-aria";
 export { default as tooltipNotRecommended } from "./tooltip-not-recommended";
 export { default as visualLabelBetterThanAriaSuggestion } from "./visual-label-better-than-aria-suggestion";

lib/rules/tag-needs-name.ts renamed to lib/rules/tag-needs-labelling.ts

@@ -13,9 +13,7 @@ const isNonEmptyString = (value: any): boolean => {
 };
 
 /**
- * Validates nested properties within a complex prop (object prop).
- * This is useful for props like dismissIcon={{ "aria-label": "close", role: "button" }}
- * where you need to check specific properties within the object.
+ * Validates if a component has a specific nested property with a non-empty string value.
  */
 export const hasValidNestedProp = (openingElement: TSESTree.JSXOpeningElement, propName: string, nestedKey: string): boolean => {
     const prop = getProp(openingElement.attributes as JSXAttribute[], propName);

lib/util/hasValidNestedProp.ts

@@ -35,10 +35,8 @@ export type LabeledControlConfig = {
     allowDescribedBy: boolean;
     allowLabeledChild: boolean; // Accept labeled child elements to provide the label e.g. <Button><img alt="..." /></Button>
     allowTextContentChild?: boolean; // Accept text children to provide the label e.g. <Button>Click me</Button>
-    /** Only apply rule when this trigger prop is present (e.g., "dismissible", "disabled") */
-    triggerProp?: string;
-    /** Custom validation function for complex scenarios */
-    customValidator?: Function;
+    triggerProp?: string; // Only apply rule when this trigger prop is present (e.g., "dismissible", "disabled")
+    customValidator?: Function; // Custom validation logic
 };
 
 /**

lib/util/ruleFactory.ts

@@ -3,7 +3,7 @@
 
 import { Rule } from "eslint";
 import ruleTester from "./helper/ruleTester";
-import rule from "../../../lib/rules/tag-needs-name";
+import rule from "../../../lib/rules/tag-needs-labelling";
 
 //------------------------------------------------------------------------------
 // Requirements