From eacec2c2fbdb6f3856da5255f3ab99e6a93dd807 Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Mon, 27 Oct 2025 13:12:49 -0700 Subject: [PATCH 1/7] Ensure that all comments are complete sentences as per guidelines Signed-off-by: Alan Jowett --- libs/execution_context/ebpf_core.c | 2 +- tests/libs/util/socket_helper.cpp | 14 +++++++------- tools/bpf2c/bpf_code_generator.cpp | 2 +- tools/netsh/resource.h | 2 +- undocked/tests/sample/ext/drv/sample_ext.c | 4 ++-- undocked/tests/sample/ext/drv/sample_ext_drv.c | 6 +++--- undocked/tests/sample/ext/inc/sample_ext_ioctls.h | 2 +- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libs/execution_context/ebpf_core.c b/libs/execution_context/ebpf_core.c index ac72b647cd..b4a40d3d37 100644 --- a/libs/execution_context/ebpf_core.c +++ b/libs/execution_context/ebpf_core.c @@ -38,7 +38,7 @@ const NPI_MODULEID ebpf_general_helper_function_module_id = { static ebpf_pinning_table_t* _ebpf_core_map_pinning_table = NULL; // Assume enabled until we can query it. -// Extern variable defined in ebpf_core_jit.h +// Extern variable defined in ebpf_core_jit.h. bool ebpf_platform_hypervisor_code_integrity_enabled = true; static bool _ebpf_platform_test_signing_enabled = true; diff --git a/tests/libs/util/socket_helper.cpp b/tests/libs/util/socket_helper.cpp index f11eacfa75..225399e6df 100644 --- a/tests/libs/util/socket_helper.cpp +++ b/tests/libs/util/socket_helper.cpp @@ -126,13 +126,13 @@ _base_socket::~_base_socket() { clean_up_socket(socket); } void _base_socket::get_local_address(_Out_ PSOCKADDR& address, _Out_ int& address_length) const { - // Query the current local address from the socket + // Query the current local address from the socket. int error = getsockname(socket, (PSOCKADDR)&local_address, &local_address_size); if (error != 0) { FAIL("Failed to query local address of socket with error: " << WSAGetLastError()); } - // Return the freshly queried address + // Return the freshly queried address. address = (PSOCKADDR)&local_address; address_length = local_address_size; } @@ -486,11 +486,11 @@ _datagram_server_socket::_datagram_server_socket( FAIL("datagram_client_socket class only supports sockets of type SOCK_DGRAM or SOCK_RAW and protocols of type " "IPPROTO_UDP, IPPROTO_IPV4 or IPPROTO_IPV6)"); - // Enable redirect context for UDP sockets + // Enable redirect context for UDP sockets. if (protocol == IPPROTO_UDP) { DWORD option_value = 1; - // Enable IPv4 redirect context only for IPv4 and Dual stack sockets + // Enable IPv4 redirect context only for IPv4 and Dual stack sockets. if (family == IPv4 || family == Dual) { int result = setsockopt( socket, @@ -503,7 +503,7 @@ _datagram_server_socket::_datagram_server_socket( } } - // Enable IPv6 redirect context only for IPv6 and Dual stack sockets + // Enable IPv6 redirect context only for IPv6 and Dual stack sockets. if (family == IPv6 || family == Dual) { int result = setsockopt( socket, @@ -533,7 +533,7 @@ _datagram_server_socket::post_async_receive() FAIL("WSACreateEvent failed with error: " << WSAGetLastError()); } - // Set up WSAMSG structure for WSARecvMsg + // Set up WSAMSG structure for WSARecvMsg. recv_msg.name = (LPSOCKADDR)&sender_address; recv_msg.namelen = sender_address_size; recv_msg.lpBuffers = &wsa_recv_buffer; @@ -541,7 +541,7 @@ _datagram_server_socket::post_async_receive() recv_msg.Control = wsa_control_buffer; recv_msg.dwFlags = 0; - // Post an asynchronous receive using WSARecvMsg to get ancillary data + // Post an asynchronous receive using WSARecvMsg to get ancillary data. error = receive_message(socket, &recv_msg, nullptr, &overlapped, nullptr); if (error != 0) { diff --git a/tools/bpf2c/bpf_code_generator.cpp b/tools/bpf2c/bpf_code_generator.cpp index 292316a0a4..4495c74212 100644 --- a/tools/bpf2c/bpf_code_generator.cpp +++ b/tools/bpf2c/bpf_code_generator.cpp @@ -522,7 +522,7 @@ bpf_code_generator::parse_btf_maps_section(const unsafe_string& name) if (map.name.empty()) { map.name = "__anonymous_" + std::to_string(++anonymous_map_count); } - // Skip the global variable maps as they are handled seperately. + // Skip the global variable maps as they are handled separately. if (map.name == ".bss" || map.name == ".data" || map.name == ".rodata") { continue; } diff --git a/tools/netsh/resource.h b/tools/netsh/resource.h index 3af04000cc..b160839308 100644 --- a/tools/netsh/resource.h +++ b/tools/netsh/resource.h @@ -36,7 +36,7 @@ #define EBPF_FILE_DESCRIPTION "eBPF for Windows Netsh Helper" #define EBPF_FILE_NAME "ebpfnetsh.dll" -// Next default values for new objects +// Next default values for new objects. // #ifdef APSTUDIO_INVOKED #ifndef APSTUDIO_READONLY_SYMBOLS diff --git a/undocked/tests/sample/ext/drv/sample_ext.c b/undocked/tests/sample/ext/drv/sample_ext.c index 0ead0d4a39..8d84f5c123 100644 --- a/undocked/tests/sample/ext/drv/sample_ext.c +++ b/undocked/tests/sample/ext/drv/sample_ext.c @@ -144,7 +144,7 @@ _sample_ebpf_extension_program_info_provider_detach_client(_In_ const void* prov static void _sample_ebpf_extension_program_info_provider_cleanup_binding_context(_Frees_ptr_ void* provider_binding_context); -// Sample eBPF extension Program Information NPI provider characteristics +// Sample eBPF extension Program Information NPI provider characteristics. const NPI_PROVIDER_CHARACTERISTICS _sample_ebpf_extension_program_info_provider_characteristics = { 0, @@ -227,7 +227,7 @@ _sample_ebpf_extension_hook_provider_detach_client(_In_ const void* provider_bin static void _sample_ebpf_extension_hook_provider_cleanup_binding_context(_Frees_ptr_ void* provider_binding_context); -// Sample eBPF extension Hook NPI provider characteristics +// Sample eBPF extension Hook NPI provider characteristics. ebpf_attach_provider_data_t _sample_ebpf_extension_attach_provider_data = { EBPF_ATTACH_PROVIDER_DATA_HEADER, EBPF_PROGRAM_TYPE_SAMPLE_GUID, BPF_ATTACH_TYPE_SAMPLE, BPF_LINK_TYPE_UNSPEC}; diff --git a/undocked/tests/sample/ext/drv/sample_ext_drv.c b/undocked/tests/sample/ext/drv/sample_ext_drv.c index 5c82efab35..b6deecb40e 100644 --- a/undocked/tests/sample/ext/drv/sample_ext_drv.c +++ b/undocked/tests/sample/ext/drv/sample_ext_drv.c @@ -22,12 +22,12 @@ #define HELPER_DATA_1 1 #define HELPER_DATA_2 2 -// Driver global variables +// Driver global variables. static DEVICE_OBJECT* _sample_ebpf_ext_driver_device_object; static BOOLEAN _sample_ebpf_ext_driver_unloading_flag = FALSE; // -// Pre-Declarations +// Pre-Declarations. // static EVT_WDF_IO_QUEUE_IO_DEVICE_CONTROL _sample_ebpf_ext_driver_io_device_control; DRIVER_INITIALIZE DriverEntry; @@ -124,7 +124,7 @@ _sample_ebpf_ext_driver_initialize_objects( status = WdfDeviceCreate(&device_initialize, WDF_NO_OBJECT_ATTRIBUTES, device); if (!NT_SUCCESS(status)) { - // do not free if any other call + // Do not free if any other call // after WdfDeviceCreate fails. WdfDeviceInitFree(device_initialize); device_initialize = NULL; diff --git a/undocked/tests/sample/ext/inc/sample_ext_ioctls.h b/undocked/tests/sample/ext/inc/sample_ext_ioctls.h index b776f82d19..d7aee8092b 100644 --- a/undocked/tests/sample/ext/inc/sample_ext_ioctls.h +++ b/undocked/tests/sample/ext/inc/sample_ext_ioctls.h @@ -16,7 +16,7 @@ #define SAMPLE_EBPF_EXT_DEVICE_WIN32_NAME L"\\\\.\\" SAMPLE_EBPF_EXT_DEVICE_BASE_NAME // -// IOCTL Codes +// IOCTL Codes. // typedef enum _sample_ebpf_ext_control_code From 28ddeacc0708a44df0b0b30023a82b573956ce61 Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Tue, 28 Oct 2025 09:57:22 -0700 Subject: [PATCH 2/7] PR feedback Signed-off-by: Alan Jowett --- tests/sample/unsafe/invalid_maps2.c | 4 +-- tests/stress/km/stress_tests_km.cpp | 22 +++++++-------- tests/unit/wer_report_test_wrapper.cpp | 8 +++--- tools/bpf2c/bpf2c.cpp | 2 +- tools/bpf2c/bpf2c_dll.c | 2 +- tools/bpf2c/bpf_code_generator.cpp | 6 ++-- tools/netsh/dllmain.c | 28 +++++++++---------- .../tests/sample/ext/drv/sample_ext_drv.c | 3 +- 8 files changed, 37 insertions(+), 38 deletions(-) diff --git a/tests/sample/unsafe/invalid_maps2.c b/tests/sample/unsafe/invalid_maps2.c index e114f40b22..e191c6d095 100644 --- a/tests/sample/unsafe/invalid_maps2.c +++ b/tests/sample/unsafe/invalid_maps2.c @@ -149,7 +149,7 @@ BindMonitor(bind_md_t* ctx) uint32_t* dummy_value = bpf_map_lookup_elem(&dummy_map, &dummy_key); if (!dummy_value) { - // Callee0 is at index 0 + // Callee0 is at index 0. int index = 0; bpf_tail_call(ctx, &prog_array_map, index); } @@ -165,7 +165,7 @@ BindMonitor_Callee0(bind_md_t* ctx) uint32_t* dummy_value = bpf_map_lookup_elem(&dummy_map, &dummy_key); if (!dummy_value) { - // Callee1 is at index 1 + // Callee1 is at index 1. int index = 1; bpf_tail_call(ctx, &prog_array_map, index); } diff --git a/tests/stress/km/stress_tests_km.cpp b/tests/stress/km/stress_tests_km.cpp index df589f240a..8543c32a13 100644 --- a/tests/stress/km/stress_tests_km.cpp +++ b/tests/stress/km/stress_tests_km.cpp @@ -30,9 +30,9 @@ static const std::map _test_program_info = struct object_table_entry { std::unique_ptr lock{nullptr}; - _Guarded_by_(lock) bool available{true}; - _Guarded_by_(lock) bpf_object_ptr object{nullptr}; - _Guarded_by_(lock) bool loaded{false}; + _Guarded_by_(lock) bool available { true }; + _Guarded_by_(lock) bpf_object_ptr object { nullptr }; + _Guarded_by_(lock) bool loaded { false }; bool attach{false}; // The following fields are for debugging this test itself. @@ -353,7 +353,7 @@ _do_creator_work(thread_context& context, std::time_t endtime_seconds) // to force a race between 'load', 'attach' and 'destroy'. std::lock_guard lock(*entry.lock.get()); - // Make sure entry is _still_ free (some other creator thread may have grabbed it) + // Make sure entry is _still_ free (some other creator thread may have grabbed it). if (!entry.available) { continue; } @@ -747,13 +747,13 @@ wait_and_verify_test_threads( std::vector& extension_restart_thread_table, std::vector& extension_restart_thread_context_table) { - // Wait for all test threads + // Wait for all test threads. LOG_VERBOSE("waiting on {} test threads...", thread_table.size()); for (auto& t : thread_table) { t.join(); } - // Wait for all extension restart threads + // Wait for all extension restart threads. if (test_control_info.extension_restart_enabled) { LOG_VERBOSE("waiting on {} extension restart threads...", extension_restart_thread_table.size()); for (auto& t : extension_restart_thread_table) { @@ -835,7 +835,7 @@ _mt_prog_load_stress_test(ebpf_execution_type_t program_type, const test_control context_entry.file_name = _make_unique_file_copy(program_attribs.native_file_name); } else { - // Use the same file name for all 'creator' threads + // Use the same file name for all 'creator' threads. context_entry.file_name = program_attribs.native_file_name; } } else { @@ -1042,7 +1042,7 @@ _invoke_test_thread_function(thread_context& context) exit(-1); } - // Set the timeout for connect attempts + // Set the timeout for connect attempts. timeval timeout; timeout.tv_sec = 5; // 5 seconds timeout.tv_usec = 0; @@ -1974,7 +1974,7 @@ _mt_load_stress_test_with_restart_timing( if (test_control_info.extension_restart_enabled && !start_restart_before_load) { // Wait for programs to load, then start extension restart. LOG_INFO("Waiting for programs to load, then starting extension restart"); - std::this_thread::sleep_for(std::chrono::seconds(5)); // Give programs time to load and attach + std::this_thread::sleep_for(std::chrono::seconds(5)); // Give programs time to load and attach. configure_extension_restart( test_control_info, extension_names, @@ -2032,9 +2032,9 @@ _mt_invoke_stress_test_multiple_programs(ebpf_execution_type_t program_type, con } context_entry.program_name = "cgroup_sock_addr"; - context_entry.role = thread_role_type::CREATOR; // All threads are creators for this test + context_entry.role = thread_role_type::CREATOR; // All threads are creators for this test. context_entry.thread_index = i; - context_entry.compartment_id = i + 1; // Unique compartment IDs + context_entry.compartment_id = i + 1; // Unique compartment IDs. context_entry.duration_minutes = test_control_info.duration_minutes; context_entry.extension_restart_enabled = test_control_info.extension_restart_enabled; } diff --git a/tests/unit/wer_report_test_wrapper.cpp b/tests/unit/wer_report_test_wrapper.cpp index dba5c7c023..eeb3a14962 100644 --- a/tests/unit/wer_report_test_wrapper.cpp +++ b/tests/unit/wer_report_test_wrapper.cpp @@ -45,7 +45,7 @@ AddVectoredExceptionHandler_test(_In_ unsigned long first, _In_ PVECTORED_EXCEPT unsigned long SetThreadStackGuarantee_test_stack_size_in_bytes = 0; // Use BOOL to pass "SetThreadStackGuarantee" -// defined in windows "processthreadapi.h" file +// defined in windows "processthreadapi.h" file. BOOL SetThreadStackGuarantee_test(_Inout_ unsigned long* stack_size_in_bytes) { @@ -209,7 +209,7 @@ TEST_CASE("wer_report_failure", "[wer_report]") WerReportAddDump_test_called = false; WerReportSubmit_test_called = false; - // Fail WerReportCreate + // Fail WerReportCreate. REQUIRE(AddVectoredExceptionHandler_test_handler(&exception_pointers) == EXCEPTION_CONTINUE_SEARCH); REQUIRE(WerReportCreate_test_called); REQUIRE(!WerReportAddDump_test_called); @@ -222,7 +222,7 @@ TEST_CASE("wer_report_failure", "[wer_report]") WerReportAddDump_test_called = false; WerReportSubmit_test_called = false; - // Fail WerReportAddDump + // Fail WerReportAddDump. REQUIRE(AddVectoredExceptionHandler_test_handler(&exception_pointers) == EXCEPTION_CONTINUE_SEARCH); REQUIRE(WerReportCreate_test_called); REQUIRE(WerReportAddDump_test_called); @@ -235,7 +235,7 @@ TEST_CASE("wer_report_failure", "[wer_report]") WerReportAddDump_test_called = false; WerReportSubmit_test_called = false; - // Fail WerReportSubmit + // Fail WerReportSubmit. REQUIRE(AddVectoredExceptionHandler_test_handler(&exception_pointers) == EXCEPTION_CONTINUE_SEARCH); REQUIRE(WerReportCreate_test_called); REQUIRE(WerReportAddDump_test_called); diff --git a/tools/bpf2c/bpf2c.cpp b/tools/bpf2c/bpf2c.cpp index 84731278d8..10e061996c 100644 --- a/tools/bpf2c/bpf2c.cpp +++ b/tools/bpf2c/bpf2c.cpp @@ -104,7 +104,7 @@ get_program_info_type_hash(const std::vector& actual_helper_ids, const helper_id_ordering[helper_id] = index; } } - // Hash helper ids in increasing helper_id order + // Hash helper ids in increasing helper_id order. for (auto [helper_id, index] : helper_id_ordering) { hash_t::append_byte_range( byte_range, program_info->program_type_specific_helper_prototype[index].helper_id); diff --git a/tools/bpf2c/bpf2c_dll.c b/tools/bpf2c/bpf2c_dll.c index c9d263ee45..0d6b57cd85 100644 --- a/tools/bpf2c/bpf2c_dll.c +++ b/tools/bpf2c/bpf2c_dll.c @@ -4,7 +4,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table ___METADATA_TABLE___##_metadata_table diff --git a/tools/bpf2c/bpf_code_generator.cpp b/tools/bpf2c/bpf_code_generator.cpp index 4495c74212..cde539d749 100644 --- a/tools/bpf2c/bpf_code_generator.cpp +++ b/tools/bpf2c/bpf_code_generator.cpp @@ -120,7 +120,7 @@ static const std::string _predicate_format_string[] = { #define ADD_OPCODE(X) {static_cast(X), std::string(#X)} -// remove EBPF_ATOMIC_ prefix +// Remove EBPF_ATOMIC_ prefix. #define ADD_ATOMIC_OPCODE(X) {static_cast(X), std::string(#X).substr(12)} static std::map _atomic_opcode_name_strings = { @@ -478,7 +478,7 @@ bpf_code_generator::visit_symbols(symbol_visitor_t visitor, const unsafe_string& throw bpf_code_generator_exception("invalid symbol value"); } - // Check for overflow of value + size + // Check for overflow of value + size. if ((value + size) < value) { throw bpf_code_generator_exception("invalid symbol value"); } @@ -1076,7 +1076,7 @@ bpf_code_generator::bpf_code_generator_program::encode_instructions( auto effective_program_name = !program_name.empty() ? program_name : elf_section_name; auto helper_array_prefix = "runtime_context->helper_data[{}]"; - // Encode instructions + // Encode instructions. for (size_t i = 0; i < program_output.size(); i++) { auto& output = program_output[i]; auto& inst = output.instruction; diff --git a/tools/netsh/dllmain.c b/tools/netsh/dllmain.c index d7d72bcb17..322ae2ba80 100644 --- a/tools/netsh/dllmain.c +++ b/tools/netsh/dllmain.c @@ -32,7 +32,7 @@ DllMain(HMODULE moduleHandle, unsigned long reasonForCall, void* reserved) return TRUE; } -// Verbs +// Verbs. #define CMD_GROUP_ADD L"add" #define CMD_GROUP_DELETE L"delete" #define CMD_GROUP_PIN L"pin" @@ -40,7 +40,7 @@ DllMain(HMODULE moduleHandle, unsigned long reasonForCall, void* reserved) #define CMD_GROUP_SHOW L"show" #define CMD_GROUP_UNPIN L"unpin" -// Nouns +// Nouns. #define CMD_EBPF_SHOW_DISASSEMBLY L"disassembly" #define CMD_EBPF_SHOW_LINKS L"links" #define CMD_EBPF_SHOW_MAPS L"maps" @@ -87,25 +87,25 @@ CMD_ENTRY g_EbpfShowCommandTable[] = { #else typedef struct _CMD_ENTRY_ORIGINAL { - _Field_z_ const wchar_t* pwszCmdToken; // The token for the command - PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command - unsigned long dwShortCmdHelpToken; // The short help message + _Field_z_ const wchar_t* pwszCmdToken; // The token for the command. + PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command. + unsigned long dwShortCmdHelpToken; // The short help message. unsigned long - dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?) - unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above) - PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against + dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?). + unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above). + PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against. } CMD_ENTRY_ORIGINAL, *PCMD_ENTRY_ORIGINAL; #define CREATE_CMD_ENTRY_ORIGINAL(t, f) {CMD_##t, f, HLP_##t, HLP_##t##_EX, CMD_FLAG_PRIVATE, NULL} typedef struct _CMD_ENTRY_LONG { - _Field_z_ const wchar_t* pwszCmdToken; // The token for the command - PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command - unsigned long dwShortCmdHelpToken; // The short help message + _Field_z_ const wchar_t* pwszCmdToken; // The token for the command. + PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command. + unsigned long dwShortCmdHelpToken; // The short help message. unsigned long - dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?) - unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above) - PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against + dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?). + unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above). + PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against. void* pfnCustomHelpFn; } CMD_ENTRY_LONG, *PCMD_ENTRY_LONG; #define CREATE_CMD_ENTRY_LONG(t, f) {CMD_##t, f, HLP_##t, HLP_##t##_EX, CMD_FLAG_PRIVATE, NULL, NULL} diff --git a/undocked/tests/sample/ext/drv/sample_ext_drv.c b/undocked/tests/sample/ext/drv/sample_ext_drv.c index b6deecb40e..6fe3ba58db 100644 --- a/undocked/tests/sample/ext/drv/sample_ext_drv.c +++ b/undocked/tests/sample/ext/drv/sample_ext_drv.c @@ -124,8 +124,7 @@ _sample_ebpf_ext_driver_initialize_objects( status = WdfDeviceCreate(&device_initialize, WDF_NO_OBJECT_ATTRIBUTES, device); if (!NT_SUCCESS(status)) { - // Do not free if any other call - // after WdfDeviceCreate fails. + // Do not free if any other call after WdfDeviceCreate fails. WdfDeviceInitFree(device_initialize); device_initialize = NULL; goto Exit; From db022fb2d49739be16b565eb1eb0d40da030daf5 Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Tue, 28 Oct 2025 14:33:44 -0700 Subject: [PATCH 3/7] Update expected output Signed-off-by: Alan Jowett --- tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c | 2 +- tests/bpf2c_tests/expected/bad_map_name_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c | 2 +- tests/bpf2c_tests/expected/bpf_call_dll.c | 2 +- tests/bpf2c_tests/expected/bpf_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c | 2 +- tests/bpf2c_tests/expected/divide_by_zero_dll.c | 2 +- tests/bpf2c_tests/expected/global_vars_and_map_dll.c | 2 +- tests/bpf2c_tests/expected/global_vars_dll.c | 2 +- tests/bpf2c_tests/expected/hash_of_map_dll.c | 2 +- tests/bpf2c_tests/expected/inner_map_dll.c | 2 +- tests/bpf2c_tests/expected/map_dll.c | 2 +- tests/bpf2c_tests/expected/map_in_map_btf_dll.c | 2 +- tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c | 2 +- tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c | 2 +- tests/bpf2c_tests/expected/map_reuse_2_dll.c | 2 +- tests/bpf2c_tests/expected/map_reuse_dll.c | 2 +- tests/bpf2c_tests/expected/map_synchronized_update_dll.c | 2 +- tests/bpf2c_tests/expected/multiple_programs_dll.c | 2 +- tests/bpf2c_tests/expected/pidtgid_dll.c | 2 +- tests/bpf2c_tests/expected/printk_dll.c | 2 +- tests/bpf2c_tests/expected/printk_legacy_dll.c | 2 +- tests/bpf2c_tests/expected/process_start_key_dll.c | 2 +- tests/bpf2c_tests/expected/sockops_dll.c | 2 +- tests/bpf2c_tests/expected/strings_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_bad_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_map_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_multiple_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_recursive_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_same_section_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_sequential_dll.c | 2 +- tests/bpf2c_tests/expected/test_sample_ebpf_dll.c | 2 +- tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c | 2 +- .../expected/test_sample_invalid_socket_cookie_dll.c | 2 +- tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c | 2 +- tests/bpf2c_tests/expected/test_utility_helpers_dll.c | 2 +- tests/bpf2c_tests/expected/thread_start_time_dll.c | 2 +- tests/bpf2c_tests/expected/utility_dll.c | 2 +- 50 files changed, 50 insertions(+), 50 deletions(-) diff --git a/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c b/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c index 25f39520d8..0bd0dbe885 100644 --- a/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c +++ b/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table atomic_instruction_fetch_add##_metadata_table diff --git a/tests/bpf2c_tests/expected/bad_map_name_dll.c b/tests/bpf2c_tests/expected/bad_map_name_dll.c index dfc404cae5..4ecb32e91d 100644 --- a/tests/bpf2c_tests/expected/bad_map_name_dll.c +++ b/tests/bpf2c_tests/expected/bad_map_name_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bad_map_name##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c b/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c index 2d28a4f419..21386939a4 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_bpf2bpf##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_dll.c b/tests/bpf2c_tests/expected/bindmonitor_dll.c index 2cfb2d172b..3e716a4c6a 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c b/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c index dab0de4254..054a582e43 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_mt_tailcall##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c b/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c index 365ca637f5..eb9fb612c1 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_perf_event_array##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c b/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c index 57e2e59904..6674e7bbc9 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_ringbuf##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c b/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c index 629fcb3421..e50a61eac6 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_tailcall##_metadata_table diff --git a/tests/bpf2c_tests/expected/bpf_call_dll.c b/tests/bpf2c_tests/expected/bpf_call_dll.c index c848b2868f..60dc96b608 100644 --- a/tests/bpf2c_tests/expected/bpf_call_dll.c +++ b/tests/bpf2c_tests/expected/bpf_call_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bpf_call##_metadata_table diff --git a/tests/bpf2c_tests/expected/bpf_dll.c b/tests/bpf2c_tests/expected/bpf_dll.c index 95e7ec8733..c103abe742 100644 --- a/tests/bpf2c_tests/expected/bpf_dll.c +++ b/tests/bpf2c_tests/expected/bpf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bpf##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c b/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c index 38f8a5b014..a4c8f98714 100644 --- a/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_count_connect4##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c b/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c index d0c9316987..f85b9530e9 100644 --- a/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_count_connect6##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c b/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c index 67bb8bc938..d51ca77b4b 100644 --- a/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_mt_connect4##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c b/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c index 4f0ba28763..d6f8628e13 100644 --- a/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_mt_connect6##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c b/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c index 52d8eaf135..b90417a58f 100644 --- a/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_sock_addr2##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c b/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c index 3bbb23383b..c26a75f69b 100644 --- a/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_sock_addr##_metadata_table diff --git a/tests/bpf2c_tests/expected/divide_by_zero_dll.c b/tests/bpf2c_tests/expected/divide_by_zero_dll.c index 79a04a1e92..22877299f8 100644 --- a/tests/bpf2c_tests/expected/divide_by_zero_dll.c +++ b/tests/bpf2c_tests/expected/divide_by_zero_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table divide_by_zero##_metadata_table diff --git a/tests/bpf2c_tests/expected/global_vars_and_map_dll.c b/tests/bpf2c_tests/expected/global_vars_and_map_dll.c index a4fc7e904b..6ca56d6419 100644 --- a/tests/bpf2c_tests/expected/global_vars_and_map_dll.c +++ b/tests/bpf2c_tests/expected/global_vars_and_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table global_vars_and_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/global_vars_dll.c b/tests/bpf2c_tests/expected/global_vars_dll.c index 499ecd0075..dc58b79c11 100644 --- a/tests/bpf2c_tests/expected/global_vars_dll.c +++ b/tests/bpf2c_tests/expected/global_vars_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table global_vars##_metadata_table diff --git a/tests/bpf2c_tests/expected/hash_of_map_dll.c b/tests/bpf2c_tests/expected/hash_of_map_dll.c index 12407559ed..24c2f30f71 100644 --- a/tests/bpf2c_tests/expected/hash_of_map_dll.c +++ b/tests/bpf2c_tests/expected/hash_of_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table hash_of_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/inner_map_dll.c b/tests/bpf2c_tests/expected/inner_map_dll.c index 408493f42f..5da19ae227 100644 --- a/tests/bpf2c_tests/expected/inner_map_dll.c +++ b/tests/bpf2c_tests/expected/inner_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table inner_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_dll.c b/tests/bpf2c_tests/expected/map_dll.c index 075fd9497e..db1f482cb5 100644 --- a/tests/bpf2c_tests/expected/map_dll.c +++ b/tests/bpf2c_tests/expected/map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_in_map_btf_dll.c b/tests/bpf2c_tests/expected/map_in_map_btf_dll.c index 5784fbc7f4..87b5a9eaaa 100644 --- a/tests/bpf2c_tests/expected/map_in_map_btf_dll.c +++ b/tests/bpf2c_tests/expected/map_in_map_btf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_in_map_btf##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c b/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c index e7b3522799..4fd6654ce3 100644 --- a/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c +++ b/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_in_map_legacy_id##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c b/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c index aa516d2079..2fbdc6198a 100644 --- a/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c +++ b/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_in_map_legacy_idx##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_reuse_2_dll.c b/tests/bpf2c_tests/expected/map_reuse_2_dll.c index d4f14ac7f1..3920bda8db 100644 --- a/tests/bpf2c_tests/expected/map_reuse_2_dll.c +++ b/tests/bpf2c_tests/expected/map_reuse_2_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_reuse_2##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_reuse_dll.c b/tests/bpf2c_tests/expected/map_reuse_dll.c index 62dc4a451f..69370cf363 100644 --- a/tests/bpf2c_tests/expected/map_reuse_dll.c +++ b/tests/bpf2c_tests/expected/map_reuse_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_reuse##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_synchronized_update_dll.c b/tests/bpf2c_tests/expected/map_synchronized_update_dll.c index adf449ad8c..dc10ab4fde 100644 --- a/tests/bpf2c_tests/expected/map_synchronized_update_dll.c +++ b/tests/bpf2c_tests/expected/map_synchronized_update_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_synchronized_update##_metadata_table diff --git a/tests/bpf2c_tests/expected/multiple_programs_dll.c b/tests/bpf2c_tests/expected/multiple_programs_dll.c index 31a83f0b28..be1347f1ed 100644 --- a/tests/bpf2c_tests/expected/multiple_programs_dll.c +++ b/tests/bpf2c_tests/expected/multiple_programs_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table multiple_programs##_metadata_table diff --git a/tests/bpf2c_tests/expected/pidtgid_dll.c b/tests/bpf2c_tests/expected/pidtgid_dll.c index c322cf921b..591c65a57d 100644 --- a/tests/bpf2c_tests/expected/pidtgid_dll.c +++ b/tests/bpf2c_tests/expected/pidtgid_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table pidtgid##_metadata_table diff --git a/tests/bpf2c_tests/expected/printk_dll.c b/tests/bpf2c_tests/expected/printk_dll.c index 5b885bd4c3..8fc90f2edd 100644 --- a/tests/bpf2c_tests/expected/printk_dll.c +++ b/tests/bpf2c_tests/expected/printk_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table printk##_metadata_table diff --git a/tests/bpf2c_tests/expected/printk_legacy_dll.c b/tests/bpf2c_tests/expected/printk_legacy_dll.c index 0e3722b4b9..b3106dff83 100644 --- a/tests/bpf2c_tests/expected/printk_legacy_dll.c +++ b/tests/bpf2c_tests/expected/printk_legacy_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table printk_legacy##_metadata_table diff --git a/tests/bpf2c_tests/expected/process_start_key_dll.c b/tests/bpf2c_tests/expected/process_start_key_dll.c index 2335d28ed2..5847b68057 100644 --- a/tests/bpf2c_tests/expected/process_start_key_dll.c +++ b/tests/bpf2c_tests/expected/process_start_key_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table process_start_key##_metadata_table diff --git a/tests/bpf2c_tests/expected/sockops_dll.c b/tests/bpf2c_tests/expected/sockops_dll.c index 165fbf1e30..f95b4cd2d4 100644 --- a/tests/bpf2c_tests/expected/sockops_dll.c +++ b/tests/bpf2c_tests/expected/sockops_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table sockops##_metadata_table diff --git a/tests/bpf2c_tests/expected/strings_dll.c b/tests/bpf2c_tests/expected/strings_dll.c index e0a188c841..ecef5e7580 100644 --- a/tests/bpf2c_tests/expected/strings_dll.c +++ b/tests/bpf2c_tests/expected/strings_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table strings##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_bad_dll.c b/tests/bpf2c_tests/expected/tail_call_bad_dll.c index 8a535dcbd3..e74e072660 100644 --- a/tests/bpf2c_tests/expected/tail_call_bad_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_bad_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_bad##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_dll.c b/tests/bpf2c_tests/expected/tail_call_dll.c index 69f69b47bb..91ebfb95dd 100644 --- a/tests/bpf2c_tests/expected/tail_call_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_map_dll.c b/tests/bpf2c_tests/expected/tail_call_map_dll.c index e96a445bf5..4b6efc2bab 100644 --- a/tests/bpf2c_tests/expected/tail_call_map_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c b/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c index 9f81b23f0d..0b87db4735 100644 --- a/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_max_exceed##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_multiple_dll.c b/tests/bpf2c_tests/expected/tail_call_multiple_dll.c index 6a4f2d1498..30a3837dbe 100644 --- a/tests/bpf2c_tests/expected/tail_call_multiple_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_multiple_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_multiple##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_recursive_dll.c b/tests/bpf2c_tests/expected/tail_call_recursive_dll.c index e6ae6ac96f..3c7ba94777 100644 --- a/tests/bpf2c_tests/expected/tail_call_recursive_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_recursive_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_recursive##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_same_section_dll.c b/tests/bpf2c_tests/expected/tail_call_same_section_dll.c index e3ead29fc8..3fd25b407f 100644 --- a/tests/bpf2c_tests/expected/tail_call_same_section_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_same_section_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_same_section##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_sequential_dll.c b/tests/bpf2c_tests/expected/tail_call_sequential_dll.c index aedd922bcf..e6db4824b7 100644 --- a/tests/bpf2c_tests/expected/tail_call_sequential_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_sequential_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_sequential##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c b/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c index f3d7b6d059..417e3593cb 100644 --- a/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_ebpf##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c b/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c index f3c4bf7911..12081ae94f 100644 --- a/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_implicit_helpers##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c b/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c index 277297adad..97ad845221 100644 --- a/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_invalid_socket_cookie##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c b/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c index 7e79b8f090..0d790cf4a2 100644 --- a/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_perf_event_array##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_utility_helpers_dll.c b/tests/bpf2c_tests/expected/test_utility_helpers_dll.c index f801cacf44..72a6a9a2d4 100644 --- a/tests/bpf2c_tests/expected/test_utility_helpers_dll.c +++ b/tests/bpf2c_tests/expected/test_utility_helpers_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_utility_helpers##_metadata_table diff --git a/tests/bpf2c_tests/expected/thread_start_time_dll.c b/tests/bpf2c_tests/expected/thread_start_time_dll.c index 859a293d85..8a8cd09005 100644 --- a/tests/bpf2c_tests/expected/thread_start_time_dll.c +++ b/tests/bpf2c_tests/expected/thread_start_time_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table thread_start_time##_metadata_table diff --git a/tests/bpf2c_tests/expected/utility_dll.c b/tests/bpf2c_tests/expected/utility_dll.c index 7aff836900..538dc53689 100644 --- a/tests/bpf2c_tests/expected/utility_dll.c +++ b/tests/bpf2c_tests/expected/utility_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table utility##_metadata_table From d14ca7cb0416a854f1aa9c98cacad0f78bb0e553 Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Mon, 27 Oct 2025 13:12:49 -0700 Subject: [PATCH 4/7] Ensure that all comments are complete sentences as per guidelines Signed-off-by: Alan Jowett --- libs/execution_context/ebpf_core.c | 2 +- tests/libs/util/socket_helper.cpp | 14 +++++++------- tools/bpf2c/bpf_code_generator.cpp | 2 +- tools/netsh/resource.h | 2 +- undocked/tests/sample/ext/drv/sample_ext.c | 4 ++-- undocked/tests/sample/ext/drv/sample_ext_drv.c | 6 +++--- undocked/tests/sample/ext/inc/sample_ext_ioctls.h | 2 +- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libs/execution_context/ebpf_core.c b/libs/execution_context/ebpf_core.c index ac72b647cd..b4a40d3d37 100644 --- a/libs/execution_context/ebpf_core.c +++ b/libs/execution_context/ebpf_core.c @@ -38,7 +38,7 @@ const NPI_MODULEID ebpf_general_helper_function_module_id = { static ebpf_pinning_table_t* _ebpf_core_map_pinning_table = NULL; // Assume enabled until we can query it. -// Extern variable defined in ebpf_core_jit.h +// Extern variable defined in ebpf_core_jit.h. bool ebpf_platform_hypervisor_code_integrity_enabled = true; static bool _ebpf_platform_test_signing_enabled = true; diff --git a/tests/libs/util/socket_helper.cpp b/tests/libs/util/socket_helper.cpp index f11eacfa75..225399e6df 100644 --- a/tests/libs/util/socket_helper.cpp +++ b/tests/libs/util/socket_helper.cpp @@ -126,13 +126,13 @@ _base_socket::~_base_socket() { clean_up_socket(socket); } void _base_socket::get_local_address(_Out_ PSOCKADDR& address, _Out_ int& address_length) const { - // Query the current local address from the socket + // Query the current local address from the socket. int error = getsockname(socket, (PSOCKADDR)&local_address, &local_address_size); if (error != 0) { FAIL("Failed to query local address of socket with error: " << WSAGetLastError()); } - // Return the freshly queried address + // Return the freshly queried address. address = (PSOCKADDR)&local_address; address_length = local_address_size; } @@ -486,11 +486,11 @@ _datagram_server_socket::_datagram_server_socket( FAIL("datagram_client_socket class only supports sockets of type SOCK_DGRAM or SOCK_RAW and protocols of type " "IPPROTO_UDP, IPPROTO_IPV4 or IPPROTO_IPV6)"); - // Enable redirect context for UDP sockets + // Enable redirect context for UDP sockets. if (protocol == IPPROTO_UDP) { DWORD option_value = 1; - // Enable IPv4 redirect context only for IPv4 and Dual stack sockets + // Enable IPv4 redirect context only for IPv4 and Dual stack sockets. if (family == IPv4 || family == Dual) { int result = setsockopt( socket, @@ -503,7 +503,7 @@ _datagram_server_socket::_datagram_server_socket( } } - // Enable IPv6 redirect context only for IPv6 and Dual stack sockets + // Enable IPv6 redirect context only for IPv6 and Dual stack sockets. if (family == IPv6 || family == Dual) { int result = setsockopt( socket, @@ -533,7 +533,7 @@ _datagram_server_socket::post_async_receive() FAIL("WSACreateEvent failed with error: " << WSAGetLastError()); } - // Set up WSAMSG structure for WSARecvMsg + // Set up WSAMSG structure for WSARecvMsg. recv_msg.name = (LPSOCKADDR)&sender_address; recv_msg.namelen = sender_address_size; recv_msg.lpBuffers = &wsa_recv_buffer; @@ -541,7 +541,7 @@ _datagram_server_socket::post_async_receive() recv_msg.Control = wsa_control_buffer; recv_msg.dwFlags = 0; - // Post an asynchronous receive using WSARecvMsg to get ancillary data + // Post an asynchronous receive using WSARecvMsg to get ancillary data. error = receive_message(socket, &recv_msg, nullptr, &overlapped, nullptr); if (error != 0) { diff --git a/tools/bpf2c/bpf_code_generator.cpp b/tools/bpf2c/bpf_code_generator.cpp index 292316a0a4..4495c74212 100644 --- a/tools/bpf2c/bpf_code_generator.cpp +++ b/tools/bpf2c/bpf_code_generator.cpp @@ -522,7 +522,7 @@ bpf_code_generator::parse_btf_maps_section(const unsafe_string& name) if (map.name.empty()) { map.name = "__anonymous_" + std::to_string(++anonymous_map_count); } - // Skip the global variable maps as they are handled seperately. + // Skip the global variable maps as they are handled separately. if (map.name == ".bss" || map.name == ".data" || map.name == ".rodata") { continue; } diff --git a/tools/netsh/resource.h b/tools/netsh/resource.h index 3af04000cc..b160839308 100644 --- a/tools/netsh/resource.h +++ b/tools/netsh/resource.h @@ -36,7 +36,7 @@ #define EBPF_FILE_DESCRIPTION "eBPF for Windows Netsh Helper" #define EBPF_FILE_NAME "ebpfnetsh.dll" -// Next default values for new objects +// Next default values for new objects. // #ifdef APSTUDIO_INVOKED #ifndef APSTUDIO_READONLY_SYMBOLS diff --git a/undocked/tests/sample/ext/drv/sample_ext.c b/undocked/tests/sample/ext/drv/sample_ext.c index 0ead0d4a39..8d84f5c123 100644 --- a/undocked/tests/sample/ext/drv/sample_ext.c +++ b/undocked/tests/sample/ext/drv/sample_ext.c @@ -144,7 +144,7 @@ _sample_ebpf_extension_program_info_provider_detach_client(_In_ const void* prov static void _sample_ebpf_extension_program_info_provider_cleanup_binding_context(_Frees_ptr_ void* provider_binding_context); -// Sample eBPF extension Program Information NPI provider characteristics +// Sample eBPF extension Program Information NPI provider characteristics. const NPI_PROVIDER_CHARACTERISTICS _sample_ebpf_extension_program_info_provider_characteristics = { 0, @@ -227,7 +227,7 @@ _sample_ebpf_extension_hook_provider_detach_client(_In_ const void* provider_bin static void _sample_ebpf_extension_hook_provider_cleanup_binding_context(_Frees_ptr_ void* provider_binding_context); -// Sample eBPF extension Hook NPI provider characteristics +// Sample eBPF extension Hook NPI provider characteristics. ebpf_attach_provider_data_t _sample_ebpf_extension_attach_provider_data = { EBPF_ATTACH_PROVIDER_DATA_HEADER, EBPF_PROGRAM_TYPE_SAMPLE_GUID, BPF_ATTACH_TYPE_SAMPLE, BPF_LINK_TYPE_UNSPEC}; diff --git a/undocked/tests/sample/ext/drv/sample_ext_drv.c b/undocked/tests/sample/ext/drv/sample_ext_drv.c index 5c82efab35..b6deecb40e 100644 --- a/undocked/tests/sample/ext/drv/sample_ext_drv.c +++ b/undocked/tests/sample/ext/drv/sample_ext_drv.c @@ -22,12 +22,12 @@ #define HELPER_DATA_1 1 #define HELPER_DATA_2 2 -// Driver global variables +// Driver global variables. static DEVICE_OBJECT* _sample_ebpf_ext_driver_device_object; static BOOLEAN _sample_ebpf_ext_driver_unloading_flag = FALSE; // -// Pre-Declarations +// Pre-Declarations. // static EVT_WDF_IO_QUEUE_IO_DEVICE_CONTROL _sample_ebpf_ext_driver_io_device_control; DRIVER_INITIALIZE DriverEntry; @@ -124,7 +124,7 @@ _sample_ebpf_ext_driver_initialize_objects( status = WdfDeviceCreate(&device_initialize, WDF_NO_OBJECT_ATTRIBUTES, device); if (!NT_SUCCESS(status)) { - // do not free if any other call + // Do not free if any other call // after WdfDeviceCreate fails. WdfDeviceInitFree(device_initialize); device_initialize = NULL; diff --git a/undocked/tests/sample/ext/inc/sample_ext_ioctls.h b/undocked/tests/sample/ext/inc/sample_ext_ioctls.h index b776f82d19..d7aee8092b 100644 --- a/undocked/tests/sample/ext/inc/sample_ext_ioctls.h +++ b/undocked/tests/sample/ext/inc/sample_ext_ioctls.h @@ -16,7 +16,7 @@ #define SAMPLE_EBPF_EXT_DEVICE_WIN32_NAME L"\\\\.\\" SAMPLE_EBPF_EXT_DEVICE_BASE_NAME // -// IOCTL Codes +// IOCTL Codes. // typedef enum _sample_ebpf_ext_control_code From 001ded3eb7d5a37f2960b72c4fed1bdd93f38162 Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Tue, 28 Oct 2025 09:57:22 -0700 Subject: [PATCH 5/7] PR feedback Signed-off-by: Alan Jowett --- tests/sample/unsafe/invalid_maps2.c | 4 +-- tests/stress/km/stress_tests_km.cpp | 22 +++++++-------- tests/unit/wer_report_test_wrapper.cpp | 8 +++--- tools/bpf2c/bpf2c.cpp | 2 +- tools/bpf2c/bpf2c_dll.c | 2 +- tools/bpf2c/bpf_code_generator.cpp | 6 ++-- tools/netsh/dllmain.c | 28 +++++++++---------- .../tests/sample/ext/drv/sample_ext_drv.c | 3 +- 8 files changed, 37 insertions(+), 38 deletions(-) diff --git a/tests/sample/unsafe/invalid_maps2.c b/tests/sample/unsafe/invalid_maps2.c index e114f40b22..e191c6d095 100644 --- a/tests/sample/unsafe/invalid_maps2.c +++ b/tests/sample/unsafe/invalid_maps2.c @@ -149,7 +149,7 @@ BindMonitor(bind_md_t* ctx) uint32_t* dummy_value = bpf_map_lookup_elem(&dummy_map, &dummy_key); if (!dummy_value) { - // Callee0 is at index 0 + // Callee0 is at index 0. int index = 0; bpf_tail_call(ctx, &prog_array_map, index); } @@ -165,7 +165,7 @@ BindMonitor_Callee0(bind_md_t* ctx) uint32_t* dummy_value = bpf_map_lookup_elem(&dummy_map, &dummy_key); if (!dummy_value) { - // Callee1 is at index 1 + // Callee1 is at index 1. int index = 1; bpf_tail_call(ctx, &prog_array_map, index); } diff --git a/tests/stress/km/stress_tests_km.cpp b/tests/stress/km/stress_tests_km.cpp index df589f240a..8543c32a13 100644 --- a/tests/stress/km/stress_tests_km.cpp +++ b/tests/stress/km/stress_tests_km.cpp @@ -30,9 +30,9 @@ static const std::map _test_program_info = struct object_table_entry { std::unique_ptr lock{nullptr}; - _Guarded_by_(lock) bool available{true}; - _Guarded_by_(lock) bpf_object_ptr object{nullptr}; - _Guarded_by_(lock) bool loaded{false}; + _Guarded_by_(lock) bool available { true }; + _Guarded_by_(lock) bpf_object_ptr object { nullptr }; + _Guarded_by_(lock) bool loaded { false }; bool attach{false}; // The following fields are for debugging this test itself. @@ -353,7 +353,7 @@ _do_creator_work(thread_context& context, std::time_t endtime_seconds) // to force a race between 'load', 'attach' and 'destroy'. std::lock_guard lock(*entry.lock.get()); - // Make sure entry is _still_ free (some other creator thread may have grabbed it) + // Make sure entry is _still_ free (some other creator thread may have grabbed it). if (!entry.available) { continue; } @@ -747,13 +747,13 @@ wait_and_verify_test_threads( std::vector& extension_restart_thread_table, std::vector& extension_restart_thread_context_table) { - // Wait for all test threads + // Wait for all test threads. LOG_VERBOSE("waiting on {} test threads...", thread_table.size()); for (auto& t : thread_table) { t.join(); } - // Wait for all extension restart threads + // Wait for all extension restart threads. if (test_control_info.extension_restart_enabled) { LOG_VERBOSE("waiting on {} extension restart threads...", extension_restart_thread_table.size()); for (auto& t : extension_restart_thread_table) { @@ -835,7 +835,7 @@ _mt_prog_load_stress_test(ebpf_execution_type_t program_type, const test_control context_entry.file_name = _make_unique_file_copy(program_attribs.native_file_name); } else { - // Use the same file name for all 'creator' threads + // Use the same file name for all 'creator' threads. context_entry.file_name = program_attribs.native_file_name; } } else { @@ -1042,7 +1042,7 @@ _invoke_test_thread_function(thread_context& context) exit(-1); } - // Set the timeout for connect attempts + // Set the timeout for connect attempts. timeval timeout; timeout.tv_sec = 5; // 5 seconds timeout.tv_usec = 0; @@ -1974,7 +1974,7 @@ _mt_load_stress_test_with_restart_timing( if (test_control_info.extension_restart_enabled && !start_restart_before_load) { // Wait for programs to load, then start extension restart. LOG_INFO("Waiting for programs to load, then starting extension restart"); - std::this_thread::sleep_for(std::chrono::seconds(5)); // Give programs time to load and attach + std::this_thread::sleep_for(std::chrono::seconds(5)); // Give programs time to load and attach. configure_extension_restart( test_control_info, extension_names, @@ -2032,9 +2032,9 @@ _mt_invoke_stress_test_multiple_programs(ebpf_execution_type_t program_type, con } context_entry.program_name = "cgroup_sock_addr"; - context_entry.role = thread_role_type::CREATOR; // All threads are creators for this test + context_entry.role = thread_role_type::CREATOR; // All threads are creators for this test. context_entry.thread_index = i; - context_entry.compartment_id = i + 1; // Unique compartment IDs + context_entry.compartment_id = i + 1; // Unique compartment IDs. context_entry.duration_minutes = test_control_info.duration_minutes; context_entry.extension_restart_enabled = test_control_info.extension_restart_enabled; } diff --git a/tests/unit/wer_report_test_wrapper.cpp b/tests/unit/wer_report_test_wrapper.cpp index dba5c7c023..eeb3a14962 100644 --- a/tests/unit/wer_report_test_wrapper.cpp +++ b/tests/unit/wer_report_test_wrapper.cpp @@ -45,7 +45,7 @@ AddVectoredExceptionHandler_test(_In_ unsigned long first, _In_ PVECTORED_EXCEPT unsigned long SetThreadStackGuarantee_test_stack_size_in_bytes = 0; // Use BOOL to pass "SetThreadStackGuarantee" -// defined in windows "processthreadapi.h" file +// defined in windows "processthreadapi.h" file. BOOL SetThreadStackGuarantee_test(_Inout_ unsigned long* stack_size_in_bytes) { @@ -209,7 +209,7 @@ TEST_CASE("wer_report_failure", "[wer_report]") WerReportAddDump_test_called = false; WerReportSubmit_test_called = false; - // Fail WerReportCreate + // Fail WerReportCreate. REQUIRE(AddVectoredExceptionHandler_test_handler(&exception_pointers) == EXCEPTION_CONTINUE_SEARCH); REQUIRE(WerReportCreate_test_called); REQUIRE(!WerReportAddDump_test_called); @@ -222,7 +222,7 @@ TEST_CASE("wer_report_failure", "[wer_report]") WerReportAddDump_test_called = false; WerReportSubmit_test_called = false; - // Fail WerReportAddDump + // Fail WerReportAddDump. REQUIRE(AddVectoredExceptionHandler_test_handler(&exception_pointers) == EXCEPTION_CONTINUE_SEARCH); REQUIRE(WerReportCreate_test_called); REQUIRE(WerReportAddDump_test_called); @@ -235,7 +235,7 @@ TEST_CASE("wer_report_failure", "[wer_report]") WerReportAddDump_test_called = false; WerReportSubmit_test_called = false; - // Fail WerReportSubmit + // Fail WerReportSubmit. REQUIRE(AddVectoredExceptionHandler_test_handler(&exception_pointers) == EXCEPTION_CONTINUE_SEARCH); REQUIRE(WerReportCreate_test_called); REQUIRE(WerReportAddDump_test_called); diff --git a/tools/bpf2c/bpf2c.cpp b/tools/bpf2c/bpf2c.cpp index 84731278d8..10e061996c 100644 --- a/tools/bpf2c/bpf2c.cpp +++ b/tools/bpf2c/bpf2c.cpp @@ -104,7 +104,7 @@ get_program_info_type_hash(const std::vector& actual_helper_ids, const helper_id_ordering[helper_id] = index; } } - // Hash helper ids in increasing helper_id order + // Hash helper ids in increasing helper_id order. for (auto [helper_id, index] : helper_id_ordering) { hash_t::append_byte_range( byte_range, program_info->program_type_specific_helper_prototype[index].helper_id); diff --git a/tools/bpf2c/bpf2c_dll.c b/tools/bpf2c/bpf2c_dll.c index c9d263ee45..0d6b57cd85 100644 --- a/tools/bpf2c/bpf2c_dll.c +++ b/tools/bpf2c/bpf2c_dll.c @@ -4,7 +4,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table ___METADATA_TABLE___##_metadata_table diff --git a/tools/bpf2c/bpf_code_generator.cpp b/tools/bpf2c/bpf_code_generator.cpp index 4495c74212..cde539d749 100644 --- a/tools/bpf2c/bpf_code_generator.cpp +++ b/tools/bpf2c/bpf_code_generator.cpp @@ -120,7 +120,7 @@ static const std::string _predicate_format_string[] = { #define ADD_OPCODE(X) {static_cast(X), std::string(#X)} -// remove EBPF_ATOMIC_ prefix +// Remove EBPF_ATOMIC_ prefix. #define ADD_ATOMIC_OPCODE(X) {static_cast(X), std::string(#X).substr(12)} static std::map _atomic_opcode_name_strings = { @@ -478,7 +478,7 @@ bpf_code_generator::visit_symbols(symbol_visitor_t visitor, const unsafe_string& throw bpf_code_generator_exception("invalid symbol value"); } - // Check for overflow of value + size + // Check for overflow of value + size. if ((value + size) < value) { throw bpf_code_generator_exception("invalid symbol value"); } @@ -1076,7 +1076,7 @@ bpf_code_generator::bpf_code_generator_program::encode_instructions( auto effective_program_name = !program_name.empty() ? program_name : elf_section_name; auto helper_array_prefix = "runtime_context->helper_data[{}]"; - // Encode instructions + // Encode instructions. for (size_t i = 0; i < program_output.size(); i++) { auto& output = program_output[i]; auto& inst = output.instruction; diff --git a/tools/netsh/dllmain.c b/tools/netsh/dllmain.c index d7d72bcb17..322ae2ba80 100644 --- a/tools/netsh/dllmain.c +++ b/tools/netsh/dllmain.c @@ -32,7 +32,7 @@ DllMain(HMODULE moduleHandle, unsigned long reasonForCall, void* reserved) return TRUE; } -// Verbs +// Verbs. #define CMD_GROUP_ADD L"add" #define CMD_GROUP_DELETE L"delete" #define CMD_GROUP_PIN L"pin" @@ -40,7 +40,7 @@ DllMain(HMODULE moduleHandle, unsigned long reasonForCall, void* reserved) #define CMD_GROUP_SHOW L"show" #define CMD_GROUP_UNPIN L"unpin" -// Nouns +// Nouns. #define CMD_EBPF_SHOW_DISASSEMBLY L"disassembly" #define CMD_EBPF_SHOW_LINKS L"links" #define CMD_EBPF_SHOW_MAPS L"maps" @@ -87,25 +87,25 @@ CMD_ENTRY g_EbpfShowCommandTable[] = { #else typedef struct _CMD_ENTRY_ORIGINAL { - _Field_z_ const wchar_t* pwszCmdToken; // The token for the command - PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command - unsigned long dwShortCmdHelpToken; // The short help message + _Field_z_ const wchar_t* pwszCmdToken; // The token for the command. + PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command. + unsigned long dwShortCmdHelpToken; // The short help message. unsigned long - dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?) - unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above) - PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against + dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?). + unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above). + PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against. } CMD_ENTRY_ORIGINAL, *PCMD_ENTRY_ORIGINAL; #define CREATE_CMD_ENTRY_ORIGINAL(t, f) {CMD_##t, f, HLP_##t, HLP_##t##_EX, CMD_FLAG_PRIVATE, NULL} typedef struct _CMD_ENTRY_LONG { - _Field_z_ const wchar_t* pwszCmdToken; // The token for the command - PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command - unsigned long dwShortCmdHelpToken; // The short help message + _Field_z_ const wchar_t* pwszCmdToken; // The token for the command. + PFN_HANDLE_CMD pfnCmdHandler; // The function which handles this command. + unsigned long dwShortCmdHelpToken; // The short help message. unsigned long - dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?) - unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above) - PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against + dwCmdHlpToken; // The message to display if the only thing after the command is a help token (HELP, /?, -?, ?). + unsigned long dwFlags; // Flags (see CMD_FLAGS_xxx above). + PNS_OSVERSIONCHECK pOsVersionCheck; // Check for the version of the OS this command can run against. void* pfnCustomHelpFn; } CMD_ENTRY_LONG, *PCMD_ENTRY_LONG; #define CREATE_CMD_ENTRY_LONG(t, f) {CMD_##t, f, HLP_##t, HLP_##t##_EX, CMD_FLAG_PRIVATE, NULL, NULL} diff --git a/undocked/tests/sample/ext/drv/sample_ext_drv.c b/undocked/tests/sample/ext/drv/sample_ext_drv.c index b6deecb40e..6fe3ba58db 100644 --- a/undocked/tests/sample/ext/drv/sample_ext_drv.c +++ b/undocked/tests/sample/ext/drv/sample_ext_drv.c @@ -124,8 +124,7 @@ _sample_ebpf_ext_driver_initialize_objects( status = WdfDeviceCreate(&device_initialize, WDF_NO_OBJECT_ATTRIBUTES, device); if (!NT_SUCCESS(status)) { - // Do not free if any other call - // after WdfDeviceCreate fails. + // Do not free if any other call after WdfDeviceCreate fails. WdfDeviceInitFree(device_initialize); device_initialize = NULL; goto Exit; From b9f9ee20fc9ab6c3917bdbb9fbd178349096eccd Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Tue, 28 Oct 2025 14:33:44 -0700 Subject: [PATCH 6/7] Update expected output Signed-off-by: Alan Jowett --- tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c | 2 +- tests/bpf2c_tests/expected/bad_map_name_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c | 2 +- tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c | 2 +- tests/bpf2c_tests/expected/bpf_call_dll.c | 2 +- tests/bpf2c_tests/expected/bpf_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c | 2 +- tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c | 2 +- tests/bpf2c_tests/expected/divide_by_zero_dll.c | 2 +- tests/bpf2c_tests/expected/global_vars_and_map_dll.c | 2 +- tests/bpf2c_tests/expected/global_vars_dll.c | 2 +- tests/bpf2c_tests/expected/hash_of_map_dll.c | 2 +- tests/bpf2c_tests/expected/inner_map_dll.c | 2 +- tests/bpf2c_tests/expected/map_dll.c | 2 +- tests/bpf2c_tests/expected/map_in_map_btf_dll.c | 2 +- tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c | 2 +- tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c | 2 +- tests/bpf2c_tests/expected/map_reuse_2_dll.c | 2 +- tests/bpf2c_tests/expected/map_reuse_dll.c | 2 +- tests/bpf2c_tests/expected/map_synchronized_update_dll.c | 2 +- tests/bpf2c_tests/expected/multiple_programs_dll.c | 2 +- tests/bpf2c_tests/expected/pidtgid_dll.c | 2 +- tests/bpf2c_tests/expected/printk_dll.c | 2 +- tests/bpf2c_tests/expected/printk_legacy_dll.c | 2 +- tests/bpf2c_tests/expected/process_start_key_dll.c | 2 +- tests/bpf2c_tests/expected/sockops_dll.c | 2 +- tests/bpf2c_tests/expected/strings_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_bad_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_map_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_multiple_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_recursive_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_same_section_dll.c | 2 +- tests/bpf2c_tests/expected/tail_call_sequential_dll.c | 2 +- tests/bpf2c_tests/expected/test_sample_ebpf_dll.c | 2 +- tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c | 2 +- .../expected/test_sample_invalid_socket_cookie_dll.c | 2 +- tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c | 2 +- tests/bpf2c_tests/expected/test_utility_helpers_dll.c | 2 +- tests/bpf2c_tests/expected/thread_start_time_dll.c | 2 +- tests/bpf2c_tests/expected/utility_dll.c | 2 +- 50 files changed, 50 insertions(+), 50 deletions(-) diff --git a/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c b/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c index 25f39520d8..0bd0dbe885 100644 --- a/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c +++ b/tests/bpf2c_tests/expected/atomic_instruction_fetch_add_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table atomic_instruction_fetch_add##_metadata_table diff --git a/tests/bpf2c_tests/expected/bad_map_name_dll.c b/tests/bpf2c_tests/expected/bad_map_name_dll.c index dfc404cae5..4ecb32e91d 100644 --- a/tests/bpf2c_tests/expected/bad_map_name_dll.c +++ b/tests/bpf2c_tests/expected/bad_map_name_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bad_map_name##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c b/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c index 2d28a4f419..21386939a4 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_bpf2bpf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_bpf2bpf##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_dll.c b/tests/bpf2c_tests/expected/bindmonitor_dll.c index 2cfb2d172b..3e716a4c6a 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c b/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c index dab0de4254..054a582e43 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_mt_tailcall_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_mt_tailcall##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c b/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c index 365ca637f5..eb9fb612c1 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_perf_event_array_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_perf_event_array##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c b/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c index 57e2e59904..6674e7bbc9 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_ringbuf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_ringbuf##_metadata_table diff --git a/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c b/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c index 629fcb3421..e50a61eac6 100644 --- a/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c +++ b/tests/bpf2c_tests/expected/bindmonitor_tailcall_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bindmonitor_tailcall##_metadata_table diff --git a/tests/bpf2c_tests/expected/bpf_call_dll.c b/tests/bpf2c_tests/expected/bpf_call_dll.c index c848b2868f..60dc96b608 100644 --- a/tests/bpf2c_tests/expected/bpf_call_dll.c +++ b/tests/bpf2c_tests/expected/bpf_call_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bpf_call##_metadata_table diff --git a/tests/bpf2c_tests/expected/bpf_dll.c b/tests/bpf2c_tests/expected/bpf_dll.c index 95e7ec8733..c103abe742 100644 --- a/tests/bpf2c_tests/expected/bpf_dll.c +++ b/tests/bpf2c_tests/expected/bpf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table bpf##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c b/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c index 38f8a5b014..a4c8f98714 100644 --- a/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_count_connect4_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_count_connect4##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c b/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c index d0c9316987..f85b9530e9 100644 --- a/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_count_connect6_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_count_connect6##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c b/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c index 67bb8bc938..d51ca77b4b 100644 --- a/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_mt_connect4_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_mt_connect4##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c b/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c index 4f0ba28763..d6f8628e13 100644 --- a/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_mt_connect6_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_mt_connect6##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c b/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c index 52d8eaf135..b90417a58f 100644 --- a/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_sock_addr2_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_sock_addr2##_metadata_table diff --git a/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c b/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c index 3bbb23383b..c26a75f69b 100644 --- a/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c +++ b/tests/bpf2c_tests/expected/cgroup_sock_addr_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table cgroup_sock_addr##_metadata_table diff --git a/tests/bpf2c_tests/expected/divide_by_zero_dll.c b/tests/bpf2c_tests/expected/divide_by_zero_dll.c index 79a04a1e92..22877299f8 100644 --- a/tests/bpf2c_tests/expected/divide_by_zero_dll.c +++ b/tests/bpf2c_tests/expected/divide_by_zero_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table divide_by_zero##_metadata_table diff --git a/tests/bpf2c_tests/expected/global_vars_and_map_dll.c b/tests/bpf2c_tests/expected/global_vars_and_map_dll.c index a4fc7e904b..6ca56d6419 100644 --- a/tests/bpf2c_tests/expected/global_vars_and_map_dll.c +++ b/tests/bpf2c_tests/expected/global_vars_and_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table global_vars_and_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/global_vars_dll.c b/tests/bpf2c_tests/expected/global_vars_dll.c index 499ecd0075..dc58b79c11 100644 --- a/tests/bpf2c_tests/expected/global_vars_dll.c +++ b/tests/bpf2c_tests/expected/global_vars_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table global_vars##_metadata_table diff --git a/tests/bpf2c_tests/expected/hash_of_map_dll.c b/tests/bpf2c_tests/expected/hash_of_map_dll.c index 12407559ed..24c2f30f71 100644 --- a/tests/bpf2c_tests/expected/hash_of_map_dll.c +++ b/tests/bpf2c_tests/expected/hash_of_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table hash_of_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/inner_map_dll.c b/tests/bpf2c_tests/expected/inner_map_dll.c index 408493f42f..5da19ae227 100644 --- a/tests/bpf2c_tests/expected/inner_map_dll.c +++ b/tests/bpf2c_tests/expected/inner_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table inner_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_dll.c b/tests/bpf2c_tests/expected/map_dll.c index 075fd9497e..db1f482cb5 100644 --- a/tests/bpf2c_tests/expected/map_dll.c +++ b/tests/bpf2c_tests/expected/map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_in_map_btf_dll.c b/tests/bpf2c_tests/expected/map_in_map_btf_dll.c index 5784fbc7f4..87b5a9eaaa 100644 --- a/tests/bpf2c_tests/expected/map_in_map_btf_dll.c +++ b/tests/bpf2c_tests/expected/map_in_map_btf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_in_map_btf##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c b/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c index e7b3522799..4fd6654ce3 100644 --- a/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c +++ b/tests/bpf2c_tests/expected/map_in_map_legacy_id_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_in_map_legacy_id##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c b/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c index aa516d2079..2fbdc6198a 100644 --- a/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c +++ b/tests/bpf2c_tests/expected/map_in_map_legacy_idx_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_in_map_legacy_idx##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_reuse_2_dll.c b/tests/bpf2c_tests/expected/map_reuse_2_dll.c index d4f14ac7f1..3920bda8db 100644 --- a/tests/bpf2c_tests/expected/map_reuse_2_dll.c +++ b/tests/bpf2c_tests/expected/map_reuse_2_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_reuse_2##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_reuse_dll.c b/tests/bpf2c_tests/expected/map_reuse_dll.c index 62dc4a451f..69370cf363 100644 --- a/tests/bpf2c_tests/expected/map_reuse_dll.c +++ b/tests/bpf2c_tests/expected/map_reuse_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_reuse##_metadata_table diff --git a/tests/bpf2c_tests/expected/map_synchronized_update_dll.c b/tests/bpf2c_tests/expected/map_synchronized_update_dll.c index adf449ad8c..dc10ab4fde 100644 --- a/tests/bpf2c_tests/expected/map_synchronized_update_dll.c +++ b/tests/bpf2c_tests/expected/map_synchronized_update_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table map_synchronized_update##_metadata_table diff --git a/tests/bpf2c_tests/expected/multiple_programs_dll.c b/tests/bpf2c_tests/expected/multiple_programs_dll.c index 31a83f0b28..be1347f1ed 100644 --- a/tests/bpf2c_tests/expected/multiple_programs_dll.c +++ b/tests/bpf2c_tests/expected/multiple_programs_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table multiple_programs##_metadata_table diff --git a/tests/bpf2c_tests/expected/pidtgid_dll.c b/tests/bpf2c_tests/expected/pidtgid_dll.c index c322cf921b..591c65a57d 100644 --- a/tests/bpf2c_tests/expected/pidtgid_dll.c +++ b/tests/bpf2c_tests/expected/pidtgid_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table pidtgid##_metadata_table diff --git a/tests/bpf2c_tests/expected/printk_dll.c b/tests/bpf2c_tests/expected/printk_dll.c index 5b885bd4c3..8fc90f2edd 100644 --- a/tests/bpf2c_tests/expected/printk_dll.c +++ b/tests/bpf2c_tests/expected/printk_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table printk##_metadata_table diff --git a/tests/bpf2c_tests/expected/printk_legacy_dll.c b/tests/bpf2c_tests/expected/printk_legacy_dll.c index 0e3722b4b9..b3106dff83 100644 --- a/tests/bpf2c_tests/expected/printk_legacy_dll.c +++ b/tests/bpf2c_tests/expected/printk_legacy_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table printk_legacy##_metadata_table diff --git a/tests/bpf2c_tests/expected/process_start_key_dll.c b/tests/bpf2c_tests/expected/process_start_key_dll.c index 2335d28ed2..5847b68057 100644 --- a/tests/bpf2c_tests/expected/process_start_key_dll.c +++ b/tests/bpf2c_tests/expected/process_start_key_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table process_start_key##_metadata_table diff --git a/tests/bpf2c_tests/expected/sockops_dll.c b/tests/bpf2c_tests/expected/sockops_dll.c index 165fbf1e30..f95b4cd2d4 100644 --- a/tests/bpf2c_tests/expected/sockops_dll.c +++ b/tests/bpf2c_tests/expected/sockops_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table sockops##_metadata_table diff --git a/tests/bpf2c_tests/expected/strings_dll.c b/tests/bpf2c_tests/expected/strings_dll.c index e0a188c841..ecef5e7580 100644 --- a/tests/bpf2c_tests/expected/strings_dll.c +++ b/tests/bpf2c_tests/expected/strings_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table strings##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_bad_dll.c b/tests/bpf2c_tests/expected/tail_call_bad_dll.c index 8a535dcbd3..e74e072660 100644 --- a/tests/bpf2c_tests/expected/tail_call_bad_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_bad_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_bad##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_dll.c b/tests/bpf2c_tests/expected/tail_call_dll.c index 69f69b47bb..91ebfb95dd 100644 --- a/tests/bpf2c_tests/expected/tail_call_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_map_dll.c b/tests/bpf2c_tests/expected/tail_call_map_dll.c index e96a445bf5..4b6efc2bab 100644 --- a/tests/bpf2c_tests/expected/tail_call_map_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_map_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_map##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c b/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c index 9f81b23f0d..0b87db4735 100644 --- a/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_max_exceed_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_max_exceed##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_multiple_dll.c b/tests/bpf2c_tests/expected/tail_call_multiple_dll.c index 6a4f2d1498..30a3837dbe 100644 --- a/tests/bpf2c_tests/expected/tail_call_multiple_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_multiple_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_multiple##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_recursive_dll.c b/tests/bpf2c_tests/expected/tail_call_recursive_dll.c index e6ae6ac96f..3c7ba94777 100644 --- a/tests/bpf2c_tests/expected/tail_call_recursive_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_recursive_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_recursive##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_same_section_dll.c b/tests/bpf2c_tests/expected/tail_call_same_section_dll.c index e3ead29fc8..3fd25b407f 100644 --- a/tests/bpf2c_tests/expected/tail_call_same_section_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_same_section_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_same_section##_metadata_table diff --git a/tests/bpf2c_tests/expected/tail_call_sequential_dll.c b/tests/bpf2c_tests/expected/tail_call_sequential_dll.c index aedd922bcf..e6db4824b7 100644 --- a/tests/bpf2c_tests/expected/tail_call_sequential_dll.c +++ b/tests/bpf2c_tests/expected/tail_call_sequential_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table tail_call_sequential##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c b/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c index f3d7b6d059..417e3593cb 100644 --- a/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_ebpf_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_ebpf##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c b/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c index f3c4bf7911..12081ae94f 100644 --- a/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_implicit_helpers_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_implicit_helpers##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c b/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c index 277297adad..97ad845221 100644 --- a/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_invalid_socket_cookie_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_invalid_socket_cookie##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c b/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c index 7e79b8f090..0d790cf4a2 100644 --- a/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c +++ b/tests/bpf2c_tests/expected/test_sample_perf_event_array_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_sample_perf_event_array##_metadata_table diff --git a/tests/bpf2c_tests/expected/test_utility_helpers_dll.c b/tests/bpf2c_tests/expected/test_utility_helpers_dll.c index f801cacf44..72a6a9a2d4 100644 --- a/tests/bpf2c_tests/expected/test_utility_helpers_dll.c +++ b/tests/bpf2c_tests/expected/test_utility_helpers_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table test_utility_helpers##_metadata_table diff --git a/tests/bpf2c_tests/expected/thread_start_time_dll.c b/tests/bpf2c_tests/expected/thread_start_time_dll.c index 859a293d85..8a8cd09005 100644 --- a/tests/bpf2c_tests/expected/thread_start_time_dll.c +++ b/tests/bpf2c_tests/expected/thread_start_time_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table thread_start_time##_metadata_table diff --git a/tests/bpf2c_tests/expected/utility_dll.c b/tests/bpf2c_tests/expected/utility_dll.c index 7aff836900..538dc53689 100644 --- a/tests/bpf2c_tests/expected/utility_dll.c +++ b/tests/bpf2c_tests/expected/utility_dll.c @@ -7,7 +7,7 @@ #include "bpf2c.h" #include -#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers +#define WIN32_LEAN_AND_MEAN // Exclude rarely-used stuff from Windows headers. #include #define metadata_table utility##_metadata_table From 9502e06427a8cbcca912f8b3f8cc562dab40d49b Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Thu, 13 Nov 2025 09:10:57 -0800 Subject: [PATCH 7/7] Add comprehensive GitHub Copilot instructions for eBPF for Windows - Created .github/copilot-instructions.md with detailed guidelines - Addresses comment formatting requirements (complete sentences with periods) - Includes coding conventions, naming standards, and project-specific rules - Covers SAL annotations, error handling patterns, and testing guidelines - Provides 10-point checklist for code generation best practices - Helps ensure Copilot generates code that follows project standards - Responds to suggestion from @dthaler in PR #4760 --- .github/copilot-instructions.md | 82 +++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 .github/copilot-instructions.md diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md new file mode 100644 index 0000000000..65e8f811c3 --- /dev/null +++ b/.github/copilot-instructions.md @@ -0,0 +1,82 @@ +# Copilot Instructions for eBPF for Windows + +When working on the eBPF for Windows project, please follow these guidelines to ensure code quality and consistency. + +## Comment Guidelines + +### Comment Formatting +- **All comments MUST be complete sentences ending with proper punctuation (periods).** +- Single-line comments should start with `//` followed by a space and a complete sentence ending with a period. +- Multi-line comments should follow the same complete sentence rule for each line. +- Inline comments should also be complete sentences ending with periods. + +**Examples:** +```c +// This is a correct comment. +/* This is also a correct multi-line comment. */ + +// Correct: Calculate the hash value for the key. +int hash = calculate_hash(key); + +// Incorrect: Calculate the hash value for the key +// Incorrect: calculate hash value +``` + +### Comment Content +- Comments should be clear, concise, and add value to understanding the code. +- Avoid stating the obvious; focus on explaining why, not what. +- Use doxygen comments with `\[in,out\]` direction annotations for all public API headers. + +## Coding Conventions + +### Naming Conventions +- Use `lower_snake_case` for variable, member/field, and function names. +- Use `UPPER_SNAKE_CASE` for macro names and constants. +- Prefix eBPF specific names in the global namespace with `ebpf_` (e.g., `ebpf_result_t`). +- Prefix names with `_` to indicate internal and private fields or methods. +- Prefix struct definitions with `_` and always create a typedef with the suffix `_t`. + +### Type Usage +- Use fixed length types from `stdint.h` (e.g., `int64_t`, `uint8_t`) instead of language keywords. +- Use `const` and `static` modifiers to scope exposure appropriately. + +### Code Structure +- Source lines MUST NOT exceed 120 columns. +- Single-line if/else/loop blocks MUST be enclosed in braces. +- Include local headers (with `""`) before system headers (with `<>`). +- List headers in alphabetical order where possible. +- Use `#pragma once` in all header files. + +### License Header +Every code file must include this license header: +```c +// Copyright (c) eBPF for Windows contributors +// SPDX-License-Identifier: MIT +``` + +## What NOT to Do + +- **DON'T** use global variables where possible. +- **DON'T** use abbreviations unless they are well-known terms. +- **DON'T** use hard-coded magic numbers; use `#define`, enum, or const values. +- **DON'T** use commented-out code or code in `#if 0` blocks. +- **DON'T** leave comments without proper punctuation. + +## When Generating Code + +1. Ensure all comments are grammatically complete sentences with proper punctuation. +2. Follow the established naming conventions consistently. +3. Include appropriate error handling and input validation. +4. Add doxygen comments for public APIs. +5. Follow the existing code structure and formatting patterns in the file being modified. +6. Use meaningful variable and function names that follow the project conventions. + +## Pull Request Guidelines + +- Ensure existing tests continue to pass. +- Provide tests for every bug/feature that is completed. +- Format code using clang-format before submitting. +- Verify that all comments follow the complete sentence rule. +- Check that the code follows the project's naming conventions. + +Remember: Code clarity and consistency are paramount. When in doubt, follow the existing patterns in the codebase and ensure all comments are complete, well-formed sentences. \ No newline at end of file