Optimize Go CLI output parsing by converting to utf-8 only once

Author: JamieMagee

src/Microsoft.ComponentDetection.Detectors/go/Parsers/GoCLIParser.cs

@@ -5,6 +5,7 @@ namespace Microsoft.ComponentDetection.Detectors.Go;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;
+using System.Text;
 using System.Text.Json;
 using System.Threading.Tasks;
 using Microsoft.ComponentDetection.Common.Telemetry.Records;
@@ -78,10 +79,11 @@ private void RecordBuildDependencies(string goListOutput, ISingleFileComponentRe
         using var record = new GoReplaceTelemetryRecord();
 
         // Go CLI outputs multiple JSON objects (not an array), so we need to parse them one by one
-        var remaining = goListOutput.AsMemory();
+        var utf8Bytes = Encoding.UTF8.GetBytes(goListOutput);
+        var remaining = utf8Bytes.AsSpan();
         while (!remaining.IsEmpty)
         {
-            var reader = new Utf8JsonReader(System.Text.Encoding.UTF8.GetBytes(remaining.ToString()));
+            var reader = new Utf8JsonReader(remaining);
             try
             {
                 var buildModule = JsonSerializer.Deserialize<GoBuildModule>(ref reader);
@@ -95,7 +97,7 @@ private void RecordBuildDependencies(string goListOutput, ISingleFileComponentRe
                 remaining = remaining[consumed..];
 
                 // Skip whitespace between JSON objects
-                while (!remaining.IsEmpty && char.IsWhiteSpace(remaining.Span[0]))
+                while (!remaining.IsEmpty && char.IsWhiteSpace((char)remaining[0]))
                 {
                     remaining = remaining[1..];
                 }