Skip to content

Commit 2a7f50f

Browse files
authored
CG alert - Update cmdLine task (#5308)
* update cmdLine task for cgfix * update node10 task * update guid * update node version * update testcase * update comment * update timeout * update testcase
1 parent 3a7d8dc commit 2a7f50f

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/Misc/externals.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ if [[ "$L1_MODE" != "" || "$PRECACHE" != "" ]]; then
301301
# cmdline task
302302
acquireExternalTool "$CONTAINER_URL/l1Tasks/d9bafed4-0b18-4f58-968d-86655b4d2ce9.zip" "Tasks" false dont_uncompress
303303
# cmdline node10 task
304-
acquireExternalTool "$CONTAINER_URL/l1Tasks/f9bafed4-0b18-4f58-968d-86655b4d2ce9.zip" "Tasks" false dont_uncompress
304+
acquireExternalTool "$CONTAINER_URL/l1Tasks/b9bafed4-0b18-4f58-968d-86655b4d2ce9.zip" "Tasks" false dont_uncompress
305305

306306
# with the current setup of this package there are backslashes so it fails to extract on non-windows at runtime
307307
# we may need to fix this in the Agent

src/Test/L1/Worker/CoreL1Tests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public async Task Test_Base()
5050
[Trait("Category", "Worker")]
5151
[InlineData(false)]
5252
[InlineData(true)]
53-
public async Task Test_Base_Node10(bool writeToBlobstorageService)
53+
public async Task Test_Base_Node20(bool writeToBlobstorageService)
5454
{
5555
try
5656
{
@@ -60,7 +60,7 @@ public async Task Test_Base_Node10(bool writeToBlobstorageService)
6060

6161
message.Steps.Clear();
6262
// Add variable setting tasks
63-
message.Steps.Add(CreateNode10ScriptTask("echo Hey!"));
63+
message.Steps.Add(CreateNode20ScriptTask("echo Hey!"));
6464
message.Variables.Add("agent.LogToBlobstorageService", writeToBlobstorageService.ToString());
6565

6666
// Act
@@ -81,9 +81,9 @@ public async Task Test_Base_Node10(bool writeToBlobstorageService)
8181
// CmdLineV2 runs on powershell on windows
8282
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
8383
{
84-
// Assert we used Node 10 from debug logs
84+
// Assert we used Node 20 from debug logs
8585
var log = GetTimelineLogLines(steps[1]);
86-
Assert.Equal(1, log.Where(x => x.Contains("Using node path:") && x.Contains("node10")).Count());
86+
Assert.Equal(1, log.Where(x => x.Contains("Using node path:") && x.Contains("node20")).Count());
8787
}
8888
}
8989
finally

src/Test/L1/Worker/L1TestBase.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,15 +142,15 @@ protected static TaskStep CreateScriptTask(string script)
142142
return step;
143143
}
144144

145-
protected static TaskStep CreateNode10ScriptTask(string script)
145+
protected static TaskStep CreateNode20ScriptTask(string script)
146146
{
147147
var step = new TaskStep
148148
{
149149
Reference = new TaskStepDefinitionReference
150150
{
151-
Id = Guid.Parse("f9bafed4-0b18-4f58-968d-86655b4d2ce9"),
151+
Id = Guid.Parse("b9bafed4-0b18-4f58-968d-86655b4d2ce9"),
152152
Name = "CmdLine",
153-
Version = "2.201.1"
153+
Version = "2.250.1"
154154
},
155155
Name = "CmdLine",
156156
DisplayName = "CmdLine",

0 commit comments

Comments
 (0)