Prevent infinite recursion resolving nested conditional types with import types in them (#32097)

* Prevent infinite recursion resolving conditional types

* Use push/popTypeResolution and issue error

* Add failing test

* Fix the actual problem

* Revert unnecessary changes

Author: andrewbranch

src/compiler/checker.ts

@@ -5037,8 +5037,10 @@ namespace ts {
             return Debug.assertNever(propertyName);
         }
 
-        // Pop an entry from the type resolution stack and return its associated result value. The result value will
-        // be true if no circularities were detected, or false if a circularity was found.
+        /**
+         * Pop an entry from the type resolution stack and return its associated result value. The result value will
+         * be true if no circularities were detected, or false if a circularity was found.
+         */
         function popTypeResolution(): boolean {
             resolutionTargets.pop();
             resolutionPropertyNames.pop();
@@ -11402,7 +11404,8 @@ namespace ts {
 
         function maybeTypeParameterReference(node: Node) {
             return !(node.kind === SyntaxKind.QualifiedName ||
-                node.parent.kind === SyntaxKind.TypeReference && (<TypeReferenceNode>node.parent).typeArguments && node === (<TypeReferenceNode>node.parent).typeName);
+                node.parent.kind === SyntaxKind.TypeReference && (<TypeReferenceNode>node.parent).typeArguments && node === (<TypeReferenceNode>node.parent).typeName ||
+                node.parent.kind === SyntaxKind.ImportType && (node.parent as ImportTypeNode).typeArguments && node === (node.parent as ImportTypeNode).qualifier);
         }
 
         function isTypeParameterPossiblyReferenced(tp: TypeParameter, node: Node) {

tests/baselines/reference/nestedGenericConditionalTypeWithGenericImportType.js

@@ -0,0 +1,18 @@
+//// [tests/cases/compiler/nestedGenericConditionalTypeWithGenericImportType.ts] ////
+
+//// [name.ts]
+// #31824
+
+export type Name<T> = any;
+
+//// [index.ts]
+type T<X> = any extends ((any extends any ? any : string) extends any ? import("./name").Name<X> : any)
+  ? any
+  : any;
+
+
+//// [name.js]
+"use strict";
+// #31824
+exports.__esModule = true;
+//// [index.js]

tests/baselines/reference/nestedGenericConditionalTypeWithGenericImportType.symbols

@@ -0,0 +1,17 @@
+=== tests/cases/compiler/name.ts ===
+// #31824
+
+export type Name<T> = any;
+>Name : Symbol(Name, Decl(name.ts, 0, 0))
+>T : Symbol(T, Decl(name.ts, 2, 17))
+
+=== tests/cases/compiler/index.ts ===
+type T<X> = any extends ((any extends any ? any : string) extends any ? import("./name").Name<X> : any)
+>T : Symbol(T, Decl(index.ts, 0, 0))
+>X : Symbol(X, Decl(index.ts, 0, 7))
+>Name : Symbol(Name, Decl(name.ts, 0, 0))
+>X : Symbol(X, Decl(index.ts, 0, 7))
+
+  ? any
+  : any;
+

tests/baselines/reference/nestedGenericConditionalTypeWithGenericImportType.types

@@ -0,0 +1,13 @@
+=== tests/cases/compiler/name.ts ===
+// #31824
+
+export type Name<T> = any;
+>Name : any
+
+=== tests/cases/compiler/index.ts ===
+type T<X> = any extends ((any extends any ? any : string) extends any ? import("./name").Name<X> : any)
+>T : any
+
+  ? any
+  : any;
+

tests/cases/compiler/nestedGenericConditionalTypeWithGenericImportType.ts

@@ -0,0 +1,9 @@
+// #31824
+
+// @filename: name.ts
+export type Name<T> = any;
+
+// @filename: index.ts
+type T<X> = any extends ((any extends any ? any : string) extends any ? import("./name").Name<X> : any)
+  ? any
+  : any;