Enable noUncheckedSideEffectImports by default (#62443)

Author: RyanCavanaugh

src/compiler/checker.ts

@@ -1531,7 +1531,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     var noImplicitThis = getStrictOptionValue(compilerOptions, "noImplicitThis");
     var useUnknownInCatchVariables = getStrictOptionValue(compilerOptions, "useUnknownInCatchVariables");
     var exactOptionalPropertyTypes = compilerOptions.exactOptionalPropertyTypes;
-    var noUncheckedSideEffectImports = !!compilerOptions.noUncheckedSideEffectImports;
+    var noUncheckedSideEffectImports = compilerOptions.noUncheckedSideEffectImports !== false;
 
     var checkBinaryExpression = createCheckBinaryExpression();
     var emitResolver = createResolver();
@@ -4684,9 +4684,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         }
     }
 
-    function resolveExternalModuleName(location: Node, moduleReferenceExpression: Expression, ignoreErrors?: boolean): Symbol | undefined {
+    function resolveExternalModuleName(location: Node, moduleReferenceExpression: Expression, ignoreErrors?: boolean, errorMessage?: DiagnosticMessage): Symbol | undefined {
         const isClassic = getEmitModuleResolutionKind(compilerOptions) === ModuleResolutionKind.Classic;
-        const errorMessage = isClassic ?
+        errorMessage ??= isClassic ?
             Diagnostics.Cannot_find_module_0_Did_you_mean_to_set_the_moduleResolution_option_to_nodenext_or_to_add_aliases_to_the_paths_option
             : Diagnostics.Cannot_find_module_0_or_its_corresponding_type_declarations;
         return resolveExternalModuleNameWorker(location, moduleReferenceExpression, ignoreErrors ? undefined : errorMessage, ignoreErrors);
@@ -48516,7 +48516,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 }
             }
             else if (noUncheckedSideEffectImports && !importClause) {
-                void resolveExternalModuleName(node, node.moduleSpecifier);
+                void resolveExternalModuleName(node, node.moduleSpecifier, /*ignoreErrors*/ undefined, Diagnostics.Cannot_find_module_or_type_declarations_for_side_effect_import_of_0);
             }
         }
         checkImportAttributes(node);

src/compiler/commandLineParser.ts

@@ -1243,7 +1243,7 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [
         affectsBuildInfo: true,
         category: Diagnostics.Modules,
         description: Diagnostics.Check_side_effect_imports,
-        defaultValueDescription: false,
+        defaultValueDescription: true,
     },
 
     // Source Maps

src/compiler/diagnosticMessages.json

@@ -4007,6 +4007,10 @@
         "category": "Error",
         "code": 2881
     },
+    "Cannot find module or type declarations for side-effect import of '{0}'.": {
+        "category": "Error",
+        "code": 2882
+    },
 
     "Import declaration '{0}' is using private name '{1}'.": {
         "category": "Error",

tests/baselines/reference/amdDependencyCommentName4.errors.txt

@@ -1,16 +1,20 @@
+amdDependencyCommentName4.ts(6,8): error TS2882: Cannot find module or type declarations for side-effect import of 'unaliasedModule1'.
 amdDependencyCommentName4.ts(8,21): error TS2792: Cannot find module 'aliasedModule1'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
 amdDependencyCommentName4.ts(11,26): error TS2792: Cannot find module 'aliasedModule2'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
 amdDependencyCommentName4.ts(14,15): error TS2792: Cannot find module 'aliasedModule3'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
 amdDependencyCommentName4.ts(17,21): error TS2792: Cannot find module 'aliasedModule4'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
+amdDependencyCommentName4.ts(20,8): error TS2882: Cannot find module or type declarations for side-effect import of 'unaliasedModule2'.
 
 
-==== amdDependencyCommentName4.ts (4 errors) ====
+==== amdDependencyCommentName4.ts (6 errors) ====
     ///<amd-dependency path='aliasedModule5' name='n1'/>
     ///<amd-dependency path='unaliasedModule3'/>
     ///<amd-dependency path='aliasedModule6' name='n2'/>
     ///<amd-dependency path='unaliasedModule4'/>
 
     import "unaliasedModule1";
+           ~~~~~~~~~~~~~~~~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of 'unaliasedModule1'.
 
     import r1 = require("aliasedModule1");
                         ~~~~~~~~~~~~~~~~
@@ -32,4 +36,6 @@ amdDependencyCommentName4.ts(17,21): error TS2792: Cannot find module 'aliasedMo
 !!! error TS2792: Cannot find module 'aliasedModule4'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
     ns;
 
-    import "unaliasedModule2";
+    import "unaliasedModule2";
+           ~~~~~~~~~~~~~~~~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of 'unaliasedModule2'.

tests/baselines/reference/autoAccessorDisallowedModifiers(target=es2017).errors.txt

@@ -23,14 +23,15 @@ autoAccessorDisallowedModifiers.ts(31,1): error TS1275: 'accessor' modifier can
 autoAccessorDisallowedModifiers.ts(32,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(33,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(34,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
+autoAccessorDisallowedModifiers.ts(34,17): error TS2882: Cannot find module or type declarations for side-effect import of 'x'.
 autoAccessorDisallowedModifiers.ts(35,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(35,25): error TS2792: Cannot find module 'x'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
 autoAccessorDisallowedModifiers.ts(36,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(37,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(38,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 
 
-==== autoAccessorDisallowedModifiers.ts (30 errors) ====
+==== autoAccessorDisallowedModifiers.ts (31 errors) ====
     abstract class C1 {
         accessor accessor a: any;
                  ~~~~~~~~
@@ -115,6 +116,8 @@ autoAccessorDisallowedModifiers.ts(38,1): error TS1275: 'accessor' modifier can
     accessor import "x";
     ~~~~~~~~
 !!! error TS1275: 'accessor' modifier can only appear on a property declaration.
+                    ~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of 'x'.
     accessor import {} from "x";
     ~~~~~~~~
 !!! error TS1275: 'accessor' modifier can only appear on a property declaration.

tests/baselines/reference/autoAccessorDisallowedModifiers(target=esnext).errors.txt

@@ -23,14 +23,15 @@ autoAccessorDisallowedModifiers.ts(31,1): error TS1275: 'accessor' modifier can
 autoAccessorDisallowedModifiers.ts(32,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(33,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(34,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
+autoAccessorDisallowedModifiers.ts(34,17): error TS2882: Cannot find module or type declarations for side-effect import of 'x'.
 autoAccessorDisallowedModifiers.ts(35,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(35,25): error TS2792: Cannot find module 'x'. Did you mean to set the 'moduleResolution' option to 'nodenext', or to add aliases to the 'paths' option?
 autoAccessorDisallowedModifiers.ts(36,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(37,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 autoAccessorDisallowedModifiers.ts(38,1): error TS1275: 'accessor' modifier can only appear on a property declaration.
 
 
-==== autoAccessorDisallowedModifiers.ts (30 errors) ====
+==== autoAccessorDisallowedModifiers.ts (31 errors) ====
     abstract class C1 {
         accessor accessor a: any;
                  ~~~~~~~~
@@ -115,6 +116,8 @@ autoAccessorDisallowedModifiers.ts(38,1): error TS1275: 'accessor' modifier can
     accessor import "x";
     ~~~~~~~~
 !!! error TS1275: 'accessor' modifier can only appear on a property declaration.
+                    ~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of 'x'.
     accessor import {} from "x";
     ~~~~~~~~
 !!! error TS1275: 'accessor' modifier can only appear on a property declaration.

tests/baselines/reference/checkExportsObjectAssignPrototypeProperty.errors.txt

@@ -1,12 +1,15 @@
+validator.ts(1,8): error TS2882: Cannot find module or type declarations for side-effect import of './'.
 validator.ts(19,4): error TS2540: Cannot assign to 'readonlyProp' because it is a read-only property.
 validator.ts(20,4): error TS2540: Cannot assign to 'readonlyAccessor' because it is a read-only property.
 validator.ts(21,1): error TS2322: Type 'string' is not assignable to type 'number'.
 validator.ts(22,1): error TS2322: Type 'string' is not assignable to type 'number'.
 validator.ts(23,1): error TS2322: Type 'number' is not assignable to type 'string'.
 
 
-==== validator.ts (5 errors) ====
+==== validator.ts (6 errors) ====
     import "./";
+           ~~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of './'.
 
     import Person = require("./mod1");
 

tests/baselines/reference/emit(jsx=preserve).errors.txt

@@ -3,6 +3,7 @@ main.ts(3,16): error TS2307: Cannot find module '../foo.mts' or its correspondin
 main.ts(4,16): error TS2307: Cannot find module '../../foo.cts' or its corresponding type declarations.
 main.ts(5,16): error TS2307: Cannot find module './foo.tsx' or its corresponding type declarations.
 main.ts(6,22): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
+main.ts(7,8): error TS2882: Cannot find module or type declarations for side-effect import of './foo.ts'.
 main.ts(8,15): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
 main.ts(10,8): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
 main.ts(11,8): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
@@ -23,7 +24,7 @@ no.ts(11,8): error TS2307: Cannot find module 'node:path' or its corresponding t
 ==== globals.d.ts (0 errors) ====
     declare function require(module: string): any;
 
-==== main.ts (10 errors) ====
+==== main.ts (11 errors) ====
     // Rewrite
     import {} from "./foo.ts";
                    ~~~~~~~~~~
@@ -41,6 +42,8 @@ no.ts(11,8): error TS2307: Cannot find module 'node:path' or its corresponding t
                          ~~~~~~~~~~
 !!! error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
     import "./foo.ts";
+           ~~~~~~~~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of './foo.ts'.
     export * from "./foo.ts";
                   ~~~~~~~~~~
 !!! error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.

tests/baselines/reference/emit(jsx=react).errors.txt

@@ -3,6 +3,7 @@ main.ts(3,16): error TS2307: Cannot find module '../foo.mts' or its correspondin
 main.ts(4,16): error TS2307: Cannot find module '../../foo.cts' or its corresponding type declarations.
 main.ts(5,16): error TS2307: Cannot find module './foo.tsx' or its corresponding type declarations.
 main.ts(6,22): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
+main.ts(7,8): error TS2882: Cannot find module or type declarations for side-effect import of './foo.ts'.
 main.ts(8,15): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
 main.ts(10,8): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
 main.ts(11,8): error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
@@ -23,7 +24,7 @@ no.ts(11,8): error TS2307: Cannot find module 'node:path' or its corresponding t
 ==== globals.d.ts (0 errors) ====
     declare function require(module: string): any;
 
-==== main.ts (10 errors) ====
+==== main.ts (11 errors) ====
     // Rewrite
     import {} from "./foo.ts";
                    ~~~~~~~~~~
@@ -41,6 +42,8 @@ no.ts(11,8): error TS2307: Cannot find module 'node:path' or its corresponding t
                          ~~~~~~~~~~
 !!! error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.
     import "./foo.ts";
+           ~~~~~~~~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of './foo.ts'.
     export * from "./foo.ts";
                   ~~~~~~~~~~
 !!! error TS2307: Cannot find module './foo.ts' or its corresponding type declarations.

tests/baselines/reference/es6ImportWithoutFromClauseInEs5.errors.txt

@@ -0,0 +1,10 @@
+es6ImportWithoutFromClauseInEs5_1.ts(1,8): error TS2882: Cannot find module or type declarations for side-effect import of 'es6ImportWithoutFromClauseInEs5_0'.
+
+
+==== es6ImportWithoutFromClauseInEs5_0.ts (0 errors) ====
+    export var a = 10;
+    
+==== es6ImportWithoutFromClauseInEs5_1.ts (1 errors) ====
+    import "es6ImportWithoutFromClauseInEs5_0";
+           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+!!! error TS2882: Cannot find module or type declarations for side-effect import of 'es6ImportWithoutFromClauseInEs5_0'.