Make "/home/src/workspaces/project" as default current directory without having to specify it for tsc tests (#59875)

Author: sheetalkamat

src/testRunner/unittests/helpers/declarationEmit.ts

@@ -34,7 +34,7 @@ function getSysForDeclarationEmitWithErrors(options: CompilerOptions, incrementa
             type: "module",
             main: "./distribution/index.js",
         }),
-    }, { currentDirectory: "/home/src/workspaces/project" });
+    });
 }
 
 function getSysForDeclarationEmitWithErrorsWithOutFile(options: CompilerOptions, incremental: true | undefined) {
@@ -61,7 +61,7 @@ function getSysForDeclarationEmitWithErrorsWithOutFile(options: CompilerOptions,
             declare const ky: KyInstance;
             export default ky;
         `,
-    }, { currentDirectory: "/home/src/workspaces/project" });
+    });
 }
 
 export function forEachDeclarationEmitWithErrorsScenario(

src/testRunner/unittests/helpers/noCheck.ts

@@ -53,7 +53,7 @@ export function forEachTscScenarioWithNoCheck(buildType: "-b" | "-p") {
                                     ...options,
                                 },
                             }),
-                        }, { currentDirectory: "/home/src/workspaces/project" }),
+                        }),
                     commandLineArgs: [...commandLineArgs, "--noCheck"],
                     edits: [
                         noChangeRun, // Should be no op

src/testRunner/unittests/helpers/noEmit.ts

@@ -139,7 +139,7 @@ function forEachNoEmitChangesWorker(commandType: string[], compilerOptions: Comp
             "/home/src/workspaces/project/tsconfig.json": jsonToReadableText({
                 compilerOptions: compilerOptionsToConfigJson(compilerOptions),
             }),
-        }, { currentDirectory: "/home/src/workspaces/project" });
+        });
     }
 }
 

src/testRunner/unittests/helpers/virtualFileSystemWithWatch.ts

@@ -535,12 +535,20 @@ export class TestServerHost implements server.ServerHost, FormatDiagnosticsHost,
 
     static createWatchedSystem(
         fileOrFolderList: FileOrFolderOrSymLinkMap | readonly FileOrFolderOrSymLink[],
-        params:
-            & Omit<TestServerHostCreationParameters, "typingsInstallerGlobalCacheLocation" | "typingsInstallerTypesRegistry">
-            & { currentDirectory: string; },
+        params?: Omit<TestServerHostCreationParameters, "typingsInstallerGlobalCacheLocation" | "typingsInstallerTypesRegistry">,
     ): TestServerHost {
-        ensureWatchablePath(params.currentDirectory, `currentDirectory: ${params.currentDirectory}`);
-        return new TestServerHost(fileOrFolderList, params);
+        const useDefaultCurrentDirectory = !params?.currentDirectory;
+        if (useDefaultCurrentDirectory) (params ??= {}).currentDirectory = "/home/src/workspaces/project";
+        else ensureWatchablePath(params!.currentDirectory!, `currentDirectory: ${params!.currentDirectory}`);
+        const host = new TestServerHost(fileOrFolderList, params);
+        if (useDefaultCurrentDirectory && fileOrFolderList !== emptyArray) {
+            const folder = host.getRealFolder(host.toPath(host.currentDirectory))!;
+            Debug.assert(
+                folder.entries.length,
+                `currentDirectory: Not specified, using default as "/home/src/workspaces/project". The files specified do not belong to it.`,
+            );
+        }
+        return host;
     }
 
     static createServerHost(

src/testRunner/unittests/tsbuild/commandLine.ts

@@ -54,7 +54,7 @@ describe("unittests:: tsbuild:: commandLine::", () => {
                 "/home/src/workspaces/project/b.ts": `export const b = 10;const bLocal = 10;`,
                 "/home/src/workspaces/project/c.ts": `import { a } from "./a";export const c = a;`,
                 "/home/src/workspaces/project/d.ts": `import { b } from "./b";export const d = b;`,
-            }, { currentDirectory: "/home/src/workspaces/project" });
+            });
         }
         function verify(options: ts.CompilerOptions) {
             verifyTsc({

src/testRunner/unittests/tsbuild/configFileErrors.ts

@@ -33,7 +33,7 @@ describe("unittests:: tsbuild:: configFileErrors:: when tsconfig extends the mis
                         { path: "./tsconfig.second.json" },
                     ],
                 }),
-            }, { currentDirectory: "/home/src/workspaces/project" }),
+            }),
         commandLineArgs: ["--b"],
     });
 });
@@ -57,7 +57,7 @@ describe("unittests:: tsbuild:: configFileErrors:: reports syntax errors in conf
         "b.ts"
     ]
 }`,
-                }, { currentDirectory: "/home/src/workspaces/project" }),
+                }),
             commandLineArgs: ["--b"],
             edits: [
                 {

src/testRunner/unittests/tsbuild/declarationEmit.ts

@@ -124,7 +124,7 @@ export function fn4() {
                     include: ["src"],
                     references: [{ path: "../pkg1" }],
                 }),
-            }, { currentDirectory: "/home/src/workspaces/project" }),
+            }),
         commandLineArgs: ["--b", "packages/pkg2/tsconfig.json", "--verbose"],
     });
 

src/testRunner/unittests/tsbuild/emitDeclarationOnly.ts

@@ -49,7 +49,7 @@ describe("unittests:: tsbuild:: on project with emitDeclarationOnly:: set to tru
                     emitDeclarationOnly: true,
                 },
             }),
-        }, { currentDirectory: "/home/src/workspaces/project" });
+        });
     }
 
     function verifyEmitDeclarationOnly(disableMap?: true) {

src/testRunner/unittests/tsbuild/exitCodeOnBogusFile.ts

@@ -7,7 +7,7 @@ describe("unittests:: tsbuild:: exitCodeOnBogusFile:: test exit code", () => {
     verifyTsc({
         scenario: "exitCodeOnBogusFile",
         subScenario: `test exit code`,
-        sys: () => TestServerHost.createWatchedSystem(emptyArray, { currentDirectory: "/home/src/workspaces/project" }),
+        sys: () => TestServerHost.createWatchedSystem(emptyArray),
         commandLineArgs: ["-b", "bogus.json"],
     });
 });

src/testRunner/unittests/tsbuild/graphOrdering.ts

@@ -19,10 +19,7 @@ describe("unittests:: tsbuild:: graphOrdering::", () => {
     ];
 
     before(() => {
-        const sys = TestServerHost.createWatchedSystem(ts.emptyArray, {
-            useCaseSensitiveFileNames: true,
-            currentDirectory: "/home/src/workspaces/project",
-        });
+        const sys = TestServerHost.createWatchedSystem(ts.emptyArray, { useCaseSensitiveFileNames: true });
         host = ts.createSolutionBuilderHost(sys);
         writeProjects(sys, ["A", "B", "C", "D", "E", "F", "G", "H", "I", "J"], deps);
     });