Update HTMLMediaElement.preload type and comment (#1113)

MartinJohns · saschanaz · web-flow · commit 5b728657f4d7 · 2021-08-23T19:53:01.000Z
* Update HTMLMediaElement.preload type and comment

* Apply suggestions from code review

Co-authored-by: Kagami Sascha Rosylight &lt;saschanaz@outlook.com&gt;

* Run baseline-accept on changes from code review

Co-authored-by: Kagami Sascha Rosylight &lt;saschanaz@outlook.com&gt;
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -6940,8 +6940,8 @@ interface HTMLMediaElement extends HTMLElement {
     playbackRate: number;
     /** Gets TimeRanges for the current media resource that has been played. */
     readonly played: TimeRanges;
-    /** Gets or sets the current playback position, in seconds. */
-    preload: string;
+    /** Gets or sets a value indicating what data should be preloaded, if any. */
+    preload: "none" | "metadata" | "auto" | "";
     readonly readyState: number;
     readonly remote: RemotePlayback;
     /** Returns a TimeRanges object that represents the ranges of the current media resource that can be seeked. */
diff --git a/inputfiles/comments.json b/inputfiles/comments.json
@@ -1554,7 +1554,7 @@
                             "comment": "Gets or sets the current playback position, in seconds."
                         },
                         "preload": {
-                            "comment": "Gets or sets the current playback position, in seconds."
+                            "comment": "Gets or sets a value indicating what data should be preloaded, if any."
                         },
                         "networkState": {
                             "comment": "Gets the current network activity for the element."
diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc
@@ -2792,6 +2792,15 @@
                         }
                     }
                 }
+            },
+            "HTMLMediaElement": {
+                "properties": {
+                    "property": {
+                        "preload": {
+                            "overrideType": "\"none\" | \"metadata\" | \"auto\" | \"\""
+                        }
+                    }
+                }
             }
         }
     },

Original file line number	Diff line number	Diff line change
`@@ -2792,6 +2792,15 @@`
`2792`	`2792`	`}`
`2793`	`2793`	`}`
`2794`	`2794`	`}`
	`2795`	`+ },`
	`2796`	`+ "HTMLMediaElement": {`
	`2797`	`+ "properties": {`
	`2798`	`+ "property": {`
	`2799`	`+ "preload": {`
	`2800`	`+ "overrideType": "\"none\" \| \"metadata\" \| \"auto\" \| \"\""`
	`2801`	`+ }`
	`2802`	`+ }`
	`2803`	`+ }`
`2795`	`2804`	`}`
`2796`	`2805`	`}`
`2797`	`2806`	`},`