Refactor testcases and fix formatting

Author: S Raghav

GitHubReferences.ps1

@@ -101,7 +101,7 @@ function Get-GitHubReference
 
     $params = @{
         'UriFragment' = $uriFragment
-        'Description' =  $description
+        'Description' = $description
         'AccessToken' = $AccessToken
         'TelemetryEventName' = $MyInvocation.MyCommand.Name
         'TelemetryProperties' = $telemetryProperties
@@ -167,8 +167,8 @@ function New-GitHubReference
         If not supplied here, the DefaultNoStatus configuration property value will be used.
 
     .OUTPUTS
-    [PSCustomObject]
-    Details of the git reference created. Throws an Exception if the reference already exists
+        [PSCustomObject]
+        Details of the git reference created. Throws an Exception if the reference already exists
 
     .EXAMPLE
         New-GitHubReference -OwnerName Powershell -RepositoryName PowerShellForGitHub -Reference heads/master -Sha aa218f56b14c9653891f9e74264a383fa43fefbd

Tests/GitHubReferences.Tests.ps1

@@ -34,7 +34,8 @@ function Initialize-AppVeyor
 
 #>
     [CmdletBinding()]
-    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "", Justification="Needed to configure with the stored, encrypted string value in AppVeyor.")]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "",
+    Justification="Needed to configure with the stored, encrypted string value in AppVeyor.")]
     param()
 
     if ($env:AppVeyor)
@@ -84,7 +85,8 @@ try
         Describe 'Create a new reference(branch) in repository' {
             $repositoryName = [Guid]::NewGuid()
             $repo = New-GitHubRepository -RepositoryName $repositoryName -AutoInit
-            $existingref = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master"
+            $masterRefName = "heads/master"
+            $existingref = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $masterRefName
             $sha = $existingref.object.sha
 
             Context 'On creating a valid reference in a new repository from a given SHA' {
@@ -106,18 +108,14 @@ try
             }
 
             Context 'On creating an existing reference in a new repository from a given SHA' {
-                $refName = "heads/master"
-
                 It 'Should throw an Exception' {
-                    { New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $refName -Sha $sha } | Should Throw
+                    { New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $masterRefName -Sha $sha } | Should Throw
                 }
             }
 
             Context 'On creating an existing reference in a new repository (specified by Uri) from a given SHA' {
-                $refName = "heads/master"
-
                 It 'Should throw an exception' {
-                    { New-GitHubReference -Uri $repo.svn_url -Reference $refName -Sha $sha }  | Should Throw
+                    { New-GitHubReference -Uri $repo.svn_url -Reference $masterRefName -Sha $sha }  | Should Throw
                 }
             }
 
@@ -127,34 +125,35 @@ try
         Describe 'Getting a reference(branch) from repository' {
             $repositoryName = [Guid]::NewGuid()
             $repo = New-GitHubRepository -RepositoryName $repositoryName -AutoInit
-            $refName = "refs/heads/master"
+            $masterRefName = "heads/master"
+            $randomRefName = "heads/someRandomRef"
 
             Context 'On getting a valid reference from a new repository' {
-                $reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master"
+                $reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $masterRefName
 
                 It 'Should return details of the reference' {
-                    $reference.ref | Should be $refName
+                    $reference.ref | Should be "refs/$masterRefName"
                 }
             }
 
             Context 'On getting an invalid reference from a new repository' {
-                $reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/someRandomRef"
+                $reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $randomRefName
 
                 It 'Should not return any details' {
                     $reference | Should be $null
                 }
             }
 
             Context 'On getting a valid reference using Uri from a new repository' {
-                $reference = Get-GitHubReference -Uri $repo.svn_url -Reference "heads/master"
+                $reference = Get-GitHubReference -Uri $repo.svn_url -Reference $masterRefName
 
                 It 'Should return details of the reference' {
-                    $reference.ref | Should be $refName
+                    $reference.ref | Should be "refs/$masterRefName"
                 }
             }
 
             Context 'On getting an invalid reference using Uri from a new repository' {
-                $reference = Get-GitHubReference -Uri $repo.svn_url -Reference "heads/someRandomRef"
+                $reference = Get-GitHubReference -Uri $repo.svn_url -Reference $randomRefName
 
                 It 'Should not return any details' {
                     $reference | Should be $null
@@ -167,10 +166,12 @@ try
         Describe 'Getting all references from repository' {
             $repositoryName = [Guid]::NewGuid()
             $repo = New-GitHubRepository -RepositoryName $repositoryName -AutoInit
-            $existingref = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/master"
+            $masterRefName = "heads/master"
+            $secondRefName = "heads/branch1"
+            $existingref = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $masterRefName
             $sha = $existingref.object.sha
-            New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference "heads/branch1" -Sha $sha
-            $refNames = @("refs/heads/master", "refs/heads/branch1")
+            New-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName -Reference $secondRefName -Sha $sha
+            $refNames = @("refs/$masterRefName", "refs/$secondRefName")
 
             Context 'On getting all references from a new repository' {
                 $reference = Get-GitHubReference -OwnerName $ownerName -RepositoryName $repositoryName