Tests improved, produces override bug fixed

Author: VitaliyKurokhtin

src/Microsoft.OpenApi.Readers/V2/OpenApiOperationDeserializer.cs

@@ -136,6 +136,9 @@ internal static OpenApiOperation LoadOperation(ParseNode node)
                 ProcessProduces(node.CheckMapNode("responses"), response, node.Context);
             }
 
+            // Reset so that it's not picked up later
+            node.Context.SetTempStorage(TempStorageKeys.OperationProduces, null);
+
             return operation;
         }
 

test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiDocumentTests.cs

@@ -179,6 +179,7 @@ public void ShouldParseProducesInAnyOrder()
                         }
                     }
                 };
+
                 var errorSchema = new OpenApiSchema()
                 {
                     Properties = new Dictionary<string, OpenApiSchema>()
@@ -206,6 +207,7 @@ public void ShouldParseProducesInAnyOrder()
                         Id = "Error"
                     }
                 };
+
                 foreach (var operation in doc.Paths["/items"].Operations)
                 {
                     Assert.Equal(2, operation.Value.Responses.Count);
@@ -215,37 +217,30 @@ public void ShouldParseProducesInAnyOrder()
                         new OpenApiResponse()
                         {
                             Description = "An OK response",
-                            Content =
-                            {
-                                ["application/json"] = new OpenApiMediaType()
-                                {
-                                    Schema = successSchema,
-                                },
-                                ["application/xml"] = new OpenApiMediaType()
-                                {
-                                    Schema = successSchema,
-                                }
-                            }
+                            Content = GetMediaTypes(successSchema, operation.Key != OperationType.Post)
                         });
 
                     var errorResponse = operation.Value.Responses["default"];
                     errorResponse.ShouldBeEquivalentTo(
                         new OpenApiResponse()
                         {
                             Description = "An error response",
-                            Content =
-                            {
-                                ["application/json"] = new OpenApiMediaType()
-                                {
-                                    Schema = errorSchema,
-                                },
-                                ["application/xml"] = new OpenApiMediaType()
-                                {
-                                    Schema = errorSchema,
-                                }
-                            }
+                            Content = GetMediaTypes(errorSchema, operation.Key != OperationType.Post)
                         });
                 }
+
+                IDictionary<string, OpenApiMediaType> GetMediaTypes(OpenApiSchema schema, bool includeXml)
+                {
+                    var mediaTypes = new Dictionary<string, OpenApiMediaType>
+                    {
+                        ["application/json"] = new OpenApiMediaType() { Schema = schema }
+                    };
+                    if (includeXml)
+                    {
+                        mediaTypes["application/xml"] = new OpenApiMediaType() { Schema = schema };
+                    }
+                    return mediaTypes;
+                }
             }
         }
 

test/Microsoft.OpenApi.Readers.Tests/V2Tests/Samples/twoResponses.json

@@ -78,8 +78,7 @@
         }
     },
     "produces": [
-        "application/json",
-        "application/xml"
+        "application/json"
     ],
     "definitions": {
         "Item": {