review comments

Author: mrm9084

featuremanagement/_time_window_filter/_models.py

@@ -76,11 +76,10 @@ def __init__(self, pattern_data: Dict[str, Any]):
         self.interval = pattern_data.get("Interval", 1)
         if self.interval <= 0:
             raise ValueError("The interval must be greater than 0.")
-        # Days of the week are represented as a list of strings of there names.
+        # Days of the week are represented as a list of strings of their names.
         days_of_week_str = pattern_data.get("DaysOfWeek", [])
 
         # Days of the week are represented as a list of integers from 0 to 6.
-        # 0 = Sunday, 1 = Monday, ..., 6 = Saturday
         self.days_of_week = []
         for day in days_of_week_str:
             self.days_of_week.append(self.days.index(day))

featuremanagement/_time_window_filter/_recurrence_validator.py

@@ -111,7 +111,7 @@ def _is_duration_compliant_with_days_of_week(pattern: RecurrencePattern, start:
     # Get the date of first day of the week
     today = datetime.now()
     first_day_of_week = pattern.first_day_of_week
-    offset = _get_passed_week_days(today.weekday(), first_day_of_week)
+    offset = _get_passed_week_days((today.weekday() + 1) % 7, first_day_of_week)
     first_date_of_week = today - timedelta(days=offset)
     sorted_days_of_week = _sort_days_of_week(days_of_week, first_day_of_week)
 
@@ -144,8 +144,8 @@ def _is_duration_compliant_with_days_of_week(pattern: RecurrencePattern, start:
 def _get_passed_week_days(current_day: int, first_day_of_week: int) -> int:
     """
     Get the number of days passed since the first day of the week.
-    :param int current_day: The current day of the week, where Monday == 0 ... Sunday == 6.
-    :param int first_day_of_week: The first day of the week (0-6), where Monday == 0 ... Sunday == 6.
+    :param int current_day: The current day of the week, where Sunday == 0 ... Saturday == 6.
+    :param int first_day_of_week: The first day of the week (0-6), where Sunday == 0 ... Saturday == 6.
     :return: The number of days passed since the first day of the week.
     :rtype: int
     """

featuremanagement/_time_window_filter/conversiontest.py

@@ -5,7 +5,7 @@
 # -------------------------------------------------------------------------
 from datetime import timedelta, datetime
 import pytest
-from time_window_filter.recurrence_util import (
+from .recurrence_util import (
     valid_daily_recurrence,
     valid_daily_end_date_recurrence,
     valid_no_end_range,