Skip to content

Commit f429fc5

Browse files
committed
num_of_occurrences > 0
1 parent 3b39585 commit f429fc5

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

featuremanagement/_time_window_filter/_models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ def __init__(self, range_data: Dict[str, Any]):
110110
# Python 3.9 and earlier throw TypeError if the string is not in RFC 2822 format.
111111
raise ValueError(f"Invalid value for EndDate: {end_date_str}") from e
112112
self.num_of_occurrences = range_data.get("NumberOfOccurrences", math.pow(2, 63) - 1)
113-
if self.num_of_occurrences < 0:
114-
raise ValueError("The number of occurrences must be greater than or equal to 0.")
113+
if self.num_of_occurrences <= 0:
114+
raise ValueError("The number of occurrences must be greater than 0.")
115115

116116

117117
class Recurrence: # pylint: disable=too-few-public-methods

tests/time_window_filter/test_time_window_filter_models.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,12 @@ def test_recurrence_range():
9393
try:
9494
range = RecurrenceRange({"Type": "NoEnd", "NumberOfOccurrences": -1})
9595
except ValueError as e:
96-
assert str(e) == "The number of occurrences must be greater than or equal to 0."
96+
assert str(e) == "The number of occurrences must be greater than 0."
97+
98+
try:
99+
range = RecurrenceRange({"Type": "NoEnd", "NumberOfOccurrences": 0})
100+
except ValueError as e:
101+
assert str(e) == "The number of occurrences must be greater than 0."
97102

98103
try:
99104
range = RecurrenceRange({"Type": "EndDate", "EndDate": "InvalidDate"})

0 commit comments

Comments
 (0)