added tests fixed max int

Author: mrm9084

featuremanagement/_time_window_filter/_models.py

@@ -3,7 +3,6 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # -------------------------------------------------------------------------
-import math
 from enum import Enum
 from typing import Dict, Any, Optional, List
 from datetime import datetime
@@ -80,10 +79,12 @@ def __init__(self, pattern_data: Dict[str, Any]):
         days_of_week_str = pattern_data.get("DaysOfWeek", [])
 
         # Days of the week are represented as a list of integers from 0 to 6.
-        self.days_of_week = []
+        self.days_of_week: List[int] = []
         for day in days_of_week_str:
             if day not in self.days:
                 raise ValueError(f"Invalid value for DaysOfWeek: {day}")
+            if self.days.index(day) in self.days_of_week:
+                raise ValueError(f"Duplicate day of the week found: {day}")
             self.days_of_week.append(self.days.index(day))
         if pattern_data.get("FirstDayOfWeek") and pattern_data.get("FirstDayOfWeek") not in self.days:
             raise ValueError(f"Invalid value for FirstDayOfWeek: {pattern_data.get('FirstDayOfWeek')}")
@@ -109,7 +110,7 @@ def __init__(self, range_data: Dict[str, Any]):
             except TypeError as e:
                 # Python 3.9 and earlier throw TypeError if the string is not in RFC 2822 format.
                 raise ValueError(f"Invalid value for EndDate: {end_date_str}") from e
-        self.num_of_occurrences = range_data.get("NumberOfOccurrences", 2 ** 63 - 1)
+        self.num_of_occurrences = range_data.get("NumberOfOccurrences", 2**63 - 1)
         if self.num_of_occurrences <= 0:
             raise ValueError("The number of occurrences must be greater than 0.")
 

tests/time_window_filter/test_recurrence_validator.py

@@ -213,3 +213,109 @@ def test_sort_days_of_week():
     days_of_week = [1]  # Tuesday
     sorted_days = _sort_days_of_week(days_of_week, 0)
     assert sorted_days == [1]
+
+
+def test_validate_settings_invalid_days_of_week():
+    with pytest.raises(ValueError, match="Invalid value for DaysOfWeek: Thor's Day"):
+        validate_settings(
+            Recurrence(
+                {
+                    "Pattern": {
+                        "Type": "Weekly",
+                        "Interval": 1,
+                        "DaysOfWeek": ["Thor's Day"],
+                        "FirstDayOfWeek": "Monday",
+                    },
+                    "Range": valid_no_end_range(),
+                }
+            ),
+            START,
+            END,
+        )
+    with pytest.raises(ValueError, match="Required parameter: Recurrence.Pattern.DaysOfWeek"):
+        validate_settings(
+            Recurrence(
+                {
+                    "Pattern": {
+                        "Type": "Weekly",
+                        "Interval": 1,
+                        "DaysOfWeek": [],
+                        "FirstDayOfWeek": "Monday",
+                    },
+                    "Range": valid_no_end_range(),
+                }
+            ),
+            START,
+            END,
+        )
+
+
+def test_validate_settings_invalid_days_of_week_duplicate():
+    with pytest.raises(ValueError, match="Duplicate day of the week found: Monday"):
+        validate_settings(
+            Recurrence(
+                {
+                    "Pattern": {
+                        "Type": "Weekly",
+                        "Interval": 1,
+                        "DaysOfWeek": ["Monday", "Monday"],
+                        "FirstDayOfWeek": "Monday",
+                    },
+                    "Range": valid_no_end_range(),
+                }
+            ),
+            START,
+            END,
+        )
+
+
+def test_validate_settings_invalid_end_date_format():
+    with pytest.raises(ValueError, match="Invalid value for EndDate: invalid-date-format"):
+        validate_settings(
+            Recurrence(
+                {
+                    "Pattern": valid_daily_pattern(),
+                    "Range": {
+                        "Type": "EndDate",
+                        "EndDate": "invalid-date-format",
+                        "NumberOfOccurrences": 10,
+                    },
+                }
+            ),
+            START,
+            END,
+        )
+
+
+def test_validate_settings_boundary_condition_ten_years():
+    end = START + timedelta(days=3650)  # Exactly 10 years
+    recurrence = Recurrence(
+        {
+            "Pattern": {
+                "Type": "Daily",
+                "Interval": 3651,  # Interval greater than the time window length
+                "DaysOfWeek": ["Monday", "Tuesday", "Wednesday", "Thursday", "Friday"],
+                "FirstDayOfWeek": "Sunday",
+            },
+            "Range": valid_no_end_range(),
+        }
+    )
+    validate_settings(recurrence, START, end)
+    recurrence = Recurrence(
+        {
+            "Pattern": {
+                "Type": "Daily",
+                "Interval": 3652,  # Interval greater than the time window length
+                "DaysOfWeek": ["Monday", "Tuesday", "Wednesday", "Thursday", "Friday"],
+                "FirstDayOfWeek": "Sunday",
+            },
+            "Range": valid_no_end_range(),
+        }
+    )
+    with pytest.raises(ValueError, match="Time window duration exceeds ten years: end"):
+        validate_settings(recurrence, START, START + timedelta(days=3652))
+
+
+def test_validate_settings_boundary_condition_interval():
+    end = START + timedelta(days=1)  # Exactly matches the interval duration for daily recurrence
+    validate_settings(valid_daily_recurrence(), START, end)

tests/time_window_filter/test_time_window_filter_models.py

@@ -73,7 +73,7 @@ def test_recurrence_pattern():
 
 
 def test_recurrence_range():
-    max_occurrences = math.pow(2, 63) - 1
+    max_occurrences = 2**63 - 1
 
     range = RecurrenceRange({"Type": "NoEnd"})
     assert range.type == RecurrenceRangeType.NO_END