From da0f96818716ecc721af57455b1ea4f7da4cbc80 Mon Sep 17 00:00:00 2001 From: Zhiyuan Liang Date: Fri, 7 Feb 2025 15:06:27 +0800 Subject: [PATCH 1/3] use commonjs for node example --- .../README.md | 2 +- .../README.md | 17 ++++++++--------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/feature-management-applicationinsights-browser/README.md b/src/feature-management-applicationinsights-browser/README.md index 61622d7..bf04bf0 100644 --- a/src/feature-management-applicationinsights-browser/README.md +++ b/src/feature-management-applicationinsights-browser/README.md @@ -12,7 +12,7 @@ import { FeatureManager, ConfigurationObjectFeatureFlagProvider } from "@microso import { createTelemetryPublisher, trackEvent } from "@microsoft/feature-management-applicationinsights-browser"; const appInsights = new ApplicationInsights({ config: { - connectionString: CONNECTION_STRING + connectionString: "" }}); appInsights.loadAppInsights(); diff --git a/src/feature-management-applicationinsights-node/README.md b/src/feature-management-applicationinsights-node/README.md index ef4d9cb..b14affc 100644 --- a/src/feature-management-applicationinsights-node/README.md +++ b/src/feature-management-applicationinsights-node/README.md @@ -1,6 +1,6 @@ -# Microsoft Feature Management Application Insights Plugin for Node +# Microsoft Feature Management Application Insights Plugin for Browser -Feature Management Application Insights Plugin for Node provides a solution for sending feature flag evaluation events produced by the Feature Management library. +Feature Management Application Insights Plugin for Browser provides a solution for sending feature flag evaluation events produced by the Feature Management library. ## Getting Started @@ -11,22 +11,21 @@ Feature Management Application Insights Plugin for Node provides a solution for ### Usage ``` javascript -import appInsights from "applicationinsights"; -import { FeatureManager, ConfigurationObjectFeatureFlagProvider } from "@microsoft/feature-management"; -import { createTelemetryPublisher, trackEvent } from "@microsoft/feature-management-applicationinsights-node"; +const appInsights = require("applicationinsights"); +appInsights.setup(process.env.APPINSIGHTS_CONNECTION_STRING).start(); -appInsights.setup(CONNECTION_STRING) - .start(); +const { FeatureManager, ConfigurationObjectFeatureFlagProvider } = require("@microsoft/feature-management"); +const { createTelemetryPublisher, trackEvent } = require("@microsoft/feature-management-applicationinsights-node"); const publishTelemetry = createTelemetryPublisher(appInsights.defaultClient); const provider = new ConfigurationObjectFeatureFlagProvider(jsonObject); const featureManager = new FeatureManager(provider, {onFeatureEvaluated: publishTelemetry}); // FeatureEvaluation event will be emitted when a feature flag is evaluated -featureManager.getVariant("TestFeature", {userId : TARGETING_ID}).then((variant) => { /* do something*/ }); +featureManager.getVariant("TestFeature", {userId : ""}).then((variant) => { /* do something*/ }); // Emit a custom event with targeting id attached. -trackEvent(appInsights.defaultClient, TARGETING_ID, {name: "TestEvent"}); +trackEvent(appInsights.defaultClient, "", {name: "TestEvent"}); ``` ## Contributing From 6d24b76c51cd69926ded385859f1fcde21e3a0c0 Mon Sep 17 00:00:00 2001 From: Zhiyuan Liang Date: Fri, 7 Feb 2025 15:07:41 +0800 Subject: [PATCH 2/3] fix typo --- src/feature-management-applicationinsights-node/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/feature-management-applicationinsights-node/README.md b/src/feature-management-applicationinsights-node/README.md index b14affc..a521d6e 100644 --- a/src/feature-management-applicationinsights-node/README.md +++ b/src/feature-management-applicationinsights-node/README.md @@ -1,6 +1,6 @@ -# Microsoft Feature Management Application Insights Plugin for Browser +# Microsoft Feature Management Application Insights Plugin for Node -Feature Management Application Insights Plugin for Browser provides a solution for sending feature flag evaluation events produced by the Feature Management library. +Feature Management Application Insights Plugin for Node provides a solution for sending feature flag evaluation events produced by the Feature Management library. ## Getting Started From e20288d90b6ebb12a9373b7a88b05f43f202d82c Mon Sep 17 00:00:00 2001 From: Zhiyuan Liang Date: Fri, 7 Feb 2025 15:09:20 +0800 Subject: [PATCH 3/3] update --- src/feature-management-applicationinsights-node/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/src/feature-management-applicationinsights-node/README.md b/src/feature-management-applicationinsights-node/README.md index a521d6e..bdef2f6 100644 --- a/src/feature-management-applicationinsights-node/README.md +++ b/src/feature-management-applicationinsights-node/README.md @@ -7,6 +7,7 @@ Feature Management Application Insights Plugin for Node provides a solution for ### Prerequisites - Node.js LTS version +- `applicationinsights` SDK v2(classic) ### Usage