update

Author: zhiyuanliang-ms

.github/workflows/ci.yml

@@ -1,4 +1,4 @@
-name: FeatureManagement-JavaScriptProvider CI
+name: FeatureManagement-JavaScript CI
 
 on:
   push:

sdk/feature-management-applicationinsights-browser/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/feature-management-applicationinsights-browser",
-  "version": "2.0.0-preview.1",
+  "version": "2.0.0-preview.2",
   "description": "Feature Management Application Insights Plugin for Browser provides a solution for sending feature flag evaluation events produced by the Feature Management library.",
   "main": "./dist/umd/index.js",
   "module": "./dist/esm/index.js",
@@ -42,7 +42,7 @@
   },
   "dependencies": {
     "@microsoft/applicationinsights-web": "^3.3.2",
-    "@microsoft/feature-management": "1.0.0-preview.1"
+    "@microsoft/feature-management": "2.0.0-preview.2"
   }
 }
 

sdk/feature-management-applicationinsights-browser/package.json

@@ -5,6 +5,16 @@ import { EvaluationResult, VariantAssignmentReason } from "@microsoft/feature-ma
 import { ApplicationInsights, IEventTelemetry } from "@microsoft/applicationinsights-web";
 import { EVALUATION_EVENT_VERSION } from "./version.js";
 
+const VERSION = "Version";
+const FEATURE_NAME = "FeatureName";
+const ENABLED = "Enabled";
+const TARGETING_ID = "TargetingId";
+const VARIANT = "Variant";
+const VARIANT_ASSIGNMENT_REASON = "VariantAssignmentReason";
+const DEFAULT_WHEN_ENABLED = "DefaultWhenEnabled";
+const VARIANT_ASSIGNMENT_PERCENTAGE = "VariantAssignmentPercentage";
+const FEATURE_EVALUATION_EVENT_NAME = "FeatureEvaluation";
+
 /**
  * Creates a telemetry publisher that sends feature evaluation events to Application Insights.
  * @param client The Application Insights telemetry client.
@@ -17,17 +27,17 @@ export function createTelemetryPublisher(client: ApplicationInsights): (event: E
         }
 
         const eventProperties = {
-            "Version": EVALUATION_EVENT_VERSION,
-            "FeatureName": event.feature ? event.feature.id : "",
-            "Enabled": event.enabled.toString(),
+            [VERSION]: EVALUATION_EVENT_VERSION,
+            [FEATURE_NAME]: event.feature ? event.feature.id : "",
+            [ENABLED]: event.enabled.toString(),
             // Ensure targetingId is string so that it will be placed in customDimensions
-            "TargetingId": event.targetingId ? event.targetingId.toString() : "",
-            "Variant": event.variant ? event.variant.name : "",
-            "VariantAssignmentReason": event.variantAssignmentReason,
+            [TARGETING_ID]: event.targetingId ? event.targetingId.toString() : "",
+            [VARIANT]: event.variant ? event.variant.name : "",
+            [VARIANT_ASSIGNMENT_REASON]: event.variantAssignmentReason,
         };
 
         if (event.feature.allocation?.default_when_enabled) {
-            eventProperties["DefaultWhenEnabled"] = event.feature.allocation.default_when_enabled;
+            eventProperties[DEFAULT_WHEN_ENABLED] = event.feature.allocation.default_when_enabled;
         }
 
         if (event.variantAssignmentReason === VariantAssignmentReason.DefaultWhenEnabled) {
@@ -37,7 +47,7 @@ export function createTelemetryPublisher(client: ApplicationInsights): (event: E
                     percentileAllocationPercentage += percentile.to - percentile.from;
                 }
             }
-            eventProperties["VariantAssignmentPercentage"] = (100 - percentileAllocationPercentage).toString();
+            eventProperties[VARIANT_ASSIGNMENT_PERCENTAGE] = (100 - percentileAllocationPercentage).toString();
         }
         else if (event.variantAssignmentReason === VariantAssignmentReason.Percentile) {
             let percentileAllocationPercentage = 0;
@@ -48,7 +58,7 @@ export function createTelemetryPublisher(client: ApplicationInsights): (event: E
                     }
                 }
             }
-            eventProperties["VariantAssignmentPercentage"] = percentileAllocationPercentage.toString();
+            eventProperties[VARIANT_ASSIGNMENT_PERCENTAGE] = percentileAllocationPercentage.toString();
         }
 
         const metadata = event.feature.telemetry?.metadata;
@@ -60,7 +70,7 @@ export function createTelemetryPublisher(client: ApplicationInsights): (event: E
             }
         }
 
-        client.trackEvent({ name: "FeatureEvaluation" }, eventProperties);
+        client.trackEvent({ name: FEATURE_EVALUATION_EVENT_NAME }, eventProperties);
     };
 }
 
@@ -77,6 +87,6 @@ export function createTelemetryPublisher(client: ApplicationInsights): (event: E
 export function trackEvent(client: ApplicationInsights, targetingId: string, event: IEventTelemetry, customProperties?: {[key: string]: any}): void {
     const properties = customProperties ? { ...customProperties } : {};
     // Ensure targetingId is string so that it will be placed in customDimensions
-    properties["TargetingId"] = targetingId?.toString();
+    properties[TARGETING_ID] = targetingId ? targetingId.toString() : "";
     client.trackEvent(event, properties);
 }

sdk/feature-management-applicationinsights-browser/src/telemetry.ts

@@ -1,5 +1,5 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-export const VERSION = "2.0.0-preview.1";
+export const VERSION = "2.0.0-preview.2";
 export const EVALUATION_EVENT_VERSION = "1.0.0";

sdk/feature-management-applicationinsights-browser/src/version.ts

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/feature-management",
-  "version": "2.0.0-preview.1",
+  "version": "2.0.0-preview.2",
   "description": "Feature Management is a library for enabling/disabling features at runtime. Developers can use feature flags in simple use cases like conditional statement to more advanced scenarios like conditionally adding routes.",
   "main": "./dist/commonjs/index.js",
   "module": "./dist/esm/index.js",

sdk/feature-management/package-lock.json

@@ -1,4 +1,4 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-export const VERSION = "2.0.0-preview.1";
+export const VERSION = "2.0.0-preview.2";