Skip to content

Commit 6d98962

Browse files
Rename python-editor-next to python-editor-v3 (#967)
* Update links to python-editor-next repo * Update theme package which has also been renamed * Remove unused dev container and update readme
1 parent 4076dba commit 6d98962

File tree

15 files changed

+16
-42
lines changed

15 files changed

+16
-42
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ _steps:
3434
install_dependencies: &install_dependencies
3535
run: npm ci --cache .npm-cache && sudo npm config set @microbit-foundation:registry https://npm.pkg.github.com/microbit-foundation && sudo npm i -g @microbit-foundation/website-deploy-aws@0.3.0 @microbit-foundation/website-deploy-aws-config@0.4.2 @microbit-foundation/circleci-npm-package-versioner@1
3636
install_theme: &install_theme
37-
run: npm config set @microbit-foundation:registry https://npm.pkg.github.com/microbit-foundation && npm install --no-save @microbit-foundation/python-editor-next-microbit@0.1.0-dev.180
37+
run: npm config set @microbit-foundation:registry https://npm.pkg.github.com/microbit-foundation && npm install --no-save @microbit-foundation/python-editor-v3-microbit@0.1.0-dev.183
3838
update_version: &update_version
3939
run: npm run ci:update-version
4040
build: &build

.devcontainer/Dockerfile

Lines changed: 0 additions & 3 deletions
This file was deleted.

.devcontainer/devcontainer.json

Lines changed: 0 additions & 19 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ possible through contributions of companies and individuals around the world.
44
This project is managed on GitHub, and the best way to contribute is to jump in
55
and fix/file issues.
66

7-
https://github.com/microbit-foundation/python-editor-next
7+
https://github.com/microbit-foundation/python-editor-v3
88

99
Significant features are best discussed first to make sure everyone is agreed
1010
on the best direction.

README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,9 @@ CodeMirror 6 has [great documentation](https://codemirror.net/6/docs/). The [sys
2727

2828
The project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
2929

30-
If you use Visual Studio Code you might find the devcontainer included in this repository a useful option to get an automatically configured development environment. [Find out more about containers and Visual Studio Code](https://code.visualstudio.com/docs/remote/containers).
31-
3230
## Deployments
3331

34-
The editor is deployed by [CircleCI](https://circleci.com/gh/microbit-foundation/python-editor-next).
32+
The editor is deployed by [CircleCI](https://circleci.com/gh/microbit-foundation/python-editor-v3).
3533

3634
The `main` branch is deployed to https://stage-python-editor-next.microbit.org/ on each commit.
3735

@@ -46,8 +44,6 @@ For custom deployments, note that the educational content in the sidebar is curr
4644
3. Install the dependencies via `npm install`.
4745
4. Choose from the NPM scripts documented below.
4846

49-
If you're using the devcontainer with Visual Studio Code then the "Clone a repository from GitHub in a Container Volume" action will address steps 1 through 3.
50-
5147
### `npm start`
5248

5349
Runs the app in the development mode.\

craco.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const path = require("path");
77
const fs = require("fs");
88

99
// Support optionally pulling in external branding if the module is installed.
10-
const theme = "@microbit-foundation/python-editor-next-microbit";
10+
const theme = "@microbit-foundation/python-editor-v3-microbit";
1111
const external = `node_modules/${theme}`;
1212
const internal = "src/deployment/default";
1313

src/App.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
}
2525

2626
:root {
27-
/* Seems to fix a Safari glitch: https://github.com/microbit-foundation/python-editor-next/issues/369 */
27+
/* Seems to fix a Safari glitch: https://github.com/microbit-foundation/python-editor-v3/issues/369 */
2828
font-size: 16px;
2929
}
3030

src/device/webusb.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class MicrobitWebUSBConnection
9494
// If serial is in progress when the page unloads with V1 DAPLink 0254 or V2 0255
9595
// then it'll fail to reconnect with mismatched command/response errors.
9696
// Try hard to disconnect as a workaround.
97-
// https://github.com/microbit-foundation/python-editor-next/issues/89
97+
// https://github.com/microbit-foundation/python-editor-v3/issues/89
9898
this.unloading = true;
9999
this.stopSerialInternal();
100100
// The user might stay on the page if they have unsaved changes and there's another beforeunload listener.
@@ -343,7 +343,7 @@ export class MicrobitWebUSBConnection
343343
return this.withEnrichedErrors(async () => {
344344
if (this.connection) {
345345
// Using WebUSB/DAPJs we're limited to 64 byte packet size with a two byte header.
346-
// https://github.com/microbit-foundation/python-editor-next/issues/215
346+
// https://github.com/microbit-foundation/python-editor-v3/issues/215
347347
const maxSerialWrite = 62;
348348
let start = 0;
349349
while (start < data.length) {

src/e2e/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ export class App {
493493
const content = await this.focusEditorContent();
494494
// The short delay seems to improve reliability triggering autocomplete.
495495
// Previously finding autocomplete options failed approx 1 in 30 times.
496-
// https://github.com/microbit-foundation/python-editor-next/issues/419
496+
// https://github.com/microbit-foundation/python-editor-v3/issues/419
497497
return content.type(text, { delay: 10 });
498498
}
499499

src/editor/codemirror/CodeMirrorView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const CodeMirrorView = ({ value, ...props }: CodeMirrorViewProps) => {
3838
".cm-scroller": {
3939
// Reduced from 1.4 to a value that gets integral line height on Safari with the 16px
4040
// font size used in Reference to sidestep https://bugs.webkit.org/show_bug.cgi?id=225695
41-
// See https://github.com/microbit-foundation/python-editor-next/issues/369
41+
// See https://github.com/microbit-foundation/python-editor-v3/issues/369
4242
lineHeight: 1.375,
4343
},
4444
}),

0 commit comments

Comments
 (0)