Define STAGE before calculating PUBLIC_URL. (#1088)

Fixes GH actions build.

Author: microbit-matt-hillsdon

.github/workflows/build.yml

@@ -39,7 +39,8 @@ jobs:
       - run: npm install --no-save @microbit-foundation/python-editor-v3-microbit@0.1.0-dev.198 @microbit-foundation/website-deploy-aws@0.3.0 @microbit-foundation/website-deploy-aws-config@0.7.0 @microbit-foundation/circleci-npm-package-versioner@1
         env:
           NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - run: node ./bin/print-ci-env.js >> $GITHUB_ENV
+      - run: node ./bin/print-ci-env-stage.js >> $GITHUB_ENV
+      - run: node ./bin/print-ci-env-public-url.js >> $GITHUB_ENV
       - run: npm run ci:update-version
       - run: npm run ci
       - run: mkdir -p /tmp/app${PUBLIC_URL} && cp -r build/* /tmp/app${PUBLIC_URL} && npx serve --no-clipboard -l 3000 /tmp/app &

bin/print-ci-env-public-url.js

@@ -0,0 +1,7 @@
+#!/usr/bin/env node
+// STAGE must be defined before this is imported
+const { bucketPrefix } = require("../deployment");
+
+// Two env vars as PUBLIC_URL seems to be blank when running jest even if we set it.
+console.log(`PUBLIC_URL=/${bucketPrefix}/`);
+console.log(`E2E_PUBLIC_URL=/${bucketPrefix}/`);

bin/print-ci-env.js renamed to bin/print-ci-env-stage.js

@@ -1,5 +1,4 @@
 #!/usr/bin/env node
-const { bucketPrefix } = require("../deployment");
 const ref = process.env.GITHUB_REF;
 const eventName = process.env.GITHUB_EVENT_NAME;
 
@@ -16,6 +15,3 @@ if (ref === "refs/heads/main") {
 
 console.log(`STAGE=${stage}`);
 console.log(`REACT_APP_STAGE=${stage}`);
-// Two env vars as PUBLIC_URL seems to be blank when running jest even if we set it.
-console.log(`PUBLIC_URL=/${bucketPrefix}/`);
-console.log(`E2E_PUBLIC_URL=/${bucketPrefix}/`);