Commit 379cd94
committed
Do not assume shell for platform
win32 does not necessarily mean `cmd.exe`
as well as others does not mean `sh`.
Problem is, that previous functions, like
s:escape_cword() do respect `shell` e.g.
with `shellescape()`, but passing
the arguments to `job_start()` / jobstart()
does ignore `shell`.
This leads to trouble. E.g. I use `fish`,
where `shellescape()` escapes `\`, which means
if <cword> / -cword is used (e.g. `Aword`),
s:escape_cword() results to `\\bAword\\b`
(which is correct), but this string
is then passed to `jobstart()` executed by
`sh`, which does not share the same escaping rules1 parent 2b93535 commit 379cd94
1 file changed
+1
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
898 | 898 | | |
899 | 899 | | |
900 | 900 | | |
901 | | - | |
902 | | - | |
903 | | - | |
904 | | - | |
905 | | - | |
906 | | - | |
| 901 | + | |
907 | 902 | | |
908 | 903 | | |
909 | 904 | | |
| |||
0 commit comments