TEST: Provide access to active transaction in callback provided to OpenDbRequestBuilder::with_on_upgrade_needed{_fut}
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion when it is dropped
…pgrade needed callback BREAKING CHANGE: The callback provided to `OpenDbRequestBuilder::with_on_upgrade_needed` must now accept a reference to a `Transaction` rather than a `Database`. For most cases, existing code can be made compatible by calling `Transaction::database` in order to get access to the underlying database. The caveat is that the `Transaction::database` provides a reference, rather than ownership of the `Database`.
…back BREAKING CHANGE: `AsyncFnOnce` was stabilized in version 1.85.0 of Rust, so the MSRV had to be bumped to accommodate this. Additionally, synchronous closures that use `async move` blocks are not drop-in replacements for `async` closures, so users of `OpenDbRequestBuilder::with_on_upgrade_needed_fut` will have to make minor changes to their invocations.
…sync upgrade needed callback BREAKING CHANGE: The callback provided to `OpenDbRequestBuilder::with_on_upgrade_needed_fut` must now accept a reference to a `Transaction` rather than a `Database`. For most cases, existing code can be made compatible by calling `Transaction::database` in order to get access to the underlying database. The caveat is that the `Transaction::database` provides a reference, rather than ownership of the `Database`.
mgoldenberg
force-pushed
the
expose-version-change-transaction-changes
branch
from
282fb69 to
4047942
Compare
mgoldenberg
force-pushed
the
expose-version-change-transaction-changes
branch
from
3d1b196 to
7322370
Compare
For details on lifetime syntax lint, see https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint.
For some reason, calling `TransactionSys::do_commit` in the `Drop` implementation of `Transaction` causes tests in a headless Chrome browser to hang, even though they pass in a non-headless context. Ultimately, the default behavior on the JavaScript end is for the transaction to be committed, so it is safe to exclude this action.
mgoldenberg
force-pushed
the
expose-version-change-transaction-changes
branch
from
7322370 to
9571c47
Compare
mgoldenberg
changed the title
OpenDbRequestBuilder::with_on_upgrade_needed{_fut}
mgoldenberg
changed the title
OpenDbRequestBuilder::with_on_upgrade_needed{_fut} OpenDbRequestBuilder::with_on_upgrade_needed{_fut}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for checking that all C.I. tests are passing. The real pull request exists in Alorel#72.