Merge pull request #416 from mglaman/gh408

Allow \Drupal calls in StreamWrapperInterface

Author: mglaman

src/Rules/Drupal/GlobalDrupalDependencyInjectionRule.php

@@ -32,7 +32,6 @@ public function processNode(Node $node, Scope $scope): array
             throw new ShouldNotHappenException();
         }
 
-        $classReflection = $scopeClassReflection->getNativeReflection();
         $allowed_list = [
             // Ignore tests.
             'PHPUnit\Framework\Test',
@@ -45,11 +44,14 @@ public function processNode(Node $node, Scope $scope): array
             // Entities don't use services for now
             // @see https://www.drupal.org/project/drupal/issues/2913224
             'Drupal\Core\Entity\EntityInterface',
+            // Stream wrappers are only registered as a service for their tags
+            // and cannot use dependency injection. Function calls like
+            // file_exists, stat, etc. will construct the class directly.
+            'Drupal\Core\StreamWrapper\StreamWrapperInterface',
         ];
-        $implemented_interfaces = $classReflection->getInterfaceNames();
 
         foreach ($allowed_list as $item) {
-            if (in_array($item, $implemented_interfaces, true)) {
+            if ($scopeClassReflection->implementsInterface($item)) {
                 return [];
             }
         }

tests/src/Rules/GlobalDrupalDependencyInjectionRuleTest.php

@@ -22,6 +22,10 @@ public function testRule(string $path, array $errorMessages): void
 
     public function resultData(): \Generator
     {
+        yield [
+            __DIR__ . '/data/drupal-static.php',
+            [],
+        ];
         yield [
             __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/UsesDeprecatedUrlFunction.php',
             [

tests/src/Rules/data/drupal-static.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace DrupalStatic;
+
+$class = new class () extends \Drupal\Core\StreamWrapper\LocalStream {
+
+    public function getDirectoryPath()
+    {
+        return \Drupal::root();
+    }
+
+    public function getName()
+    {
+    }
+
+    public function getDescription()
+    {
+    }
+
+    public function getExternalUrl()
+    {
+    }
+};