ContentEntityDeleteForm has @internal removed in 9.4.x as well

mglaman · mglaman · commit 05ebd4d55c7f · 2022-05-20T13:06:21.000-05:00
diff --git a/tests/src/Rules/ClassExtendsInternalClassRuleTest.php b/tests/src/Rules/ClassExtendsInternalClassRuleTest.php
@@ -41,10 +41,10 @@ public static function tearDownAfterClass(): void
      */
     public function testRule(string $path, array $errorMessages): void
     {
-        [$version] = explode('.', \Drupal::VERSION, 2);
-        if ($version === '10'
+        [$version, $minor] = explode('.', \Drupal::VERSION, 3);
+        if (($version === '10' || ($version === '9' && (int) $minor >= 4))
             && $path === __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/Form/ExtendsContentEntityDeleteForm.php') {
-                self::markTestSkipped('@internal was removed in 10.0.x');
+                self::markTestSkipped('@internal was removed in 10.0.x and 9.4.x');
         }
         $this->analyse([$path], $errorMessages);
     }

Original file line number	Diff line number	Diff line change
`@@ -41,10 +41,10 @@ public static function tearDownAfterClass(): void`
`41`	`41`	`*/`
`42`	`42`	`public function testRule(string $path, array $errorMessages): void`
`43`	`43`	`{`
`44`		`- [$version] = explode('.', \Drupal::VERSION, 2);`
`45`		`- if ($version === '10'`
	`44`	`+ [$version, $minor] = explode('.', \Drupal::VERSION, 3);`
	`45`	`+ if (($version === '10' \|\| ($version === '9' && (int) $minor >= 4))`
`46`	`46`	`&& $path === __DIR__ . '/../../fixtures/drupal/modules/phpstan_fixtures/src/Form/ExtendsContentEntityDeleteForm.php') {`
`47`		`- self::markTestSkipped('@internal was removed in 10.0.x');`
	`47`	`+ self::markTestSkipped('@internal was removed in 10.0.x and 9.4.x');`
`48`	`48`	`}`
`49`	`49`	`$this->analyse([$path], $errorMessages);`
`50`	`50`	`}`