refactor: use strict mode for electron app

Author: vik-13

main.ts

@@ -8,7 +8,7 @@ import { isDev } from './utils';
 import * as path from 'path';
 import * as url from 'url';
 
-let win: BrowserWindow = null;
+let win: BrowserWindow | null = null;
 
 // Save userData in separate folders for each environment.
 // Thanks to this you can use production and development versions of the app
@@ -48,8 +48,7 @@ export const menus = Menu.buildFromTemplate(menuItems);
 function createWindow(): BrowserWindow {
   Menu.setApplicationMenu(menus);
 
-  const electronScreen = screen;
-  const size = electronScreen.getPrimaryDisplay().workAreaSize;
+  const size = screen.getPrimaryDisplay().workAreaSize;
 
   // Create the browser window.
   win = new BrowserWindow({
@@ -59,7 +58,7 @@ function createWindow(): BrowserWindow {
     height: size.height,
     webPreferences: {
       nodeIntegration: true,
-      allowRunningInsecureContent: (isDev) ? true : false,
+      allowRunningInsecureContent: !!isDev,
       contextIsolation: false,  // false if you want to run 2e2 test with Spectron
       enableRemoteModule : true // true if you want to run 2e2 test  with Spectron or use remote module in renderer context (ie. Angular)
     },

src/electron/config.ts

@@ -4,12 +4,11 @@ import { readFileSync, readdirSync, writeFileSync } from 'fs';
 import { join } from 'path';
 import { app } from 'electron';
 
-
 // Handle the case when the theme is not there
 const builtInThemesMap = readdirSync(join(__dirname, '..', 'assets'))
   .filter(f => f.endsWith('.theme.json'))
   .map(f => JSON.parse(readFileSync(join(__dirname, '..', 'assets', f)).toString()))
-  .reduce((a, theme) => {
+  .reduce((a: Config['themes'], theme: Theme) => {
     a[theme.name] = theme;
     return a;
   }, {});
@@ -45,7 +44,7 @@ export const getConfig = (): Config => {
     showModules: config.showModules,
     theme: config.theme,
     themes: Object.assign(
-      themes.reduce((a, t) => {
+      themes.reduce((a: Config['themes'], t: Theme) => {
         a[t.name] = t;
         return a;
       }, {}),

src/electron/formatters/model-formatter.ts

@@ -45,11 +45,15 @@ export const getPipeMetadata = (pipe: PipeSymbol): Metadata => {
 
 export const getDirectiveMetadata = (
   dir: DirectiveSymbol | ComponentSymbol
-): Metadata => {
+): Metadata | null => {
   const meta = dir.metadata;
+  if (!meta) {
+    return null;
+  }
   const getChangeDetection = () => {
     if (dir instanceof ComponentSymbol) {
-      return dir.metadata.changeDetection;
+      // TODO: ngast doesn't export ComponentMetadata
+      return (meta as ComponentSymbol['metadata'])?.changeDetection;
     }
     return undefined;
   };

src/electron/helpers/process.ts

@@ -110,12 +110,12 @@ export type IPCResponse =
   | ToggleLibsResponse
   | ToggleModulesResponse;
 
-export interface Responder {
-  (data: IPCResponse): void;
+export interface Responder<R> {
+  (data: R): void;
 }
 
-export interface RequestHandler {
-  (request: IPCRequest, responder: Responder): void;
+export interface RequestHandler<T, R> {
+  (request: T, responder: Responder<R>): void;
 }
 
 export class ParentProcess {
@@ -127,12 +127,12 @@ export class ParentProcess {
       this.emitter.emit(request.topic, request, ((response: IPCResponse) => {
         console.log('Sending response for message:', request.topic);
         (process as any).send(response);
-      }) as Responder);
+      }) as Responder<IPCRequest>);
     });
   }
 
-  on(topic: Message, cb: RequestHandler): void {
-    this.emitter.on(topic, (request: IPCRequest, responder: Responder) => {
+  on<T extends IPCRequest, R extends IPCResponse>(topic: Message, cb: RequestHandler<T, R>): void {
+    this.emitter.on(topic, (request: T, responder: Responder<R>) => {
       try {
         cb(request, responder);
       } catch (e) {
@@ -167,9 +167,9 @@ export class SlaveProcess {
     this.emitter.on('ready', cb);
   }
 
-  send(request: IPCRequest): Promise<IPCResponse> {
+  send<R extends IPCResponse>(request: IPCRequest): Promise<R> {
     return new Promise((resolve) => {
-      this.process.once('message', (data: IPCResponse) => {
+      this.process.once('message', (data: R) => {
         console.log('Got message with topic', data.topic);
         resolve(data);
       });

src/electron/helpers/window.ts

@@ -2,6 +2,20 @@ import { app, BrowserWindow, dialog, MenuItem, MenuItemConstructorOptions, Messa
 import { Message } from "../../shared/ipc-constants";
 import { getConfig } from "../config";
 
+export enum MenuIndex {
+  Ngrev
+}
+
+export enum SubmenuIndex {
+  Themes = 0,
+  ShowLibs = 1,
+  ShowModulesOnly = 2,
+  Export = 4,
+  FitView = 6,
+  Reset = 7,
+  Quit = 8
+}
+
 export const applicationMenuTemplate = (
   themeChange: (name: string) => void,
   libsToggle: () => void,
@@ -74,8 +88,12 @@ export const applicationMenuTemplate = (
         label: "Reset",
         accelerator: "CmdOrCtrl+R",
         click() {
+          const focusedWindow: BrowserWindow | null = BrowserWindow.getFocusedWindow();
+          if (!focusedWindow) {
+            return;
+          }
           dialog
-            .showMessageBox(BrowserWindow.getFocusedWindow(), {
+            .showMessageBox(focusedWindow, {
               type: "warning",
               buttons: ["OK", "Cancel"],
               title: "Are you sure?",