defer getWarnings() after fetching resultsets.

Author: methane

connection.go

@@ -31,6 +31,7 @@ type mysqlConn struct {
 	sequence         uint8
 	parseTime        bool
 	strict           bool
+	warningCount     uint16
 }
 
 // Handles parameters set in DSN after the connection is established

driver.go

@@ -175,6 +175,10 @@ func handleAuthResult(mc *mysqlConn, oldCipher []byte) error {
 		}
 		_, err = mc.readResultOK()
 	}
+
+	if err == nil && mc.warningCount > 0 {
+		return mc.getWarnings()
+	}
 	return err
 }
 

errors.go

@@ -89,6 +89,7 @@ type MySQLWarning struct {
 }
 
 func (mc *mysqlConn) getWarnings() (err error) {
+	mc.warningCount = 0
 	rows, err := mc.Query("SHOW WARNINGS", nil)
 	if err != nil {
 		return

infile.go

@@ -175,6 +175,9 @@ func (mc *mysqlConn) handleInFileRequest(name string) (err error) {
 	// read OK packet
 	if err == nil {
 		_, err = mc.readResultOK()
+		if err == nil && mc.warningCount > 0 {
+			return mc.getWarnings()
+		}
 		return err
 	}
 

packets.go

@@ -591,10 +591,12 @@ func (mc *mysqlConn) handleOkPacket(data []byte) error {
 
 	// warning count [2 bytes]
 	if !mc.strict {
+		mc.warningCount = 0
 		return nil
 	}
 
 	pos := 1 + n + m + 2
+	mc.warningCount = binary.LittleEndian.Uint16(data[pos : pos+2])
 	if binary.LittleEndian.Uint16(data[pos:pos+2]) > 0 {
 		return mc.getWarnings()
 	}
@@ -714,7 +716,14 @@ func (rows *textRows) readRow(dest []driver.Value) error {
 		rows.mc.status = readStatus(data[3:])
 		rows.rs.done = true
 		if !rows.HasNextResultSet() {
+			mc := rows.mc
 			rows.mc = nil
+
+			if mc.strict && mc.warningCount > 0 {
+				if err := mc.getWarnings(); err != nil {
+					return err
+				}
+			}
 		}
 		return io.EOF
 	}
@@ -1100,6 +1109,9 @@ func (mc *mysqlConn) discardResults() error {
 			}
 		}
 	}
+	if mc.strict && mc.warningCount > 0 {
+		return mc.getWarnings()
+	}
 	return nil
 }