Skip to content

Sync tensordict #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sync tensordict #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torchrec/distributed/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,7 @@ def input_dist(
) -> Awaitable[Awaitable[KJTList]]:
need_permute: bool = True
if isinstance(features, TensorDict):
feature_keys = list(features.keys()) # pyre-ignore[6]
feature_keys = list(features.keys())
if self._features_order:
feature_keys = [feature_keys[i] for i in self._features_order]
need_permute = False
Expand Down
2 changes: 1 addition & 1 deletion torchrec/distributed/embeddingbag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,7 @@ def input_dist(
in advance
"""
if isinstance(features, TensorDict):
feature_keys = list(features.keys()) # pyre-ignore[6]
feature_keys = list(features.keys())
if len(self._features_order) > 0:
feature_keys = [feature_keys[i] for i in self._features_order]
self._has_features_permute = False # feature_keys are in order
Expand Down
4 changes: 2 additions & 2 deletions torchrec/distributed/test_utils/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def _validate_pooling_factor(
idlist_features, global_idlist_indices, global_idlist_lengths
)
}
global_idlist_input = TensorDict(source=dict_of_nt)
global_idlist_input = TensorDict(source=dict_of_nt) # pyre-ignore[6]

assert (
len(idscore_features) == 0
Expand Down Expand Up @@ -409,7 +409,7 @@ def _validate_pooling_factor(
local_idlist_lengths,
)
}
local_idlist_input = TensorDict(source=dict_of_nt)
local_idlist_input = TensorDict(source=dict_of_nt) # pyre-ignore[6]
assert (
len(idscore_features) == 0
), "TensorDict does not support weighted features"
Expand Down
Loading