Skip to content

Commit d047151

Browse files
Simplify output when launching MAST jobs (#543)
1 parent 4410e90 commit d047151

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.meta/mast/main.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ async def main(cfg: DictConfig, mode: str = "detached", extra_args: list = None)
6363
extra_args=extra_args or [],
6464
)
6565
await launcher.launch_mast_job()
66-
print(f"MAST job {launcher.job_name} launched successfully with client role.")
67-
print("The client is running inside MAST and will execute the training.")
6866
else:
6967
# In remote mode, we're already running inside MAST, so mount directory, init provisioner and run training
7068
mount_mnt_directory("/mnt/wsfuse")
@@ -97,7 +95,6 @@ def _main(cfg):
9795
# Override job name from CLI
9896
if args.job_name:
9997
cfg[JOB_NAME_KEY] = args.job_name
100-
print(f"Using job name: {args.job_name}")
10198
asyncio.run(main(cfg, mode=args.mode, extra_args=remaining))
10299

103100
_main() # @parse grabs the cfg from CLI

src/forge/controller/launcher.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,18 @@
1717
import monarch
1818

1919
import torchx.specs as specs
20+
21+
from forge.types import Launcher, LauncherConfig
2022
from monarch._rust_bindings.monarch_hyperactor.alloc import AllocConstraints
2123
from monarch._rust_bindings.monarch_hyperactor.channel import ChannelTransport
2224

2325
from monarch._rust_bindings.monarch_hyperactor.config import configure
2426
from monarch._src.actor.allocator import RemoteAllocator, TorchXRemoteAllocInitializer
2527
from monarch.actor import Actor, endpoint, ProcMesh
2628
from monarch.tools import commands
27-
from monarch.tools.commands import info
28-
from monarch.tools.components import hyperactor
29+
from monarch.tools.commands import create, info
2930
from monarch.tools.config import Config, Workspace
3031

31-
from forge.types import Launcher, LauncherConfig
32-
3332
_MAST_AVAILABLE = False
3433

3534
try:
@@ -259,8 +258,12 @@ async def launch_mast_job(self):
259258
),
260259
)
261260

262-
await commands.get_or_create(self.job_name, config)
263-
return server_spec
261+
job_handle = create(config, name=self.job_name)
262+
print(
263+
f"MAST job launched successfully:\n"
264+
f"\033[92mhttps://www.internalfb.com/mlhub/pipelines/runs/mast/{self.job_name}\033[0m"
265+
)
266+
return job_handle
264267

265268
def add_additional_packages(self, packages: "Packages") -> "Packages":
266269
packages.add_package("oil.oilfs:stable")

0 commit comments

Comments
 (0)