You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
`FB_COMMCHECKTHROW(...)` throws `runtime_error` for all other `bootstrap_` module use cases in Ctran except for this one, hence aligning this one.
Also, error handling today is inaccurate: This is a network problem instead of cuda-related failures, which is more suitable for `bad_alloc`. `CtranNvl`'s `bad_alloc` today is captured and reported by `mapper` as "NVL Backend not enabled" [link](https://www.internalfb.com/code/fbsource/[576c8cc42c2fe147a69380cc94ae483ee4581772]/fbcode/comms/ctran/mapper/CtranMapper.cc?lines=115-119), which is not the case for bootstrap related failures.
Reviewed By: saifhhasan
Differential Revision: D85985044
fbshipit-source-id: 0e9b995864f6902d50f92809f4eb683130bdd10c
0 commit comments