Skip to content

Commit ba55b32

Browse files
arttianezhumeta-codesync[bot]
authored andcommitted
align bootstrap operation error handling
Summary: `FB_COMMCHECKTHROW(...)` throws `runtime_error` for all other `bootstrap_` module use cases in Ctran except for this one, hence aligning this one. Also, error handling today is inaccurate: This is a network problem instead of cuda-related failures, which is more suitable for `bad_alloc`. `CtranNvl`'s `bad_alloc` today is captured and reported by `mapper` as "NVL Backend not enabled" [link](https://www.internalfb.com/code/fbsource/[576c8cc42c2fe147a69380cc94ae483ee4581772]/fbcode/comms/ctran/mapper/CtranMapper.cc?lines=115-119), which is not the case for bootstrap related failures. Reviewed By: saifhhasan Differential Revision: D85985044 fbshipit-source-id: 0e9b995864f6902d50f92809f4eb683130bdd10c
1 parent 0fa46db commit ba55b32

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

comms/ctran/backends/nvl/CtranNvl.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ CtranNvl::CtranNvl(CtranComm* comm) {
2929
myLocalRank,
3030
nLocalRanks,
3131
statex->localRankToRanks());
32-
FB_COMMCHECKGOTO(
33-
static_cast<commResult_t>(std::move(resFuture).get()), res, fail);
32+
FB_COMMCHECKTHROW(static_cast<commResult_t>(std::move(resFuture).get()));
3433

3534
this->pimpl_ = std::make_unique<Impl>();
3635
this->pimpl_->comm = comm;

0 commit comments

Comments
 (0)