Remove old registerDeviceInterface

Author: NicolasHug

src/torchcodec/_core/BetaCudaDeviceInterface.cpp

@@ -27,9 +27,8 @@ namespace facebook::torchcodec {
 
 namespace {
 
-// Register the BETA CUDA interface with 'beta' variant
 static bool g_cuda_beta = registerDeviceInterface(
-    DeviceInterfaceKey(torch::kCUDA, "beta"),
+    DeviceInterfaceKey(torch::kCUDA, /*variant=*/"beta"),
     [](const torch::Device& device) {
       return new BetaCudaDeviceInterface(device);
     });

src/torchcodec/_core/CpuDeviceInterface.cpp

@@ -10,7 +10,7 @@ namespace facebook::torchcodec {
 namespace {
 
 static bool g_cpu = registerDeviceInterface(
-    torch::kCPU,
+    DeviceInterfaceKey(torch::kCPU),
     [](const torch::Device& device) { return new CpuDeviceInterface(device); });
 
 } // namespace

src/torchcodec/_core/CudaDeviceInterface.cpp

@@ -25,8 +25,9 @@ extern "C" {
 namespace facebook::torchcodec {
 namespace {
 
-static bool g_cuda =
-    registerDeviceInterface(torch::kCUDA, [](const torch::Device& device) {
+static bool g_cuda = registerDeviceInterface(
+    DeviceInterfaceKey(torch::kCUDA),
+    [](const torch::Device& device) {
       return new CudaDeviceInterface(device);
     });
 

src/torchcodec/_core/DeviceInterface.cpp

@@ -48,13 +48,6 @@ bool registerDeviceInterface(
   return true;
 }
 
-bool registerDeviceInterface(
-    torch::DeviceType deviceType,
-    CreateDeviceInterfaceFn createInterface) {
-  return registerDeviceInterface(
-      DeviceInterfaceKey(deviceType), createInterface);
-}
-
 void validateDeviceInterface(
     const std::string device,
     const std::string variant) {

src/torchcodec/_core/DeviceInterface.h

@@ -122,13 +122,6 @@ bool registerDeviceInterface(
     const DeviceInterfaceKey& key,
     const CreateDeviceInterfaceFn createInterface);
 
-// Backward-compatible registration function when variant is "default"
-// TODONVDEC P2 We only need this if someone in the wild has already started
-// registering their own interfaces. Ask Dmitry.
-bool registerDeviceInterface(
-    torch::DeviceType deviceType,
-    const CreateDeviceInterfaceFn createInterface);
-
 void validateDeviceInterface(
     const std::string device,
     const std::string variant);