Skip to content

Commit b51642c

Browse files
committed
skip round trip tests on cuda + ffmpeg4
1 parent df726f5 commit b51642c

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

test/test_ops.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,10 +1175,15 @@ def test_video_encoder_round_trip(self, tmp_path, format, method, device):
11751175
ffmpeg_version == 4 or (IS_WINDOWS and ffmpeg_version in (6, 7))
11761176
):
11771177
pytest.skip("Codec for webm is not available in this FFmpeg installation.")
1178-
if device == "cuda" and format not in ("mp4", "mov", "mkv"):
1179-
pytest.skip(
1180-
f"No NVENC encoder available for format {format}, skipping test."
1181-
)
1178+
if device == "cuda":
1179+
if format not in ("mp4", "mov", "mkv"):
1180+
pytest.skip(
1181+
f"No NVENC encoder available for format {format}, skipping test."
1182+
)
1183+
if ffmpeg_version == 4:
1184+
pytest.skip(
1185+
"CUDA encoding on FFmpeg 4 results in lower quality, skipping round trip test."
1186+
)
11821187

11831188
source_frames = self.decode(TEST_SRC_2_720P.path).data
11841189

@@ -1305,6 +1310,10 @@ def test_video_encoder_against_ffmpeg_cli(self, tmp_path, format, device):
13051310
pytest.skip(
13061311
f"No NVENC encoder available for format {format}, skipping test."
13071312
)
1313+
if ffmpeg_version == 4:
1314+
pytest.skip(
1315+
"CUDA encoding on FFmpeg 4 results in lower quality, skipping round trip test."
1316+
)
13081317

13091318
source_frames = self.decode(TEST_SRC_2_720P.path).data
13101319

0 commit comments

Comments
 (0)