Merge branch 'main' of github.com:pytorch/torchcodec into aeaenjfjanef

Author: NicolasHug

benchmarks/decoders/benchmark_decoders.py

@@ -6,6 +6,7 @@
 
 import argparse
 import importlib.resources
+import json
 import os
 import platform
 from pathlib import Path
@@ -106,6 +107,12 @@ def main() -> None:
         default=False,
         action=argparse.BooleanOptionalAction,
     )
+    parser.add_argument(
+        "--output-json",
+        help="Output the results to a JSON file",
+        type=str,
+        default="",
+    )
 
     args = parser.parse_args()
     specified_decoders = set(args.decoders.split(","))
@@ -146,6 +153,10 @@ def main() -> None:
             min_runtime_seconds=args.min_run_seconds,
             benchmark_video_creation=args.bm_video_creation,
         )
+        if args.output_json:
+            with open(args.output_json, "w") as f:
+                json.dump(results, f, indent=2)
+
         data = {
             "experiments": results,
             "system_metadata": {

src/torchcodec/_core/Encoder.cpp

@@ -574,8 +574,6 @@ VideoEncoder::VideoEncoder(
       fileName,
       ", make sure it's a valid path? ",
       getFFMPEGErrorStringFromErrorCode(status));
-  // TODO-VideoEncoder: Add tests for above fileName related checks
-
   initializeEncoder(videoStreamOptions);
 }
 

test/test_ops.py

@@ -1268,6 +1268,26 @@ def test_bad_input(self, tmp_path):
                 filename=output_file,
             )
 
+        with pytest.raises(
+            RuntimeError,
+            match=r"Couldn't allocate AVFormatContext. The destination file is ./file.bad_extension, check the desired extension\?",
+        ):
+            encode_video_to_file(
+                frames=torch.randint(high=255, size=(10, 3, 60, 60), dtype=torch.uint8),
+                frame_rate=10,
+                filename="./file.bad_extension",
+            )
+
+        with pytest.raises(
+            RuntimeError,
+            match=r"avio_open failed. The destination file is ./bad/path.mp3, make sure it's a valid path\?",
+        ):
+            encode_video_to_file(
+                frames=torch.randint(high=255, size=(10, 3, 60, 60), dtype=torch.uint8),
+                frame_rate=10,
+                filename="./bad/path.mp3",
+            )
+
     def decode(self, file_path) -> torch.Tensor:
         decoder = create_from_file(str(file_path), seek_mode="approximate")
         add_video_stream(decoder)