-
Notifications
You must be signed in to change notification settings - Fork 105
: logging: default disable log forwarding #1878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
shayne-fletcher
wants to merge
1
commit into
meta-pytorch:main
from
shayne-fletcher:export-D86994420
Closed
: logging: default disable log forwarding #1878
shayne-fletcher
wants to merge
1
commit into
meta-pytorch:main
from
shayne-fletcher:export-D86994420
+181
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86994420. |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 13, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a workplace post is planned to announce this change in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito Differential Revision: D86994420
eb5b6dc to
648057e
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 13, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a workplace post is planned to announce this change in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
1f3d29b to
d400d18
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
d400d18 to
03c3442
Compare
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
03c3442 to
8a42ca7
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 14, 2025
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a [workplace post is planned to announce this change](https://fb.workplace.com/groups/1399849971389924/permalink/1602002844507968/) in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Reviewed By: zdevito, vidhyav Differential Revision: D86994420
|
This pull request has been merged in 7194160. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
this diff sets the following defaults for hyperactor-mesh global configuration values:
MESH_ENABLE_LOG_FORWARDING=falseMESH_ENABLE_FILE_CAPTURE=falseMESH_TAIL_LOG_LINES=0the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all.
a workplace post is planned to announce this change in default configuration.
this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up
LogForwardActormeshes when log forwarding is enabled and D85969320 for some detailed testing.Differential Revision: D86994420