Skip to content

Commit eb5b6dc

Browse files
: logging: default disable log forwarding
Summary: this diff sets the following defaults for hyperactor-mesh global configuration values: - `MESH_ENABLE_LOG_FORWARDING=false` - `MESH_ENABLE_FILE_CAPTURE=false` - `MESH_TAIL_LOG_LINES=0` the effect of this is to disable log forwarding, prevent allocating resources for log forwarding, no file capture at the hyperactor mesh level (including no "exit tail" capture), in fact, under these defaults there is no interception of child process stdio at all. a workplace post is planned to announce this change in default configuration. this diff is built on: D85783397 provide config for enabling/disabling hyperactor-mesh logging interception features, D85919326 for avoiding spinning up `LogForwardActor` meshes when log forwarding is enabled and D85969320 for some detailed testing. Differential Revision: D86994420
1 parent b68c7fc commit eb5b6dc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

hyperactor_mesh/src/bootstrap.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ declare_attrs! {
9999
env_name: Some("HYPERACTOR_MESH_ENABLE_LOG_FORWARDING".to_string()),
100100
py_name: None,
101101
})
102-
pub attr MESH_ENABLE_LOG_FORWARDING: bool = true;
102+
pub attr MESH_ENABLE_LOG_FORWARDING: bool = false;
103103

104104
/// When `true`: if stdio is piped, each child's `StreamFwder`
105105
/// also forwards lines to a host-scoped `FileAppender` managed by
@@ -124,7 +124,7 @@ declare_attrs! {
124124
env_name: Some("HYPERACTOR_MESH_ENABLE_FILE_CAPTURE".to_string()),
125125
py_name: None,
126126
})
127-
pub attr MESH_ENABLE_FILE_CAPTURE: bool = true;
127+
pub attr MESH_ENABLE_FILE_CAPTURE: bool = false;
128128

129129
/// Maximum number of log lines retained in a proc's stderr/stdout
130130
/// tail buffer. Used by [`StreamFwder`] when wiring child
@@ -133,7 +133,7 @@ declare_attrs! {
133133
env_name: Some("HYPERACTOR_MESH_TAIL_LOG_LINES".to_string()),
134134
py_name: None,
135135
})
136-
pub attr MESH_TAIL_LOG_LINES: usize = 100;
136+
pub attr MESH_TAIL_LOG_LINES: usize = 0;
137137

138138
/// If enabled (default), bootstrap child processes install
139139
/// `PR_SET_PDEATHSIG(SIGKILL)` so the kernel reaps them if the

0 commit comments

Comments
 (0)