improve logs (#1887)

Summary:
Pull Request resolved: #1887

This diff does 2 changes:

1. downgrade a `warn` to `info` since that message is more a fyi, rather than asking the user to do something.
2. include `MESSAGE_DELIVERY_TIMEOUT` value in the error message.

Reviewed By: mariusae

Differential Revision: D86974138

fbshipit-source-id: 50415265d6cfb2d11b7b383eb8e7596d72626957

Author: pzhan9

hyperactor/src/channel/net.rs

@@ -2093,9 +2093,9 @@ mod tests {
 
         // Verify the channel is closed due to ack timeout based on the log.
         let expected_log: &str = if disconnect_before_ack {
-            "failed to receive ack within timeout 2 secs; link is currently broken"
+            "failed to receive ack within timeout 2s; link is currently broken"
         } else {
-            "failed to receive ack within timeout 2 secs; link is currently connected"
+            "failed to receive ack within timeout 2s; link is currently connected"
         };
 
         verify_tx_closed(&mut tx_status, expected_log).await;

hyperactor/src/channel/net/client.rs

@@ -937,8 +937,8 @@ where
                 // If acking message takes too long, consider the link broken.
                 _ = unacked.wait_for_timeout(), if !unacked.is_empty() => {
                     let error_msg = format!(
-                        "{log_id}: failed to receive ack within timeout {} secs; link is currently connected",
-                        config::global::get(config::MESSAGE_DELIVERY_TIMEOUT).as_secs(),
+                        "{log_id}: failed to receive ack within timeout {:?}; link is currently connected",
+                        config::global::get(config::MESSAGE_DELIVERY_TIMEOUT),
                     );
                     tracing::error!(error_msg);
                     (State::Closing {
@@ -1025,7 +1025,10 @@ where
             // If delivering this message is taking too long,
             // consider the link broken.
             if outbox.is_expired() {
-                let error_msg = format!("{log_id}: failed to deliver message within timeout");
+                let error_msg = format!(
+                    "{log_id}: failed to deliver message within timeout {:?}",
+                    config::global::get(config::MESSAGE_DELIVERY_TIMEOUT)
+                );
                 tracing::error!(error_msg);
                 (
                     State::Closing {
@@ -1036,8 +1039,8 @@ where
                 )
             } else if unacked.is_expired() {
                 let error_msg = format!(
-                    "{log_id}: failed to receive ack within timeout {} secs; link is currently broken",
-                    config::global::get(config::MESSAGE_DELIVERY_TIMEOUT).as_secs(),
+                    "{log_id}: failed to receive ack within timeout {:?}; link is currently broken",
+                    config::global::get(config::MESSAGE_DELIVERY_TIMEOUT),
                 );
                 tracing::error!(error_msg);
                 (

hyperactor_mesh/src/alloc/process.rs

@@ -454,7 +454,7 @@ impl ProcessAlloc {
 
         // We don't support FileAppender in this v0 allocator path; warn if asked.
         if enable_file_capture {
-            tracing::warn!(
+            tracing::info!(
                 "MESH_ENABLE_FILE_CAPTURE=true, but ProcessAllocator (v0) has no FileAppender; \
                  files will NOT be written in this path"
             );