Skip to content

Commit 2bd9c40

Browse files
David Tolnaymeta-codesync[bot]
authored andcommitted
Update erased-serde from 0.3.31 to 0.4.9
Summary: Only fbcode/asic/hargow and fbcode/common/rust/slog_scuba need to remain on 0.3, due to their use of slog's "nested-values" feature. ```lang=log,counterexample error[E0053]: method `as_serde` has an incompatible type for trait --> fbcode/asic/hargow/lib/src/scuba.rs:233:9 | 233 | fn as_serde(&self) -> &dyn erased_serde::Serialize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected trait `erased_serde::ser::Serialize`, found trait `erased_serde::Serialize` | note: two different versions of crate `erased_serde` are being used; two types coming from two different versions of the same crate are different types even if they look the same --> third-party/rust/vendor/erased-serde-0.4.9/src/ser.rs:63:1 | = note: this is the found trait `erased_serde::Serialize` --> third-party/rust/vendor/erased-serde-0.3.31/src/ser.rs:52:1 | = note: this is the expected trait `erased_serde::ser::Serialize` | ::: fbcode/asic/hargow/lib/src/asic_directory.rs:4:5 | 4 | use hargow_common::organization::Organization; | ------------- one version of crate `erased_serde` used here, as a dependency of crate `slog` | ::: fbcode/asic/hargow/lib/src/scuba.rs:233:36 | 233 | fn as_serde(&self) -> &dyn erased_serde::Serialize { | ------------ one version of crate `erased_serde` used here, as a direct dependency of the current crate = help: you can use `cargo tree` to explore your dependency tree ``` ```lang=log,counterexample error[E0053]: method `as_serde` has an incompatible type for trait --> fbcode/common/rust/slog_scuba/tests/lib.rs:32:5 | 32 | fn as_serde(&self) -> &dyn erased_serde::Serialize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected trait `erased_serde::ser::Serialize`, found trait `erased_serde::Serialize` | note: two different versions of crate `erased_serde` are being used; two types coming from two different versions of the same crate are different types even if they look the same --> third-party/rust/vendor/erased-serde-0.4.9/src/ser.rs:63:1 | = note: this is the found trait `erased_serde::Serialize` --> third-party/rust/vendor/erased-serde-0.3.31/src/ser.rs:52:1 | = note: this is the expected trait `erased_serde::ser::Serialize` | ::: fbcode/common/rust/slog_scuba/tests/lib.rs:9:5 | 9 | use slog::o; | ---- one version of crate `erased_serde` used here, as a dependency of crate `slog` ... 32 | fn as_serde(&self) -> &dyn erased_serde::Serialize { | ------------ one version of crate `erased_serde` used here, as a direct dependency of the current crate = help: you can use `cargo tree` to explore your dependency tree ``` Reviewed By: diliop Differential Revision: D86491220 fbshipit-source-id: 73e0070b11332bfd22acbd33ceff2d7a14bcab26
1 parent 5ff89d3 commit 2bd9c40

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

hyperactor/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ dashmap = { version = "5.5.3", features = ["rayon", "serde"] }
5050
derivative = "2.2"
5151
dns-lookup = "1.0"
5252
enum-as-inner = "0.6.0"
53-
erased-serde = "0.3.31"
53+
erased-serde = "0.4.9"
5454
fastrand = "2.1.1"
5555
futures = { version = "0.3.31", features = ["async-await", "compat"] }
5656
hostname = "0.3"

hyperactor_mesh/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ chrono = { version = "0.4.41", features = ["clock", "serde", "std"], default-fea
5454
clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
5555
dashmap = { version = "5.5.3", features = ["rayon", "serde"] }
5656
enum-as-inner = "0.6.0"
57-
erased-serde = "0.3.31"
57+
erased-serde = "0.4.9"
5858
futures = { version = "0.3.31", features = ["async-await", "compat"] }
5959
hostname = "0.3"
6060
humantime = "2.1"

monarch_hyperactor/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ async-trait = "0.1.86"
2727
bincode = "1.3.3"
2828
bytes = { version = "1.10", features = ["serde"] }
2929
clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
30-
erased-serde = "0.3.31"
30+
erased-serde = "0.4.9"
3131
fastrand = "2.1.1"
3232
fbinit = { version = "0.2.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
3333
futures = { version = "0.3.31", features = ["async-await", "compat"] }

0 commit comments

Comments
 (0)