Smaller to syntax in SobolQMCNormalSampler (#1580)

SebastianAment · facebook-github-bot · commit 55cbaa16d2a7 · 2022-12-20T09:00:16.000-08:00
Summary: Pull Request resolved: #1580 `to` only allocates new tensors if they don't satisfy the `dtype` and `device` classes, so there is no a downside to calling `to` outside of the `if` statements. See the [docs here](https://pytorch.org/docs/stable/generated/torch.Tensor.to.html). Reviewed By: Balandat Differential Revision: D42163726 fbshipit-source-id: c69fb78e5d04fcb369bbd5c9c1a6d33f01bb525e
diff --git a/botorch/sampling/normal.py b/botorch/sampling/normal.py
@@ -200,7 +200,4 @@ def _construct_base_samples(self, posterior: Posterior) -> None:
             )
             base_samples = base_samples.view(target_shape)
             self.register_buffer("base_samples", base_samples)
-        if self.base_samples.device != posterior.device:
-            self.to(device=posterior.device)  # pragma: nocover
-        if self.base_samples.dtype != posterior.dtype:
-            self.to(dtype=posterior.dtype)
+        self.to(device=posterior.device, dtype=posterior.dtype)

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,4 @@ def _construct_base_samples(self, posterior: Posterior) -> None:`
`200`	`200`	`)`
`201`	`201`	`base_samples = base_samples.view(target_shape)`
`202`	`202`	`self.register_buffer("base_samples", base_samples)`
`203`		`- if self.base_samples.device != posterior.device:`
`204`		`- self.to(device=posterior.device) # pragma: nocover`
`205`		`- if self.base_samples.dtype != posterior.dtype:`
`206`		`- self.to(dtype=posterior.dtype)`
	`203`	`+ self.to(device=posterior.device, dtype=posterior.dtype)`