From 13a790651fb5e0f65a668c819cf7d33cba2d095c Mon Sep 17 00:00:00 2001 From: burtenshaw Date: Tue, 4 Nov 2025 09:38:06 +0100 Subject: [PATCH 1/3] delete comment from action --- .github/workflows/pr-new-env.yml | 45 +------------------------------- 1 file changed, 1 insertion(+), 44 deletions(-) diff --git a/.github/workflows/pr-new-env.yml b/.github/workflows/pr-new-env.yml index 1374abf7..70df3636 100644 --- a/.github/workflows/pr-new-env.yml +++ b/.github/workflows/pr-new-env.yml @@ -176,6 +176,7 @@ jobs: env: HEALTH_URL: ${{ steps.urls.outputs.health_url }} SPACE_NAME: ${{ steps.urls.outputs.space_name }} + HF_TOKEN: ${{ env.HF_TOKEN }} run: | set -euo pipefail @@ -208,50 +209,6 @@ jobs: exit 1 fi - - name: Comment on PR with deployment status - if: always() - uses: actions/github-script@v7 - env: - HEALTH_CONCLUSION: ${{ steps.health_check.conclusion }} - SPACE_NAME: ${{ steps.urls.outputs.space_name }} - LIVE_URL: ${{ steps.urls.outputs.live_url }} - SPACE_REPO_URL: ${{ steps.urls.outputs.space_repo_url }} - ENV_NAME: ${{ matrix.environment }} - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - script: | - const status = process.env.HEALTH_CONCLUSION || 'failure'; - const spaceName = process.env.SPACE_NAME; - const liveUrl = process.env.LIVE_URL; - const repoUrl = process.env.SPACE_REPO_URL; - const envName = process.env.ENV_NAME; - - const header = status === 'success' - ? `✅ Deployment succeeded for \`${envName}\`` - : `⚠️ Deployment failed for \`${envName}\``; - - const summary = status === 'success' - ? 'Nice work! Wait for a code review and we\'re ready to go.' - : 'Please resolve your environment.'; - - const body = [ - header, - '', - `- Space repo: [${repoUrl}](${repoUrl})`, - `- Live URL: [${liveUrl}](${liveUrl})`, - '', - summary, - '', - 'You can iterate locally or validate fixes by running `scripts/deploy_to_hf.sh --env "' + envName + '"`.' - ].join('\n'); - - await github.rest.issues.createComment({ - owner: context.repo.owner, - repo: context.repo.repo, - issue_number: context.payload.pull_request.number, - body - }); - - name: Fail job if health check failed if: steps.health_check.conclusion == 'failure' run: exit 1 From 344c0313016b2032efbdcc83edde5cbee96091d2 Mon Sep 17 00:00:00 2001 From: burtenshaw Date: Tue, 4 Nov 2025 09:38:22 +0100 Subject: [PATCH 2/3] add tag fix in shell script --- scripts/deploy_to_hf.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/deploy_to_hf.sh b/scripts/deploy_to_hf.sh index 20256c9a..9f6b3fb1 100755 --- a/scripts/deploy_to_hf.sh +++ b/scripts/deploy_to_hf.sh @@ -68,6 +68,7 @@ STAGING_DIR="hf-staging" SPACE_SUFFIX="" PRIVATE=false DRY_RUN=false +HUB_TAG="" while [[ $# -gt 0 ]]; do case "$1" in From 12425fb5df1f595148f1ea54395d56251773baf7 Mon Sep 17 00:00:00 2001 From: burtenshaw Date: Tue, 4 Nov 2025 09:40:56 +0100 Subject: [PATCH 3/3] drop excess change --- .github/workflows/pr-new-env.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/pr-new-env.yml b/.github/workflows/pr-new-env.yml index 70df3636..c9cf306b 100644 --- a/.github/workflows/pr-new-env.yml +++ b/.github/workflows/pr-new-env.yml @@ -176,7 +176,6 @@ jobs: env: HEALTH_URL: ${{ steps.urls.outputs.health_url }} SPACE_NAME: ${{ steps.urls.outputs.space_name }} - HF_TOKEN: ${{ env.HF_TOKEN }} run: | set -euo pipefail