Merge branch 'master' into 2.x

Author: mesilov

.github/workflows/integration.yml

@@ -2,11 +2,15 @@ name: "Integration tests"
 
 on:
   push:
+    branches:
+      - dev
   pull_request:
 
 env:
   COMPOSER_FLAGS: "--ansi --no-interaction --no-progress --prefer-dist"
   BITRIX24_PHP_SDK_PLAYGROUND_WEBHOOK: ${{ secrets.BITRIX24_PHP_SDK_PLAYGROUND_WEBHOOK }}
+  TEST2_ENV: 12345
+
 jobs:
   tests:
     name: "Integration tests"
@@ -20,6 +24,7 @@ jobs:
         dependencies: [ highest ]
 
     steps:
+
       - name: "Checkout"
         uses: "actions/checkout@v2"
 
@@ -28,10 +33,29 @@ jobs:
         with:
           coverage: "none"
           php-version: "${{ matrix.php-version }}"
+          ini-values: variables_order=EGPCS
+        env:
+          BITRIX24_PHP_SDK_PLAYGROUND_WEBHOOK: ${{ secrets.BITRIX24_PHP_SDK_PLAYGROUND_WEBHOOK }}
+          TEST2_ENV: 12345
 
       - name: "Install dependencies"
         run: |
           composer update ${{ env.COMPOSER_FLAGS }}
 
-      - name: "run unit tests"
-        run: "composer phpunit-run-integration-tests"
+      - name: "Debug ENV variables"
+        run: |
+          printenv
+
+      - name: "Run integration tests"
+        run: |
+          composer phpunit-run-integration-tests
+
+      - name: "is integration tests succeeded"
+        if: ${{ success() }}
+        run: |
+          echo '✅ integration tests pass, congratulations!'
+
+      - name: "is integration tests failed"
+        if: ${{ failure() }}
+        run: |
+          echo '::error:: ❗️iteintegration tests failed '

.github/workflows/phpstan.yml

@@ -40,4 +40,14 @@ jobs:
         run: "composer update --no-interaction --no-progress --no-suggest"
 
       - name: "PHPStan"
-        run: "composer phpstan-analyse"
+        run: "composer phpstan-analyse"
+
+      - name: "is PHPStan check succeeded"
+        if: ${{ success() }}
+        run: |
+          echo '✅ PHPStan check pass, congratulations!'
+
+      - name: "is PHPStan check failed"
+        if: ${{ failure() }}
+        run: |
+          echo '::error:: ❗️ PHPStan check failed (╯°益°)╯彡┻━┻'

.github/workflows/phpunit.yml

@@ -34,4 +34,14 @@ jobs:
           composer update ${{ env.COMPOSER_FLAGS }}
 
       - name: "run unit tests"
-        run: "composer phpunit-run-unit-tests"
+        run: "composer phpunit-run-unit-tests"
+
+      - name: "is unit tests tests succeeded"
+        if: ${{ success() }}
+        run: |
+          echo '✅ unit tests pass, congratulations!'
+
+      - name: "is unit tests tests failed"
+        if: ${{ failure() }}
+        run: |
+          echo '::error:: ❗️ unit tests tests failed (╯°益°)╯彡┻━┻'

CHANGELOG.md

@@ -18,6 +18,7 @@
   in `Bitrix24\SDK\Core\Response::__destruct()`
 * add `Bitrix24\SDK\Core\BulkItemsReader` for data-intensive applications for bulk export data from Bitrix24, read strategies located in
   folder `ReadStrategies`, in services read model **must** use most effective read strategy.
+* add integration tests in GitHub Actions pipeline 🎉, now integration tests run on push on `dev-branch`
 
 ### Changed
 

README.md

@@ -7,8 +7,14 @@ A powerful PHP library for the Bitrix24 REST API
 
 ### Build status
 
-[![phpstan check](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpstan.yml/badge.svg)](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpstan.yml)
-[![phpunit unit-tests status](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpunit.yml/badge.svg)](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpunit.yml)
+| CI\CD [status](https://github.com/mesilov/bitrix24-php-sdk/actions)                                                                                                                                   | 
+|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| 
+| [![phpstan check](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpstan.yml/badge.svg)](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpstan.yml)                    | 
+| [![unit-tests status](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpunit.yml/badge.svg)](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/phpunit.yml)                | 
+| [![integration-tests status](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/integration.yml/badge.svg)](https://github.com/mesilov/bitrix24-php-sdk/actions/workflows/integration.yml) | 
+
+Integration tests run in GitHub actions with real Bitrix24 portal 
+
 
 ### BITRIX24-PHP-SDK Documentation
 

tests/Integration/Fabric.php

@@ -47,12 +47,6 @@ public static function getBulkItemsReader(): BulkItemsReaderInterface
      */
     public static function getCore(): CoreInterface
     {
-
-        print(print_r($_ENV, true));
-        print(print_r($_ENV['BITRIX24_PHP_SDK_PLAYGROUND_WEBHOOK']));
-        print(print_r($_ENV['BITRIX24_WEBHOOK']));
-        exit();
-
         return (new CoreBuilder())
             ->withLogger(self::getLogger())
             ->withWebhookUrl($_ENV['BITRIX24_PHP_SDK_PLAYGROUND_WEBHOOK'] ?? $_ENV['BITRIX24_WEBHOOK'])

tests/Unit/Core/Result/AbstractItemTest.php

@@ -25,6 +25,7 @@ public function testSetPropertyItem(): void
         };
         $testItem->ID = 2;
     }
+
     /**
      * @covers \Bitrix24\SDK\Core\Result\AbstractItem::__unset
      */

tests/bootstrap.php

@@ -20,4 +20,4 @@
     putenv('APP_DEBUG=' . $_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] = '0');
 }
 
-(new Dotenv())->loadEnv(dirname(__DIR__).'/tests/.env');
+(new Dotenv())->loadEnv(dirname(__DIR__) . '/tests/.env');

tools/.env

@@ -1,3 +1,3 @@
 APP_ENV=dev
 LOGS_FILE=tools/logs/cli.log
-LOGS_LEVEL=200
+LOGS_LEVEL=300