files: improve error for uncompressed Helm .tar archives

[bashSunny101]

PR description
Summary

• Detects when a user provides an uncompressed .tar (not a gzipped chart) to Helm chart parsing and returns a clear, actionable error telling them to use .tgz / .tar.gz (or helm package).

What changed

• Add ErrUncompressedTarProvided to surface a helpful message and remedies when Helm's gzip reader fails.
• Update ParseFileAsHelmChart (files/identification.go) to detect the "gzip: invalid header" failure for .tar and return the new error.
• Add unit test TestUncompressedHelmTarError (files/tests/sanitization_test.go) that builds an in-memory uncompressed tar containing Chart.yaml and asserts the new error path.

Files touched

• files/error.go — new error constructor for uncompressed .tar.
• files/identification.go — improved detection and error handling around loader.LoadArchive.
• files/tests/sanitization_test.go — added unit test.

Why

• Helm expects charts as gzipped tarballs (e.g., .tgz). When an uncompressed .tar is supplied the gzip reader fails with an opaque "gzip: invalid header". This change makes the failure actionable for users.

Tests

• Added unit test covering the uncompressed .tar case.
• Ran go test ./... locally; tests pass.

Related

• Fixes: [Helm] Improve import error message for unsupported uncompressed Helm .tar #813

How to validate locally

1. Run the test suite:

   go test ./...

[welcome]

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

[gemini-code-assist]

Summary of Changes

Hello @bashSunny101, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience when working with Helm charts by introducing more specific and actionable error messages. Previously, attempting to load an uncompressed ".tar" file as a Helm chart would result in a cryptic "gzip: invalid header" error. This change now explicitly identifies such cases, providing a clear explanation that Helm requires gzipped archives (.tgz or .tar.gz) and offers practical solutions, thereby reducing user confusion and improving debugging efficiency.

Highlights

• Improved Helm Chart Error Handling: The system now specifically detects when an uncompressed ".tar" archive is provided for a Helm chart, which previously resulted in an opaque error.
• Actionable Error Message: Instead of a generic "gzip: invalid header" error, users will now receive a clear message (ErrUncompressedTarProvided) explaining that Helm expects compressed tarballs (.tgz or .tar.gz) and provides remedies.
• New Error Constructor: A new error constructor, ErrUncompressedTarProvided, has been added to files/error.go to encapsulate this specific error scenario and its suggested solutions.
• Updated Chart Parsing Logic: The ParseFileAsHelmChart function in files/identification.go has been updated to intercept the "gzip: invalid header" error when a ".tar" file is encountered and return the new, more informative error.
• Comprehensive Unit Testing: A new unit test, TestUncompressedHelmTarError, has been added to files/tests/sanitization_test.go to ensure the correct behavior and error path for uncompressed Helm ".tar" archives.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a helpful error message for when a user provides an uncompressed .tar archive for a Helm chart, which is a great improvement for user experience. The implementation is solid, and the new unit test effectively covers the new error path. I have a couple of suggestions to make the error detection more robust and to improve the quality of the test code.

[bashSunny101]

@Darshan174 hi,
Kindly merge this PR, it's got an approval and every checks are passing at my end.🙇

[lekaf974]

Small comments added, LGTM otherwise.

[bashSunny101]

I have made requested changes to this PR, kindly review it.
@lekaf974

[lekaf974]

another review after we will be good to merged

Good job

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[lekaf974]

@bashSunny101 do you have time to do last changes so it can be merged ?

[Copilot]

Pull request overview

This PR improves error handling for Helm chart parsing by detecting when users provide an uncompressed .tar file (instead of a gzipped .tgz or .tar.gz) and returning a clear, actionable error message explaining how to fix the issue.

• Introduces a new error type ErrUncompressedTar with helpful remediation steps
• Updates ParseFileAsHelmChart to detect gzip header failures and provide specific guidance
• Adds comprehensive test coverage for the uncompressed tar scenario

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
files/error.go	Adds new error code and constructor ErrUncompressedTar with actionable remediation guidance
files/identification.go	Enhances error detection in ParseFileAsHelmChart to identify uncompressed tar files and return the new specific error
files/tests/sanitization_test.go	Adds unit test TestUncompressedHelmTarError that validates the new error path with an in-memory uncompressed tar

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bashSunny101]

@lekaf974 I've addressed the requested changes:

• Added github.com/stretchr/testify/assert import to the test file
• Replaced the if err == nil check with assert.NotNil(t, err)
• Cleaned up the duplicate error checking code

All changes have been committed with sign-off and pushed. Please let me know if there's anything else that needs to be updated. Thanks for the review!

[lekaf974]

@bashSunny101 thanks and good Job

[welcome]

Thanks for your contribution to Meshery! 🎉

        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄