fix: based on code comment and feedback

Author: gjulivan

packages/pluggableWidgets/combobox-web/src/Combobox.editorConfig.ts

@@ -35,7 +35,10 @@ const ASSOCIATION_SOURCE_CONFIG: Array<keyof ComboboxPreviewProps> = [
     "attributeAssociation"
 ];
 
-export function getProperties(values: ComboboxPreviewProps, defaultProperties: Properties): Properties {
+export function getProperties(
+    values: ComboboxPreviewProps & { Editability?: unknown },
+    defaultProperties: Properties
+): Properties {
     if (values.source !== "database") {
         hidePropertiesIn(defaultProperties, values, ["customEditability", "customEditabilityExpression"]);
     }
@@ -133,7 +136,6 @@ export function getProperties(values: ComboboxPreviewProps, defaultProperties: P
         }
         if (values.databaseAttributeString.length === 0) {
             hidePropertiesIn(defaultProperties, values, ["optionsSourceDatabaseValueAttribute"]);
-            // @ts-expect-error ignore error due to the Editability is part of system properties
             hidePropertiesIn(defaultProperties, values, ["Editability"]);
             if (values.customEditability !== "conditionally") {
                 hidePropertiesIn(defaultProperties, values, ["customEditabilityExpression"]);

packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseSingleSelectionSelector.ts

@@ -60,7 +60,6 @@ export class DatabaseSingleSelectionSelector<T extends string | Big, R extends E
         }
         this._attr = targetAttribute as R;
         this.readOnly = getReadonly(targetAttribute, props.customEditability, props.customEditabilityExpression);
-        console.log("readOnly", this.readOnly);
         this.lazyLoader.updateProps(ds);
         this.lazyLoader.setLimit(
             this.lazyLoader.getLimit(ds.limit, this.readOnly, targetAttribute?.status ?? ds.status, lazyLoading)

packages/pluggableWidgets/combobox-web/src/helpers/Database/utils.ts

@@ -99,7 +99,7 @@ export function getReadonly(
         return true;
     }
     if (customEditability === "conditionally") {
-        return customEditabilityExpression.value ?? false;
+        return customEditabilityExpression.value ?? true;
     }
     return false;
 }