Skip to content

Commit aaa2830

Browse files
yordan-stgjulivan
authored andcommitted
refactor(events-web): rename properties for consistency
1 parent 57f89e9 commit aaa2830

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

packages/pluggableWidgets/events-web/src/Events.editorConfig.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function getProperties(
3737
hidePropertiesIn(defaultProperties, values, ["componentLoadDelayExpression"]);
3838
}
3939
if (values.onEventChangeDelayParameterType === "expression") {
40-
hidePropertiesIn(defaultProperties, values, ["onEventChangeDelayInteger"]);
40+
hidePropertiesIn(defaultProperties, values, ["onEventChangeDelay"]);
4141
} else {
4242
hidePropertiesIn(defaultProperties, values, ["onEventChangeDelayExpression"]);
4343
}

packages/pluggableWidgets/events-web/src/Events.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default function Events(props: EventsContainerProps): ReactElement {
1919
componentLoadRepeatIntervalParameterType,
2020
componentLoadRepeatIntervalExpression,
2121
componentLoadDelayParameterType,
22-
onEventChangeDelayInteger,
22+
onEventChangeDelay,
2323
onEventChangeDelayParameterType,
2424
onEventChangeDelayExpression
2525
} = props;
@@ -31,7 +31,7 @@ export default function Events(props: EventsContainerProps): ReactElement {
3131
onEventChangeDelayParameterType,
3232
componentLoadDelay,
3333
componentLoadRepeatInterval,
34-
onEventChangeDelayInteger,
34+
onEventChangeDelay,
3535
componentLoadRepeatIntervalExpression,
3636
componentLoadDelayExpression,
3737
onEventChangeDelayExpression

packages/pluggableWidgets/events-web/src/__tests__/AppEvents.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe("App events (load)", () => {
2222
onEventChangeAttribute: undefined,
2323
onEventChange: undefined,
2424
onEventChangeDelayParameterType: "number",
25-
onEventChangeDelayInteger: 0,
25+
onEventChangeDelay: 0,
2626
onEventChangeDelayExpression: dynamicValue()
2727
};
2828
});

packages/pluggableWidgets/events-web/src/hooks/delayAndInterval.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ interface ParameterTypeProps {
44
onEventChangeDelayParameterType: string;
55
componentLoadDelay?: number;
66
componentLoadRepeatInterval?: number;
7-
onEventChangeDelayInteger?: number;
7+
onEventChangeDelay?: number;
88
componentLoadRepeatIntervalExpression?: { status: string; value: { toNumber: () => number } | undefined };
99
componentLoadDelayExpression?: { status: string; value: { toNumber: () => number } | undefined };
1010
onEventChangeDelayExpression?: { status: string; value: { toNumber: () => number } | undefined };
@@ -19,7 +19,7 @@ export function useDelayAndInterval(props: ParameterTypeProps): [number | undefi
1919
onEventChangeDelayParameterType,
2020
componentLoadDelay,
2121
componentLoadRepeatInterval,
22-
onEventChangeDelayInteger,
22+
onEventChangeDelay,
2323
componentLoadRepeatIntervalExpression,
2424
componentLoadDelayExpression,
2525
onEventChangeDelayExpression
@@ -42,7 +42,7 @@ export function useDelayAndInterval(props: ParameterTypeProps): [number | undefi
4242
: undefined;
4343
}
4444
if (onEventChangeDelayParameterType === "number") {
45-
delayValue = onEventChangeDelayInteger;
45+
delayValue = onEventChangeDelay;
4646
} else {
4747
delayValue =
4848
onEventChangeDelayExpression?.status === "available" && onEventChangeDelayExpression.value !== undefined

packages/pluggableWidgets/events-web/typings/EventsProps.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ export interface EventsContainerProps {
2929
onEventChangeAttribute?: EditableValue<Big | any | boolean | Date | string>;
3030
onEventChange?: ActionValue;
3131
onEventChangeDelayParameterType: OnEventChangeDelayParameterTypeEnum;
32-
onEventChangeDelayInteger: number;
33-
onEventChangeDelayExpression?: DynamicValue<Big>;
32+
onEventChangeDelay: number;
33+
onEventChangeDelayExpression: DynamicValue<Big>;
3434
}
3535

3636
export interface EventsPreviewProps {
@@ -55,6 +55,6 @@ export interface EventsPreviewProps {
5555
onEventChangeAttribute: string;
5656
onEventChange: {} | null;
5757
onEventChangeDelayParameterType: OnEventChangeDelayParameterTypeEnum;
58-
onEventChangeDelayInteger: number | null;
58+
onEventChangeDelay: number | null;
5959
onEventChangeDelayExpression: string;
6060
}

0 commit comments

Comments
 (0)