fix: make use of "store" flags

Author: iobuhov

packages/pluggableWidgets/gallery-web/src/Gallery.editorConfig.ts

@@ -18,7 +18,10 @@ export function getProperties(values: GalleryPreviewProps, defaultProperties: Pr
         hidePropertiesIn(defaultProperties, values, ["onSelectionChange", "itemSelectionMode"]);
     }
 
-    if (values.stateStorageType === "localStorage") {
+    const usePersonalization = values.storeFilters || values.storeSort;
+    if (!usePersonalization) {
+        hidePropertiesIn(defaultProperties, values, ["stateStorageType", "stateStorageAttr", "onConfigurationChange"]);
+    } else if (values.stateStorageType === "localStorage") {
         hidePropertyIn(defaultProperties, values, "stateStorageAttr");
         hidePropertyIn(defaultProperties, values, "onConfigurationChange");
     }

packages/pluggableWidgets/gallery-web/src/stores/GalleryPersistentStateController.ts

@@ -8,12 +8,16 @@ interface GalleryPersistentStateControllerSpec {
     filtersHost: Serializable;
     sortHost: Serializable;
     storage: ObservableStorage;
+    storeFilters: boolean;
+    storeSort: boolean;
 }
 
 export class GalleryPersistentStateController {
     private readonly _storage: ObservableStorage;
     private readonly _filtersHost: Serializable;
     private readonly _sortHost: Serializable;
+    readonly storeFilters: boolean;
+    readonly storeSort: boolean;
 
     readonly schemaVersion: number = 1;
 
@@ -22,6 +26,8 @@ export class GalleryPersistentStateController {
         this._storage = spec.storage;
         this._filtersHost = spec.filtersHost;
         this._sortHost = spec.sortHost;
+        this.storeFilters = spec.storeFilters;
+        this.storeSort = spec.storeSort;
 
         makeObservable<this, "_persistentState">(this, {
             _persistentState: computed,
@@ -77,15 +83,22 @@ export class GalleryPersistentStateController {
         if (!this._validate(data)) {
             return;
         }
-        this._filtersHost.fromJSON(data.filters);
-        this._sortHost.fromJSON(data.sort);
+        if (this.storeFilters) {
+            this._filtersHost.fromJSON(data.filters);
+        }
+        if (this.storeSort) {
+            this._sortHost.fromJSON(data.sort);
+        }
     }
 
     toJSON(): PlainJs {
-        return {
-            version: 1,
-            filters: this._filtersHost.toJSON(),
-            sort: this._sortHost.toJSON()
-        };
+        const data: PlainJs = { version: 1 };
+        if (this.storeFilters) {
+            data.filters = this._filtersHost.toJSON();
+        }
+        if (this.storeSort) {
+            data.sort = this._sortHost.toJSON();
+        }
+        return data;
     }
 }

packages/pluggableWidgets/gallery-web/src/stores/GalleryStore.ts

@@ -87,10 +87,13 @@ export class GalleryStore extends BaseControllerHost {
             query: this._query.derivedQuery
         });
 
-        this.initStateController(spec, spec.gate);
+        const useStorage = spec.storeFilters || spec.storeSort;
+        if (useStorage) {
+            this.initPersistentStorage(spec, spec.gate);
+        }
     }
 
-    initStateController(props: StaticProps, gate: GalleryPropsGate): void {
+    initPersistentStorage(props: StaticProps, gate: GalleryPropsGate): void {
         if (props.stateStorageType === "localStorage") {
             this._storage = new BrowserStorage(this.name);
         } else if (gate.props.stateStorageAttr) {
@@ -107,7 +110,9 @@ export class GalleryStore extends BaseControllerHost {
         new GalleryPersistentStateController(this, {
             storage: this._storage,
             filtersHost: this._filtersHost,
-            sortHost: this._sortHost
+            sortHost: this._sortHost,
+            storeFilters: props.storeFilters,
+            storeSort: props.storeSort
         });
     }
 }