fix(datagrid-web): update selection properties to include 'keepSelection' in hide logic

samuelreichert · samuelreichert · commit 3b4afeb3e83b · 2025-11-04T11:10:48.000+01:00
diff --git a/packages/pluggableWidgets/datagrid-web/src/Datagrid.editorConfig.ts b/packages/pluggableWidgets/datagrid-web/src/Datagrid.editorConfig.ts
@@ -158,7 +158,12 @@ function hideSelectionProperties(defaultProperties: Properties, values: Datagrid
     const { itemSelection, itemSelectionMethod } = values;
 
     if (itemSelection === "None") {
-        hidePropertiesIn(defaultProperties, values, ["itemSelectionMethod", "itemSelectionMode", "onSelectionChange"]);
+        hidePropertiesIn(defaultProperties, values, [
+            "itemSelectionMethod",
+            "itemSelectionMode",
+            "onSelectionChange",
+            "keepSelection"
+        ]);
     }
 
     if (itemSelectionMethod === "checkbox") {
@@ -170,11 +175,7 @@ function hideSelectionProperties(defaultProperties: Properties, values: Datagrid
     }
 
     if (itemSelection !== "Multi") {
-        hidePropertiesIn(defaultProperties, values, [
-            "keepSelection",
-            "selectionCountPosition",
-            "clearSelectionButtonLabel"
-        ]);
+        hidePropertiesIn(defaultProperties, values, ["selectionCountPosition", "clearSelectionButtonLabel"]);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,12 @@ function hideSelectionProperties(defaultProperties: Properties, values: Datagrid`
`158`	`158`	`const { itemSelection, itemSelectionMethod } = values;`
`159`	`159`
`160`	`160`	`if (itemSelection === "None") {`
`161`		`- hidePropertiesIn(defaultProperties, values, ["itemSelectionMethod", "itemSelectionMode", "onSelectionChange"]);`
	`161`	`+ hidePropertiesIn(defaultProperties, values, [`
	`162`	`+ "itemSelectionMethod",`
	`163`	`+ "itemSelectionMode",`
	`164`	`+ "onSelectionChange",`
	`165`	`+ "keepSelection"`
	`166`	`+ ]);`
`162`	`167`	`}`
`163`	`168`
`164`	`169`	`if (itemSelectionMethod === "checkbox") {`
`@@ -170,11 +175,7 @@ function hideSelectionProperties(defaultProperties: Properties, values: Datagrid`
`170`	`175`	`}`
`171`	`176`
`172`	`177`	`if (itemSelection !== "Multi") {`
`173`		`- hidePropertiesIn(defaultProperties, values, [`
`174`		`- "keepSelection",`
`175`		`- "selectionCountPosition",`
`176`		`- "clearSelectionButtonLabel"`
`177`		`- ]);`
	`178`	`+ hidePropertiesIn(defaultProperties, values, ["selectionCountPosition", "clearSelectionButtonLabel"]);`
`178`	`179`	`}`
`179`	`180`	`}`
`180`	`181`