Skip to content

Commit 38fbab9

Browse files
committed
refactor: change interface names
1 parent d7e9c23 commit 38fbab9

39 files changed

+140
-209
lines changed

packages/pluggableWidgets/datagrid-web/test-ct/preview.spec.tsx

Whitespace-only changes.

packages/pluggableWidgets/gallery-web/src/controllers/DerivedLoaderController.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { DatasourceController } from "@mendix/widget-plugin-grid/query/DatasourceController";
1+
import { DatasourceService } from "@mendix/widget-plugin-grid/main";
22
import { computed, makeObservable } from "mobx";
33

44
export class DerivedLoaderController {
55
constructor(
6-
private datasourceController: DatasourceController,
6+
private datasourceService: DatasourceService,
77
private refreshIndicator: boolean
88
) {
99
makeObservable(this, {
@@ -13,7 +13,7 @@ export class DerivedLoaderController {
1313
}
1414

1515
get isRefreshing(): boolean {
16-
const { isSilentRefresh, isRefreshing } = this.datasourceController;
16+
const { isSilentRefresh, isRefreshing } = this.datasourceService;
1717
return !isSilentRefresh && isRefreshing;
1818
}
1919

packages/pluggableWidgets/gallery-web/src/controllers/QueryParamsController.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { DatasourceController } from "@mendix/widget-plugin-grid/query/DatasourceController";
1+
import { DatasourceService } from "@mendix/widget-plugin-grid/main";
22
import { disposeBatch } from "@mendix/widget-plugin-mobx-kit/disposeBatch";
3-
import { ReactiveController, ReactiveControllerHost } from "@mendix/widget-plugin-mobx-kit/reactive-controller";
3+
import { SetupComponent, SetupComponentHost } from "@mendix/widget-plugin-mobx-kit/main";
44
import { SortInstruction } from "@mendix/widget-plugin-sorting/types/store";
55

66
import { FilterCondition } from "mendix/filters";
@@ -14,18 +14,18 @@ interface ObservableSortStore {
1414
sortOrder: SortInstruction[] | undefined;
1515
}
1616

17-
export class QueryParamsController implements ReactiveController {
18-
private readonly _query: DatasourceController;
17+
export class QueryParamsController implements SetupComponent {
18+
private readonly _query: DatasourceService;
1919
private readonly _filtersHost: ObservableFilterStore;
2020
private readonly _sortHost: ObservableSortStore;
2121

2222
constructor(
23-
host: ReactiveControllerHost,
24-
query: DatasourceController,
23+
host: SetupComponentHost,
24+
query: DatasourceService,
2525
filters: ObservableFilterStore,
2626
sort: ObservableSortStore
2727
) {
28-
host.addController(this);
28+
host.add(this);
2929

3030
this._query = query;
3131
this._filtersHost = filters;

packages/shared/widget-plugin-grid/src/query/PaginationController.ts renamed to packages/pluggableWidgets/gallery-web/src/services/PaginationController.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { ReactiveController, ReactiveControllerHost } from "@mendix/widget-plugin-mobx-kit/reactive-controller";
2-
import { QueryController } from "./query-controller";
1+
import { QueryService } from "@mendix/widget-plugin-grid/main";
32

43
type PaginationEnum = "buttons" | "virtualScrolling" | "loadMore";
54

@@ -16,19 +15,18 @@ interface StaticProps {
1615

1716
/** NOTE: Use gate for dynamic props */
1817
type PaginationControllerSpec = StaticProps & {
19-
query: QueryController;
18+
query: QueryService;
2019
};
2120

22-
export class PaginationController implements ReactiveController {
21+
export class PaginationController {
2322
private readonly _pageSize: number;
24-
private readonly _query: QueryController;
23+
private readonly _query: QueryService;
2524
readonly pagination: PaginationEnum;
2625
readonly paginationKind: PaginationKind;
2726
readonly showPagingButtons: ShowPagingButtonsEnum;
2827
readonly showTotalCount: boolean;
2928

30-
constructor(host: ReactiveControllerHost, spec: PaginationControllerSpec) {
31-
host.addController(this);
29+
constructor(spec: PaginationControllerSpec) {
3230
this._pageSize = spec.pageSize;
3331
this._query = spec.query;
3432
this.pagination = spec.pagination;
@@ -76,11 +74,9 @@ export class PaginationController implements ReactiveController {
7674
this._query.requestTotalCount(true);
7775
}
7876

79-
this._query.setPageSize(this.pageSize);
77+
this._query.setBaseLimit(this.pageSize);
8078
}
8179

82-
setup(): void {}
83-
8480
setPage = (computePage: (prevPage: number) => number): void => {
8581
const newPage = computePage(this.currentPage);
8682
if (this.isLimitBased) {

packages/pluggableWidgets/gallery-web/src/stores/AttributeStorage.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { PlainJs } from "@mendix/filter-commons/typings/settings";
2-
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/props-gate";
3-
import { ReactiveController, ReactiveControllerHost } from "@mendix/widget-plugin-mobx-kit/reactive-controller";
2+
import { DerivedPropsGate, SetupComponent, SetupComponentHost } from "@mendix/widget-plugin-mobx-kit/main";
43
import { EditableValue } from "mendix";
54
import { computed, makeObservable } from "mobx";
65
import { ObservableStorage } from "src/typings/storage";
@@ -9,11 +8,11 @@ type Gate = DerivedPropsGate<{
98
stateStorageAttr: EditableValue<string>;
109
}>;
1110

12-
export class AttributeStorage implements ObservableStorage, ReactiveController {
11+
export class AttributeStorage implements ObservableStorage, SetupComponent {
1312
private readonly _gate: Gate;
1413

15-
constructor(host: ReactiveControllerHost, gate: Gate) {
16-
host.addController(this);
14+
constructor(host: SetupComponentHost, gate: Gate) {
15+
host.add(this);
1716

1817
this._gate = gate;
1918
makeObservable<this, "_attribute">(this, {

packages/pluggableWidgets/gallery-web/src/stores/GalleryPersistentStateController.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { PlainJs, Serializable } from "@mendix/filter-commons/typings/settings";
22
import { disposeBatch } from "@mendix/widget-plugin-mobx-kit/disposeBatch";
3-
import { ReactiveControllerHost } from "@mendix/widget-plugin-mobx-kit/reactive-controller";
3+
import { SetupComponent, SetupComponentHost } from "@mendix/widget-plugin-mobx-kit/main";
44
import { action, comparer, computed, makeObservable, reaction } from "mobx";
55
import { ObservableStorage } from "src/typings/storage";
66

@@ -12,7 +12,7 @@ interface GalleryPersistentStateControllerSpec {
1212
storeSort: boolean;
1313
}
1414

15-
export class GalleryPersistentStateController {
15+
export class GalleryPersistentStateController implements SetupComponent {
1616
private readonly _storage: ObservableStorage;
1717
private readonly _filtersHost: Serializable;
1818
private readonly _sortHost: Serializable;
@@ -21,8 +21,8 @@ export class GalleryPersistentStateController {
2121

2222
readonly schemaVersion: number = 1;
2323

24-
constructor(host: ReactiveControllerHost, spec: GalleryPersistentStateControllerSpec) {
25-
host.addController(this);
24+
constructor(host: SetupComponentHost, spec: GalleryPersistentStateControllerSpec) {
25+
host.add(this);
2626
this._storage = spec.storage;
2727
this._filtersHost = spec.filtersHost;
2828
this._sortHost = spec.sortHost;

packages/pluggableWidgets/gallery-web/src/stores/GalleryStore.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,17 @@
11
import { createContextWithStub, FilterAPI } from "@mendix/widget-plugin-filtering/context";
22
import { CombinedFilter } from "@mendix/widget-plugin-filtering/stores/generic/CombinedFilter";
33
import { CustomFilterHost } from "@mendix/widget-plugin-filtering/stores/generic/CustomFilterHost";
4-
import { DatasourceController } from "@mendix/widget-plugin-grid/query/DatasourceController";
5-
import { PaginationController } from "@mendix/widget-plugin-grid/query/PaginationController";
6-
import { RefreshController } from "@mendix/widget-plugin-grid/query/RefreshController";
4+
import { DatasourceService, RefreshController } from "@mendix/widget-plugin-grid/main";
75
import { SelectionCountStore } from "@mendix/widget-plugin-grid/selection/stores/SelectionCountStore";
8-
import { BaseControllerHost } from "@mendix/widget-plugin-mobx-kit/BaseControllerHost";
9-
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/props-gate";
6+
import { DerivedPropsGate, SetupHost } from "@mendix/widget-plugin-mobx-kit/main";
107
import { generateUUID } from "@mendix/widget-plugin-platform/framework/generate-uuid";
118
import { SortAPI } from "@mendix/widget-plugin-sorting/react/context";
129
import { SortStoreHost } from "@mendix/widget-plugin-sorting/stores/SortStoreHost";
1310
import { DynamicValue, EditableValue, ListValue, SelectionMultiValue, SelectionSingleValue } from "mendix";
1411
import { PaginationEnum, StateStorageTypeEnum } from "../../typings/GalleryProps";
1512
import { DerivedLoaderController } from "../controllers/DerivedLoaderController";
1613
import { QueryParamsController } from "../controllers/QueryParamsController";
14+
import { PaginationController } from "../services/PaginationController";
1715
import { ObservableStorage } from "../typings/storage";
1816
import { AttributeStorage } from "./AttributeStorage";
1917
import { BrowserStorage } from "./BrowserStorage";
@@ -45,8 +43,8 @@ type GalleryStoreSpec = StaticProps & {
4543
gate: GalleryPropsGate;
4644
};
4745

48-
export class GalleryStore extends BaseControllerHost {
49-
private readonly _query: DatasourceController;
46+
export class GalleryStore extends SetupHost {
47+
private readonly _query: DatasourceService;
5048
private readonly _filtersHost: CustomFilterHost;
5149
private readonly _sortHost: SortStoreHost;
5250
private _storage: ObservableStorage | null = null;
@@ -64,9 +62,9 @@ export class GalleryStore extends BaseControllerHost {
6462

6563
this.name = spec.name;
6664

67-
this._query = new DatasourceController(this, spec.gate);
65+
this._query = new DatasourceService(this, spec.gate);
6866

69-
this.paging = new PaginationController(this, {
67+
this.paging = new PaginationController({
7068
query: this._query,
7169
pageSize: spec.pageSize,
7270
pagination: spec.pagination,

packages/shared/widget-plugin-dropdown-filter/src/containers/EnumFilterContainer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { GateProvider } from "@mendix/widget-plugin-mobx-kit/GateProvider";
2-
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/props-gate";
2+
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/main";
33
import { useConst } from "@mendix/widget-plugin-mobx-kit/react/useConst";
44
import { useSetup } from "@mendix/widget-plugin-mobx-kit/react/useSetup";
55
import { ActionValue, EditableValue } from "mendix";

packages/shared/widget-plugin-dropdown-filter/src/containers/RefFilterContainer.tsx

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,21 @@
1-
import { RefSelectController } from "../controllers/RefSelectController";
1+
import { useOnScrollBottom } from "@mendix/widget-plugin-hooks/useOnScrollBottom";
2+
import { GateProvider } from "@mendix/widget-plugin-mobx-kit/GateProvider";
3+
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/main";
4+
import { useConst } from "@mendix/widget-plugin-mobx-kit/react/useConst";
5+
import { useSetup } from "@mendix/widget-plugin-mobx-kit/react/useSetup";
6+
import { ActionValue, EditableValue } from "mendix";
7+
import { observer } from "mobx-react-lite";
8+
import { CSSProperties, ReactElement, useEffect } from "react";
29
import { RefComboboxController } from "../controllers/RefComboboxController";
10+
import { RefSelectController } from "../controllers/RefSelectController";
311
import { RefTagPickerController } from "../controllers/RefTagPickerController";
4-
import { Select } from "../controls/select/Select";
512
import { Combobox } from "../controls/combobox/Combobox";
13+
import { Select } from "../controls/select/Select";
614
import { TagPicker } from "../controls/tag-picker/TagPicker";
15+
import { useFrontendType } from "../helpers/useFrontendType";
716
import { usePickerJSActions } from "../helpers/usePickerJSActions";
817
import { RefFilterStore } from "../stores/RefFilterStore";
9-
import { ActionValue, EditableValue } from "mendix";
10-
import { observer } from "mobx-react-lite";
11-
import { CSSProperties, ReactElement, useEffect } from "react";
12-
13-
import { useFrontendType } from "../helpers/useFrontendType";
14-
import { useOnScrollBottom } from "@mendix/widget-plugin-hooks/useOnScrollBottom";
1518
import { SelectedItemsStyleEnum, SelectionMethodEnum } from "../typings/widget";
16-
import { useSetup } from "@mendix/widget-plugin-mobx-kit/react/useSetup";
17-
import { useConst } from "@mendix/widget-plugin-mobx-kit/react/useConst";
18-
import { GateProvider } from "@mendix/widget-plugin-mobx-kit/GateProvider";
19-
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/props-gate";
2019

2120
export interface RefFilterContainerProps {
2221
ariaLabel: string;

packages/shared/widget-plugin-dropdown-filter/src/controllers/BaseController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/props-gate";
1+
import { DerivedPropsGate } from "@mendix/widget-plugin-mobx-kit/main";
22
import { ActionValue, EditableValue } from "mendix";
33
import { OptionsSerializer } from "../stores/OptionsSerializer";
44
import { IJSActionsControlled, ResetHandler, SetValueHandler } from "../typings/IJSActionsControlled";

0 commit comments

Comments
 (0)