Skip to content

Commit 37b6328

Browse files
committed
fix: failing e2e
1 parent 37560da commit 37b6328

File tree

8 files changed

+16
-16
lines changed

8 files changed

+16
-16
lines changed

packages/pluggableWidgets/datagrid-web/src/components/CellElement.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import classNames from "classnames";
2-
import { DOMAttributes, forwardRef, JSX, memo, ReactElement, ReactNode } from "react";
2+
import { ComponentPropsWithoutRef, DOMAttributes, forwardRef, memo, ReactElement, ReactNode } from "react";
33
import { AlignmentEnum } from "typings/DatagridProps";
44

55
export type CellElementProps = {
@@ -14,7 +14,7 @@ export type CellElementProps = {
1414
wrapText?: boolean;
1515
["aria-hidden"]?: boolean;
1616
tabIndex?: number;
17-
} & Omit<JSX.IntrinsicElements["div"], "ref" | "children">;
17+
} & Omit<ComponentPropsWithoutRef<"div">, "children">;
1818

1919
const component = forwardRef<HTMLDivElement, CellElementProps>(function CellElement(
2020
{ className, borderTop, clickable, previewAsHidden, wrapText, alignment, tabIndex, ...rest }: CellElementProps,

packages/pluggableWidgets/datagrid-web/src/components/Grid.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import classNames from "classnames";
2-
import { JSX, ReactElement } from "react";
2+
import { ComponentPropsWithoutRef, ReactElement } from "react";
33

4-
type P = Omit<JSX.IntrinsicElements["div"], "role" | "ref">;
4+
type P = Omit<ComponentPropsWithoutRef<"div">, "role">;
55

66
export interface GridProps extends P {
77
className?: string;

packages/pluggableWidgets/datagrid-web/src/components/WidgetFooter.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ReactElement, ReactNode } from "react";
1+
import { ComponentPropsWithoutRef, ReactElement, ReactNode } from "react";
22
import { PaginationEnum } from "../../typings/DatagridProps";
33

44
type WidgetFooterProps = {
@@ -8,7 +8,7 @@ type WidgetFooterProps = {
88
loadMoreButtonCaption?: string;
99
hasMoreItems: boolean;
1010
setPage?: (computePage: (prevPage: number) => number) => void;
11-
} & React.JSX.IntrinsicElements["div"];
11+
} & ComponentPropsWithoutRef<"div">;
1212

1313
export function WidgetFooter(props: WidgetFooterProps): ReactElement | null {
1414
const { pagination, selectionCount, paginationType, loadMoreButtonCaption, hasMoreItems, setPage, ...rest } = props;

packages/pluggableWidgets/datagrid-web/src/components/WidgetHeader.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { JSX, ReactElement } from "react";
1+
import { ComponentPropsWithoutRef, ReactElement } from "react";
22

33
type WidgetHeaderProps = {
44
headerTitle?: string;
5-
} & JSX.IntrinsicElements["div"];
5+
} & ComponentPropsWithoutRef<"div">;
66

77
export function WidgetHeader(props: WidgetHeaderProps): ReactElement | null {
88
const { children, headerTitle, ...rest } = props;

packages/pluggableWidgets/datagrid-web/src/components/WidgetRoot.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import classNames from "classnames";
2-
import { JSX, ReactElement, useMemo, useRef } from "react";
2+
import { ComponentPropsWithoutRef, ReactElement, useMemo, useRef } from "react";
33
import { SelectionMethod } from "../helpers/SelectActionHelper";
44

5-
type P = JSX.IntrinsicElements["div"];
5+
type P = ComponentPropsWithoutRef<"div">;
66

77
export interface WidgetRootProps extends P {
88
className?: string;

packages/pluggableWidgets/datagrid-web/src/components/WidgetTopBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { ReactElement, ReactNode } from "react";
1+
import { ComponentPropsWithoutRef, ReactElement, ReactNode } from "react";
22

33
type WidgetTopBarProps = {
44
pagination: ReactNode;
55
selectionCount: ReactNode;
6-
} & JSX.IntrinsicElements["div"];
6+
} & ComponentPropsWithoutRef<"div">;
77

88
export function WidgetTopBar(props: WidgetTopBarProps): ReactElement {
99
const { pagination, selectionCount, ...rest } = props;

packages/pluggableWidgets/datagrid-web/src/helpers/state/column/ColumnStore.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
ObjectItem,
88
ValueStatus
99
} from "mendix";
10-
import { JSX, KeyboardEvent, ReactElement, ReactNode } from "react";
10+
import { ComponentPropsWithoutRef, KeyboardEvent, ReactElement, ReactNode } from "react";
1111
import { AlignmentEnum, ColumnsType } from "../../../../typings/DatagridProps";
1212
import { ColumnId, GridColumn } from "../../../typings/GridColumn";
1313
import { Big } from "big.js";
@@ -269,7 +269,7 @@ function CustomContent({
269269
children: ReactNode;
270270
allowEventPropagation: boolean;
271271
}): ReactElement {
272-
const wrapperProps: JSX.IntrinsicElements["div"] = allowEventPropagation
272+
const wrapperProps: ComponentPropsWithoutRef<"div"> = allowEventPropagation
273273
? {}
274274
: {
275275
onClick: stopPropagation,

packages/pluggableWidgets/gallery-web/src/Gallery.editorPreview.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { getColumnAndRowBasedOnIndex } from "@mendix/widget-plugin-grid/selectio
77
import { getGlobalSortContext } from "@mendix/widget-plugin-sorting/react/context";
88
import { SortStoreHost } from "@mendix/widget-plugin-sorting/stores/SortStoreHost";
99
import { GUID, ObjectItem } from "mendix";
10-
import { createElement, ReactElement, ReactNode, useCallback, useMemo } from "react";
10+
import { createElement, ReactElement, ReactNode, RefObject, useCallback, useMemo } from "react";
1111
import { GalleryPreviewProps } from "../typings/GalleryProps";
1212
import { Gallery as GalleryComponent } from "./components/Gallery";
1313
import { useItemEventsController } from "./features/item-interaction/ItemEventsController";
@@ -64,7 +64,7 @@ function Preview(props: GalleryPreviewProps): ReactElement {
6464
);
6565

6666
return (
67-
<div ref={containerRef as React.RefObject<HTMLDivElement>}>
67+
<div ref={containerRef as RefObject<HTMLDivElement>}>
6868
<GalleryComponent
6969
className={props.class}
7070
desktopItems={props.desktopItems!}

0 commit comments

Comments
 (0)