Skip to content

Commit 0fa1b16

Browse files
committed
feat(chekbox-radio-selection-web): rename emptyOptionText to noOptionsText
1 parent fdc59c0 commit 0fa1b16

22 files changed

+57
-57
lines changed

packages/pluggableWidgets/checkbox-radio-selection-web/src/CheckboxRadioSelection.editorPreview.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export const preview = (props: CheckboxRadioSelectionPreviewProps): ReactElement
2323
readOnlyStyle: props.readOnlyStyle,
2424
ariaRequired: dynamic(false),
2525
groupName: dynamic(`${id}-group`),
26-
emptyOptionText: "NO OPTIONS AVAILABLE"
26+
noOptionsText: "No options available"
2727
};
2828

2929
// eslint-disable-next-line react-hooks/rules-of-hooks

packages/pluggableWidgets/checkbox-radio-selection-web/src/CheckboxRadioSelection.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ export default function CheckboxRadioSelection(props: CheckboxRadioSelectionCont
1919
readOnlyStyle: props.readOnlyStyle,
2020
ariaRequired: props.ariaRequired,
2121
groupName: props.groupName,
22-
emptyOptionText: props.emptyOptionText?.value ?? "NO OPTIONS AVAILABLE"
22+
noOptionsText: props.noOptionsText?.value ?? "No options available"
2323
};
2424

2525
return (
2626
<div className={`widget-checkbox-radio-selection`}>
2727
{selector.status === "unavailable" ? (
28-
<Placeholder emptyOptionText={commonProps.emptyOptionText} />
28+
<Placeholder noOptionsText={commonProps.noOptionsText} />
2929
) : selector.type === "single" ? (
3030
<RadioSelection selector={selector} {...commonProps} />
3131
) : (

packages/pluggableWidgets/checkbox-radio-selection-web/src/CheckboxRadioSelection.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,12 +182,12 @@
182182
<!-- STATIC END-->
183183
<!-- GENERAL -->
184184
<propertyGroup caption="General">
185-
<property key="emptyOptionText" type="textTemplate" required="false">
186-
<caption>Empty option text</caption>
185+
<property key="noOptionsText" type="textTemplate" required="false">
186+
<caption>No option text</caption>
187187
<description />
188188
<translations>
189-
<translation lang="en_US">NO OPTIONS AVAILABLE</translation>
190-
<translation lang="nl_NL">GEEN OPTIES BESCHIKBAAR</translation>
189+
<translation lang="en_US">No options available</translation>
190+
<translation lang="nl_NL">Geen opties beschikbaar</translation>
191191
</translations>
192192
</property>
193193
<property key="optionsSourceCustomContentType" type="enumeration" defaultValue="no" required="true">

packages/pluggableWidgets/checkbox-radio-selection-web/src/components/CheckboxSelection/CheckboxSelection.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export function CheckboxSelection({
1111
ariaRequired,
1212
readOnlyStyle,
1313
groupName,
14-
emptyOptionText
14+
noOptionsText
1515
}: SelectionBaseProps<MultiSelector>): ReactElement {
1616
const options = selector.getOptions();
1717
const currentIds = selector.currentId || [];
@@ -70,7 +70,7 @@ export function CheckboxSelection({
7070
</div>
7171
);
7272
})}
73-
{options.length === 0 && <Placeholder emptyOptionText={emptyOptionText} />}
73+
{options.length === 0 && <Placeholder noOptionsText={noOptionsText} />}
7474
</div>
7575
);
7676
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { ReactElement, createElement } from "react";
22

3-
export function Placeholder({ emptyOptionText }: { emptyOptionText: string }): ReactElement {
3+
export function Placeholder({ noOptionsText }: { noOptionsText: string }): ReactElement {
44
return (
55
<div className="form-control widget-checkbox-radio-selection-placeholder">
6-
<div className="widget-checkbox-radio-selection-placeholder-content">{emptyOptionText}</div>
6+
<div className="widget-checkbox-radio-selection-placeholder-content">{noOptionsText}</div>
77
</div>
88
);
99
}

packages/pluggableWidgets/checkbox-radio-selection-web/src/components/RadioSelection/RadioSelection.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export function RadioSelection({
1212
ariaRequired,
1313
readOnlyStyle,
1414
groupName,
15-
emptyOptionText
15+
noOptionsText
1616
}: SelectionBaseProps<SingleSelector>): ReactElement {
1717
const asSingleCheckbox = selector.controlType === "checkbox";
1818

@@ -88,7 +88,7 @@ export function RadioSelection({
8888
</div>
8989
);
9090
})}
91-
{options.length === 0 && <Placeholder emptyOptionText={emptyOptionText} />}
91+
{options.length === 0 && <Placeholder noOptionsText={noOptionsText} />}
9292
</div>
9393
);
9494
}

packages/pluggableWidgets/checkbox-radio-selection-web/src/helpers/Association/AssociationSimpleCaptionsProvider.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { OptionsSourceCustomContentTypeEnum } from "../../../typings/CheckboxRad
44
import { CaptionsProvider } from "../types";
55

66
interface AssociationSimpleCaptionsProviderProps {
7-
emptyOptionText?: DynamicValue<string>;
7+
noOptionsText?: DynamicValue<string>;
88
formattingAttributeOrExpression?: ListAttributeValue<string> | ListExpressionValue<string>;
99
customContent?: ListWidgetValue;
1010
customContentType: OptionsSourceCustomContentTypeEnum;
@@ -22,10 +22,10 @@ export class AssociationSimpleCaptionsProvider implements CaptionsProvider {
2222
}
2323

2424
updateProps(props: AssociationSimpleCaptionsProviderProps): void {
25-
if (!props.emptyOptionText || props.emptyOptionText.status === "unavailable") {
25+
if (!props.noOptionsText || props.noOptionsText.status === "unavailable") {
2626
this.emptyCaption = "";
2727
} else {
28-
this.emptyCaption = props.emptyOptionText.value!;
28+
this.emptyCaption = props.noOptionsText.value!;
2929
}
3030
this.formatter = props.formattingAttributeOrExpression;
3131
this.customContent = props.customContent;

packages/pluggableWidgets/checkbox-radio-selection-web/src/helpers/Association/BaseAssociationSelector.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ export class BaseAssociationSelector<T extends string | string[], R extends Refe
2828
}
2929

3030
updateProps(props: CheckboxRadioSelectionContainerProps): void {
31-
const [attr, ds, captionProvider, emptyOption, clearable, onChangeEvent, customContent, customContentType] =
31+
const [attr, ds, captionProvider, noOptions, clearable, onChangeEvent, customContent, customContentType] =
3232
extractAssociationProps(props);
3333

3434
this._attr = attr as R;
3535
this.caption.updateProps({
36-
emptyOptionText: emptyOption,
36+
noOptionsText: noOptions,
3737
formattingAttributeOrExpression: captionProvider,
3838
customContent,
3939
customContentType
@@ -49,8 +49,8 @@ export class BaseAssociationSelector<T extends string | string[], R extends Refe
4949
!ds ||
5050
ds.status === "unavailable" ||
5151
!captionProvider ||
52-
!emptyOption ||
53-
emptyOption.status === "unavailable"
52+
!noOptions ||
53+
noOptions.status === "unavailable"
5454
) {
5555
this.status = "unavailable";
5656
this.currentId = null;

packages/pluggableWidgets/checkbox-radio-selection-web/src/helpers/Association/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export function extractAssociationProps(
3636
: props.optionsSourceAssociationCaptionExpression!;
3737

3838
// For simplicity, we'll create a basic empty option
39-
const emptyOption: DynamicValue<string> = {
39+
const noOptions: DynamicValue<string> = {
4040
status: ValueStatus.Available,
4141
value: ""
4242
};
@@ -48,5 +48,5 @@ export function extractAssociationProps(
4848
const customContent = props.optionsSourceAssociationCustomContent;
4949
const customContentType = props.optionsSourceCustomContentType;
5050

51-
return [attr, ds, captionProvider, emptyOption, clearable, onChangeEvent, customContent, customContentType];
51+
return [attr, ds, captionProvider, noOptions, clearable, onChangeEvent, customContent, customContentType];
5252
}

packages/pluggableWidgets/checkbox-radio-selection-web/src/helpers/Database/DatabaseCaptionsProvider.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { OptionsSourceCustomContentTypeEnum } from "../../../typings/CheckboxRad
55
import { CaptionsProvider } from "../types";
66

77
interface DatabaseCaptionsProviderProps {
8-
emptyOptionText?: DynamicValue<string>;
8+
noOptionsText?: DynamicValue<string>;
99
formattingAttributeOrExpression?: ListAttributeValue<string> | ListExpressionValue<string>;
1010
customContent?: ListWidgetValue;
1111
customContentType: OptionsSourceCustomContentTypeEnum;
@@ -25,10 +25,10 @@ export class DatabaseCaptionsProvider implements CaptionsProvider {
2525
}
2626

2727
updateProps(props: DatabaseCaptionsProviderProps): void {
28-
if (!props.emptyOptionText || props.emptyOptionText.status === "unavailable") {
28+
if (!props.noOptionsText || props.noOptionsText.status === "unavailable") {
2929
this.emptyCaption = "";
3030
} else {
31-
this.emptyCaption = props.emptyOptionText.value!;
31+
this.emptyCaption = props.noOptionsText.value!;
3232
}
3333
this.formatter = props.formattingAttributeOrExpression;
3434
this.customContent = props.customContent;

0 commit comments

Comments
 (0)