fix: cached profiles when user is deleted (#78)

Author: gusye1234

Changelog.md

@@ -1,4 +1,14 @@
-### [0.0.33] -2025/5/26
+### [0.0.34] - unrealeased
+
+**Fixed**
+
+- remove cached profiles after user is deleted
+
+
+
+
+
+### [0.0.33] - 2025/5/26
 
 **Added**
 
@@ -15,7 +25,7 @@
 
 
 
-### [0.0.32] -2025/5/14
+### [0.0.32] - 2025/5/14
 
 **Added**
 

src/server/api/memobase_server/controllers/profile.py

@@ -1,7 +1,7 @@
 from pydantic import ValidationError
 from ..models.utils import Promise
 from ..models.database import GeneralBlob, UserProfile
-from ..models.response import CODE, IdData, IdsData, UserProfilesData
+from ..models.response import CODE, IdData, IdsData, UserProfilesData, ProfileAttributes
 from ..connectors import Session, get_redis_client
 from ..utils import get_encoded_tokens
 from ..env import LOG, CONFIG
@@ -122,6 +122,13 @@ async def add_user_profiles(
     assert len(profiles) == len(
         attributes
     ), "Length of profiles, attributes must be equal"
+    for attr in attributes:
+        try:
+            ProfileAttributes.model_validate(attr)
+        except ValidationError as e:
+            return Promise.reject(
+                CODE.SERVER_PARSE_ERROR, f"Invalid profile attributes: {e}"
+            )
     with Session() as session:
         db_profiles = [
             UserProfile(
@@ -132,8 +139,7 @@ async def add_user_profiles(
         session.add_all(db_profiles)
         session.commit()
         profile_ids = [profile.id for profile in db_profiles]
-    async with get_redis_client() as redis_client:
-        await redis_client.delete(f"user_profiles::{project_id}::{user_id}")
+    await refresh_user_profile_cache(user_id, project_id)
     return Promise.resolve(IdsData(ids=profile_ids))
 
 
@@ -166,8 +172,7 @@ async def update_user_profiles(
                 db_profile.attributes = attribute
             db_profiles.append(profile_id)
         session.commit()
-    async with get_redis_client() as redis_client:
-        await redis_client.delete(f"user_profiles::{project_id}::{user_id}")
+    await refresh_user_profile_cache(user_id, project_id)
     return Promise.resolve(IdsData(ids=db_profiles))
 
 
@@ -186,8 +191,7 @@ async def delete_user_profile(
             )
         session.delete(db_profile)
         session.commit()
-    async with get_redis_client() as redis_client:
-        await redis_client.delete(f"user_profiles::{project_id}::{user_id}")
+    await refresh_user_profile_cache(user_id, project_id)
     return Promise.resolve(None)
 
 
@@ -201,6 +205,11 @@ async def delete_user_profiles(
             UserProfile.project_id == project_id,
         ).delete(synchronize_session=False)
         session.commit()
+    await refresh_user_profile_cache(user_id, project_id)
+    return Promise.resolve(IdsData(ids=profile_ids))
+
+
+async def refresh_user_profile_cache(user_id: str, project_id: str) -> Promise[None]:
     async with get_redis_client() as redis_client:
         await redis_client.delete(f"user_profiles::{project_id}::{user_id}")
-    return Promise.resolve(IdsData(ids=profile_ids))
+    return Promise.resolve(None)

src/server/api/memobase_server/controllers/user.py

@@ -2,6 +2,7 @@
 from ..models.database import User, GeneralBlob, UserProfile
 from ..models.response import CODE, UserData, IdData, IdsData, UserProfilesData
 from ..connectors import Session
+from .profile import refresh_user_profile_cache
 from ..models.blob import BlobType
 
 
@@ -58,7 +59,8 @@ async def delete_user(user_id: str, project_id: str) -> Promise[None]:
             return Promise.reject(CODE.NOT_FOUND, f"User {user_id} not found")
         session.delete(db_user)
         session.commit()
-        return Promise.resolve(None)
+    await refresh_user_profile_cache(user_id, project_id)
+    return Promise.resolve(None)
 
 
 async def get_user_all_blobs(

src/server/api/memobase_server/models/response.py

@@ -63,6 +63,11 @@ class ChatModalResponse(BaseModel):
     )
 
 
+class ProfileAttributes(BaseModel):
+    topic: str = Field(..., description="The topic of the profile")
+    sub_topic: str = Field(..., description="The sub-topic of the profile")
+
+
 class ProfileData(BaseModel):
     id: UUID = Field(..., description="The profile's unique identifier")
     content: str = Field(..., description="User profile content value")

src/server/api/tests/test_controller.py

@@ -1,5 +1,5 @@
 import pytest
-from memobase_server import controllers
+from memobase_server.controllers import full as controllers
 from memobase_server.models import response as res
 from memobase_server.models.blob import BlobType
 from memobase_server.models.database import DEFAULT_PROJECT_ID
@@ -30,6 +30,38 @@ async def test_user_curd(db_env):
     assert not p.ok()
 
 
+@pytest.mark.asyncio
+async def test_user_state_clean(db_env):
+    p = await controllers.user.create_user(
+        res.UserData(data={"test": 1}), DEFAULT_PROJECT_ID
+    )
+    assert p.ok()
+    d = p.data()
+    u_id = d.id
+
+    p = await controllers.user.get_user(u_id, DEFAULT_PROJECT_ID)
+    assert p.ok()
+    d = p.data().data
+    assert d["test"] == 1
+
+    p = await controllers.profile.add_user_profiles(
+        u_id, DEFAULT_PROJECT_ID, ["test"], [{"topic": "test", "sub_topic": "test"}]
+    )
+    assert p.ok()
+    p = await controllers.profile.get_user_profiles(u_id, DEFAULT_PROJECT_ID)
+    assert p.ok()
+    d = p.data()
+    assert len(d.profiles) == 1
+    assert d.profiles[0].attributes == {"topic": "test", "sub_topic": "test"}
+
+    p = await controllers.user.delete_user(u_id, DEFAULT_PROJECT_ID)
+    assert p.ok()
+    p = await controllers.user.get_user(u_id, DEFAULT_PROJECT_ID)
+    assert not p.ok()
+    p = await controllers.profile.get_user_profiles(u_id, DEFAULT_PROJECT_ID)
+    assert p.ok() and len(p.data().profiles) == 0
+
+
 @pytest.mark.asyncio
 async def test_blob_curd(db_env):
     p = await controllers.user.create_user(res.UserData(), DEFAULT_PROJECT_ID)