Skip to content

Commit 5dcee1b

Browse files
committed
Minor fixes
1 parent 068c242 commit 5dcee1b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/settings.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ pub struct Settings {
205205
/// Proximity precision settings.
206206
#[serde(skip_serializing_if = "Option::is_none")]
207207
pub proximity_precision: Option<String>,
208-
/// Settings how the embeddings for the vector search feature are generated
208+
/// Embedders translate documents and queries into vector embeddings
209209
#[serde(skip_serializing_if = "Option::is_none")]
210210
pub embedders: Option<HashMap<String, Embedder>>,
211211
/// SearchCutoffMs settings.
@@ -433,13 +433,13 @@ impl Settings {
433433
#[must_use]
434434
pub fn with_embedders<S>(self, embedders: HashMap<S, Embedder>) -> Settings
435435
where
436-
S: AsRef<str>,
436+
S: Into<String>,
437437
{
438438
Settings {
439439
embedders: Some(
440440
embedders
441441
.into_iter()
442-
.map(|(key, value)| (key.as_ref().to_string(), value))
442+
.map(|(key, value)| (key.into(), value))
443443
.collect(),
444444
),
445445
..self
@@ -2595,7 +2595,7 @@ mod tests {
25952595
}
25962596

25972597
#[meilisearch_test]
2598-
async fn test_get_embeddings(index: Index) {
2598+
async fn test_get_embedders(index: Index) {
25992599
let res = index.get_embedders().await.unwrap();
26002600

26012601
assert_eq!(HashMap::new(), res);
@@ -2854,7 +2854,7 @@ mod tests {
28542854
}
28552855

28562856
#[meilisearch_test]
2857-
async fn test_set_embedding_settings(client: Client, index: Index) {
2857+
async fn test_set_embedder_settings(client: Client, index: Index) {
28582858
let custom_embedder = Embedder {
28592859
source: EmbedderSource::UserProvided,
28602860
dimensions: Some(2),

0 commit comments

Comments
 (0)