Skip to content

Commit 3e93c11

Browse files
committed
Avoid avoidable clones
1 parent 147f1e4 commit 3e93c11

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/settings.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,9 @@ impl Settings {
289289
}
290290

291291
#[must_use]
292-
pub fn with_faceting(self, faceting: &FacetingSettings) -> Settings {
293-
let faceting_clone = FacetingSettings {
294-
max_values_per_facet: faceting.max_values_per_facet,
295-
sort_facet_values_by: faceting.sort_facet_values_by.clone(),
296-
};
292+
pub fn with_faceting(self, faceting: FacetingSettings) -> Settings {
297293
Settings {
298-
faceting: Some(faceting_clone),
294+
faceting: Some(faceting),
299295
..self
300296
}
301297
}
@@ -2381,7 +2377,7 @@ mod tests {
23812377
max_values_per_facet: 5,
23822378
sort_facet_values_by: Some(req_facet_sort_setting),
23832379
};
2384-
let settings = Settings::new().with_faceting(&req_faceting);
2380+
let settings = Settings::new().with_faceting(req_faceting.clone());
23852381

23862382
let task_info = index.set_settings(&settings).await.unwrap();
23872383
client.wait_for_task(task_info, None, None).await.unwrap();

0 commit comments

Comments
 (0)