Skip to content

Make overlay buttons accessible #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make overlay buttons accessible #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DefaultPlayer/DefaultPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ const DefaultPlayer = ({
</video>
<Overlay
onClick={onPlayPauseClick}
copy={copy.overlay}
{...video} />
{ controls && controls.length && !video.error
? <div className={styles.controls}>
Expand Down
15 changes: 15 additions & 0 deletions src/DefaultPlayer/Overlay/Overlay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
margin-left: -30px;
background-color: rgba(0,0,0,0.7);
border-radius: 10px;
border: none;
padding:0;
outline: none;
cursor: pointer;
}

.icon {
Expand All @@ -34,3 +38,14 @@
margin-left: -20px;
transform: translateY(-50%);
}

.srOnly {
border: 0;
clip: rect(0 0 0 0);
height: 1px;
margin: -1px;
overflow: hidden;
padding: 0;
position: absolute;
width: 1px;
}
32 changes: 18 additions & 14 deletions src/DefaultPlayer/Overlay/Overlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,44 +9,48 @@ export default class Overlay extends Component {
const {
error,
paused,
loading
loading,
copy
} = this.props;
const iconProps = {
className: styles.icon,
height: 40,
width: 40,
fill: '#fff'
fill: '#fff',
'aria-hidden': true,
};
if (error) {
return (
<span className={styles.inner}>
<button className={styles.inner}>
<span className={styles.srOnly}>{copy.error}</span>
<Report {...iconProps} />
</span>
</button>
);
} else if (loading) {
return (
<span className={styles.inner}>
<button className={styles.inner}>
<span className={styles.srOnly}>{copy.loading}</span>
<Spin {...iconProps} />
</span>
</button>
);
} else if (paused) {
return (
<span className={styles.inner}>
<button className={styles.inner}>
<span className={styles.srOnly}>{copy.paused}</span>
<PlayArrow {...iconProps} />
</span>
</button>
);
}
}

render () {
const { className, onClick } = this.props;
return (
<div className={[
styles.component,
className
].join(' ')}
onClick={onClick}>
{ this.renderContent() }
<div
className={[styles.component, className].join(' ')}
onClick={onClick}
>
{this.renderContent()}
</div>
);
}
Expand Down
7 changes: 6 additions & 1 deletion src/DefaultPlayer/copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ const copy = {
volume: 'Change volume',
fullscreen: 'View video fullscreen',
seek: 'Seek video',
captions: 'Toggle captions'
captions: 'Toggle captions',
overlay: {
loading: 'Loading Video...',
paused: 'Play Video',
error: 'Unable to play video'
}
};

export default copy;