imgtool: Add new tests for key operations

Refactor test_keys.py
Move constants to separate file
Verify key type in all testcases
Add tests for generating keys with password
Add more testcases for getpriv command
Add more testcases for getpub command
Add more testcases for getpubhash command
Update list of expected to fail tests

Signed-off-by: Rustam Ismayilov <rustam.ismayilov@arm.com>
Change-Id: If48a1c1496aced2e6f69f317f200aafc08d55538

Author: rustammendel

scripts/tests/conftest.py

@@ -16,13 +16,23 @@
 
 # List of tests expected to fail for some reason
 XFAILED_TESTS = {
-    "tests/test_keys.py::test_getpriv[openssl-ed25519]",
-    "tests/test_keys.py::test_getpriv[openssl-x25519]",
-    "tests/test_keys.py::test_getpriv[pkcs8-rsa-2048]",
-    "tests/test_keys.py::test_getpriv[pkcs8-rsa-3072]",
-    "tests/test_keys.py::test_getpriv[pkcs8-ed25519]",
-    "tests/test_keys.py::test_getpub[pem-ed25519]",
-    "tests/test_keys.py::test_sign_verify[x25519]",
+    # Unsupported key_type and format combinations
+    "tests/test_keys.py::TestGetPriv::test_getpriv[openssl-ed25519]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv[openssl-x25519]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv[pkcs8-rsa-2048]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv[pkcs8-rsa-3072]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv[pkcs8-ed25519]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv_with_password[openssl-ed25519]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv_with_password[openssl-x25519]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv_with_password[pkcs8-rsa-2048]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv_with_password[pkcs8-rsa-3072]",
+    "tests/test_keys.py::TestGetPriv::test_getpriv_with_password[pkcs8-ed25519]",
+    # 'Ed25519' object has no attribute 'get_public_pem'
+    "tests/test_keys.py::TestGetPub::test_getpub[pem-ed25519]",
+    "tests/test_keys.py::TestGetPub::test_getpub_with_encoding[pem-ed25519]",
+    "tests/test_keys.py::TestGetPub::test_getpub_no_outfile[pem-ed25519]",
+    "tests/test_keys.py::TestLoading::test_load_key_public[pem-ed25519]",
+    "tests/test_keys.py::TestLoading::test_load_key_public_with_password[pem-ed25519]",
 }
 
 

scripts/tests/constants.py

@@ -0,0 +1,43 @@
+# Copyright 2024 Arm Limited
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+from imgtool import main as imgtool_main
+
+# all supported key types for 'keygen'
+KEY_TYPES = [*imgtool_main.keygens]
+KEY_ENCODINGS = [*imgtool_main.valid_encodings]
+KEY_LANGS = [*imgtool_main.valid_langs]
+PUB_HASH_ENCODINGS = [*imgtool_main.valid_hash_encodings]
+PVT_KEY_FORMATS = [*imgtool_main.valid_formats]
+
+OPENSSL_KEY_TYPES = {
+    "rsa-2048": "Private-Key: (2048 bit, 2 primes)",
+    "rsa-3072": "Private-Key: (3072 bit, 2 primes)",
+    "ecdsa-p256": "Private-Key: (256 bit)",
+    "ecdsa-p384": "Private-Key: (384 bit)",
+    "ed25519": "ED25519 Private-Key:",
+    "x25519": "X25519 Private-Key:",
+}
+GEN_KEY_EXT = ".key"
+PUB_KEY_EXT = ".pub"
+PUB_KEY_HASH_EXT = ".pubhash"
+
+images_dir = "./images"
+signed_images_dir = images_dir + "/signed"
+
+
+def tmp_name(tmp_path, key_type, suffix=""):
+    return tmp_path / (key_type + suffix)