Fix build warnings and clippy lints

Author: gnunicorn

crates/matrix-sdk-base/src/client.rs

@@ -583,9 +583,9 @@ impl BaseClient {
             }
         }
 
-        changes.members.insert((&*room_id).to_owned(), members);
-        changes.profiles.insert((&*room_id).to_owned(), profiles);
-        changes.state.insert((&*room_id).to_owned(), state_events);
+        changes.members.insert((*room_id).to_owned(), members);
+        changes.profiles.insert((*room_id).to_owned(), profiles);
+        changes.state.insert((*room_id).to_owned(), state_events);
 
         Ok(user_ids)
     }

crates/matrix-sdk-crypto/src/identities/manager.rs

@@ -207,7 +207,7 @@ impl IdentityManager {
         user_id: Box<UserId>,
         device_map: BTreeMap<Box<DeviceId>, Raw<DeviceKeys>>,
     ) -> StoreResult<DeviceChanges> {
-        let own_device_id = (&*own_device_id).to_owned();
+        let own_device_id = (*own_device_id).to_owned();
 
         let mut changes = DeviceChanges::default();
 
@@ -420,7 +420,7 @@ impl IdentityManager {
                                 let result = private_identity.clear_if_differs(identity).await;
 
                                 if result.any_cleared() {
-                                    changed_identity = Some((&*private_identity).clone());
+                                    changed_identity = Some((*private_identity).clone());
                                     info!(cleared =? result, "Removed some or all of our private cross signing keys");
                                 }
                             }

crates/matrix-sdk-crypto/src/olm/account.rs

@@ -763,7 +763,7 @@ impl ReadOnlyAccount {
         DeviceKeys::new(
             (*self.user_id).to_owned(),
             (*self.device_id).to_owned(),
-            Self::ALGORITHMS.iter().map(|a| (&**a).clone()).collect(),
+            Self::ALGORITHMS.iter().map(|a| (**a).clone()).collect(),
             keys,
             BTreeMap::new(),
         )

crates/matrix-sdk-crypto/src/olm/group_sessions/inbound.rs

@@ -200,8 +200,8 @@ impl InboundGroupSession {
         PickledInboundGroupSession {
             pickle: InboundGroupSessionPickle::from(pickle),
             sender_key: self.sender_key.to_string(),
-            signing_key: (&*self.signing_keys).clone(),
-            room_id: (&*self.room_id).to_owned(),
+            signing_key: (*self.signing_keys).clone(),
+            room_id: (*self.room_id).to_owned(),
             forwarding_chains: self.forwarding_key_chain().to_vec(),
             imported: self.imported,
             backed_up: self.backed_up(),
@@ -261,11 +261,11 @@ impl InboundGroupSession {
 
         ExportedRoomKey {
             algorithm: EventEncryptionAlgorithm::MegolmV1AesSha2,
-            room_id: (&*self.room_id).to_owned(),
-            sender_key: (&*self.sender_key).to_owned(),
+            room_id: (*self.room_id).to_owned(),
+            sender_key: (*self.sender_key).to_owned(),
             session_id: self.session_id().to_owned(),
             forwarding_curve25519_key_chain: self.forwarding_key_chain().to_vec(),
-            sender_claimed_keys: (&*self.signing_keys).clone(),
+            sender_claimed_keys: (*self.signing_keys).clone(),
             session_key,
         }
     }

crates/matrix-sdk-crypto/src/olm/group_sessions/outbound.rs

@@ -300,7 +300,7 @@ impl OutboundGroupSession {
             ciphertext,
             sender_key: self.account_identity_keys.curve25519().to_owned(),
             session_id: self.session_id().to_owned(),
-            device_id: (&*self.device_id).to_owned(),
+            device_id: (*self.device_id).to_owned(),
         }
         .into();
 

crates/matrix-sdk-crypto/src/olm/session.rs

@@ -139,7 +139,7 @@ impl Session {
         let ciphertext = CiphertextInfo::new(ciphertext.1, (message_type as u32).into());
 
         let mut content = BTreeMap::new();
-        content.insert((&*self.sender_key).to_owned(), ciphertext);
+        content.insert((*self.sender_key).to_owned(), ciphertext);
 
         Ok(EncryptedEventScheme::OlmV1Curve25519AesSha2(OlmV1Curve25519AesSha2Content::new(
             content,

crates/matrix-sdk-crypto/src/olm/signing/mod.rs

@@ -451,7 +451,7 @@ impl PrivateCrossSigningIdentity {
 
         let mut signed_keys = BTreeMap::new();
         signed_keys
-            .entry((&*self.user_id).to_owned())
+            .entry((*self.user_id).to_owned())
             .or_insert_with(BTreeMap::new)
             .insert(device_keys.device_id.to_string(), serde_json::to_value(device_keys)?);
 

crates/matrix-sdk-crypto/src/store/caches.rs

@@ -90,7 +90,7 @@ impl GroupSessionStore {
     /// already in the store.
     pub fn add(&self, session: InboundGroupSession) -> bool {
         self.entries
-            .entry((&*session.room_id).to_owned())
+            .entry((*session.room_id).to_owned())
             .or_insert_with(HashMap::new)
             .entry(session.sender_key.to_string())
             .or_insert_with(HashMap::new)

crates/matrix-sdk-crypto/src/verification/requests.rs

@@ -952,7 +952,7 @@ impl RequestState<Ready> {
         request_handle: RequestHandle,
     ) -> Result<Sas, OutgoingContent> {
         Sas::from_start_event(
-            (&*self.flow_id).to_owned(),
+            (*self.flow_id).to_owned(),
             content,
             self.store.clone(),
             self.private_cross_signing_identity.clone(),

crates/matrix-sdk/src/client.rs

@@ -1689,7 +1689,7 @@ impl Client {
         Request: OutgoingRequest + Debug,
         HttpError: From<FromHttpResponseError<Request::EndpointError>>,
     {
-        Ok(self.inner.http_client.send(request, config).await?)
+        self.inner.http_client.send(request, config).await
     }
 
     /// Get information of all our own devices.